Skip to content
Permalink
Browse files
GIRAPH-1245
closes #137
  • Loading branch information
dlogothetis committed May 13, 2020
1 parent 5e4d7fb commit 4d046496439dff1da2e517a0081f939df1aaefae
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 6 deletions.
@@ -141,7 +141,6 @@ under the License.
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
<version>3.0.0</version>
<configuration>
<xmlOutput>true</xmlOutput>
<findbugsXmlOutput>false</findbugsXmlOutput>
@@ -646,11 +646,13 @@ public void connectAllAddresses(Collection<? extends TaskInfo> tasks) {
public void authenticate() {
LOG.info("authenticate: NettyClient starting authentication with " +
"servers.");
for (InetSocketAddress address: addressChannelMap.keySet()) {
for (Map.Entry<InetSocketAddress, ChannelRotater> entry :
addressChannelMap.entrySet()) {
if (LOG.isDebugEnabled()) {
LOG.debug("authenticate: Authenticating with address:" + address);
LOG.debug("authenticate: Authenticating with address:" +
entry.getKey());
}
ChannelRotater channelRotater = addressChannelMap.get(address);
ChannelRotater channelRotater = entry.getValue();
for (Channel channel: channelRotater.getChannels()) {
if (LOG.isDebugEnabled()) {
LOG.debug("authenticate: Authenticating with server on channel: " +
@@ -21,6 +21,7 @@
import it.unimi.dsi.fastutil.longs.Long2ObjectOpenHashMap;

import java.util.Arrays;
import java.util.Map;
import java.util.concurrent.ConcurrentMap;
import java.util.concurrent.atomic.AtomicLong;

@@ -131,8 +132,8 @@ public ByteWritable getTarget(LongWritable vertexId,
@Override
public void postFilling() {
// not thread-safe
for (Long id : concurrentIdToBytes.keySet()) {
idToBytes.put(id, concurrentIdToBytes.get(id));
for (Map.Entry<Long, byte[]> entry : concurrentIdToBytes.entrySet()) {
idToBytes.put(entry.getKey(), entry.getValue());
}
concurrentIdToBytes.clear();
concurrentIdToBytes = null;
@@ -109,6 +109,8 @@ public LocalDiskDataAccessor(
public void initialize() { }

@Override
@edu.umd.cs.findbugs.annotations.SuppressWarnings(
"NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE")
public void shutdown() {
for (String path : basePaths) {
File file = new File(path);
@@ -207,6 +207,8 @@ public GeneralClassesIterator(String packageName) {
* @param directory Directory from which we are adding files
* @param files List we add files to
*/
@edu.umd.cs.findbugs.annotations.SuppressWarnings(
"NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE")
private void addAllClassFiles(File directory, List<File> files) {
for (File file : directory.listFiles()) {
if (file.isDirectory()) {
@@ -34,6 +34,8 @@
* Byte array input stream that uses Unsafe methods to deserialize
* much faster
*/
@edu.umd.cs.findbugs.annotations.SuppressWarnings(
"RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT")
public class UnsafeArrayReads extends UnsafeReads {
/** Access to the unsafe class */
private static final sun.misc.Unsafe UNSAFE;
@@ -27,6 +27,8 @@
* Byte array input stream that uses Unsafe methods to deserialize
* much faster
*/
@edu.umd.cs.findbugs.annotations.SuppressWarnings(
"RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT")
public abstract class UnsafeReads extends Input implements ExtendedDataInput {

/**

0 comments on commit 4d04649

Please sign in to comment.