Skip to content

[VL] Sort by buffer size before hash shuffle evict partition buffers minSize#10009

Merged
marin-ma merged 1 commit into
apache:mainfrom
wForget:hash_shuffle
Jun 19, 2025
Merged

[VL] Sort by buffer size before hash shuffle evict partition buffers minSize#10009
marin-ma merged 1 commit into
apache:mainfrom
wForget:hash_shuffle

Conversation

@wForget

@wForget wForget commented Jun 19, 2025

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Sort by buffer size before hash shuffle evict partition buffers minSize, to evict partition buffers from large to small.

How was this patch tested?

minor improve

@github-actions github-actions Bot added the VELOX label Jun 19, 2025
@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@wForget wForget requested a review from marin-ma June 19, 2025 06:08

@marin-ma marin-ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@marin-ma marin-ma merged commit 31ff79f into apache:main Jun 19, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants