[VL] Fix broadcast hash table reuse for reused exchanges#12264
Open
wecharyu wants to merge 3 commits into
Open
[VL] Fix broadcast hash table reuse for reused exchanges#12264wecharyu wants to merge 3 commits into
wecharyu wants to merge 3 commits into
Conversation
|
Run Gluten Clickhouse CI on x86 |
liujiayi771
reviewed
Jun 9, 2026
| } | ||
| } | ||
|
|
||
| override def doCanonicalizeForBroadcastMode(mode: BroadcastMode): BroadcastMode = { |
Contributor
There was a problem hiding this comment.
Is this part still needed when buildHashTableOncePerExecutor is disabled?
Contributor
Author
There was a problem hiding this comment.
doCanonicalizeForBroadcastMode() is not invoked anywhere, broadcast canonicalization goes through ColumnarBroadcastExchangeExec.doCanonicalize().
|
Run Gluten Clickhouse CI on x86 |
wecharyu
force-pushed
the
fix_shared_bhj_table
branch
from
075dc89 to
7552606
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Create unique hash table ID with
plan_id,build_keys,join_typeandnull_aware, which determine the hash table contents.How was this patch tested?
Add UT.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex GPT-5.5