Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GORA-266 Lucene datastore for Gora - lewismc #152

Merged
merged 5 commits into from Mar 19, 2019

Conversation

djkevincr
Copy link
Member

This is based on #131 resolved conflicts and merged to master. However tests needs to be fixed.

@lewismc
Copy link
Member

lewismc commented Mar 18, 2019

I think this looks good. The only suggestion I have right now is to expand support for other keyClass implementations in LuceneQuery. There is currently a comment for NumericRangeQuery... maybe we can address this in a future pull request?

@djkevincr
Copy link
Member Author

djkevincr commented Mar 18, 2019

@lewismc I have created issue [1] on NumericRangeQuery. Let s address this separately. I think this PR is in good shape to be merged.
All major test cases passes without any issue.
[1] https://issues.apache.org/jira/browse/GORA-555

@lewismc
Copy link
Member

lewismc commented Mar 19, 2019

+1 @djkevincr

@djkevincr djkevincr merged commit 7047f10 into apache:master Mar 19, 2019
@djkevincr
Copy link
Member Author

@lewismc I have merged the PR. Thank you very much for your hard work on implementation and reviewing PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants