Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GORA-623 Javadoc build fails with Gora master branch #192

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@chanakadkb
Copy link
Contributor

chanakadkb commented Sep 3, 2019

As discussed in GORA-623, we should avoid generating JavaDocs for generated classes and this patch will add generated classes of Cassandra as test sources. (We have done the same for gora-core)
Build verified.

To address compiler issue GORA-632 is created

@lewismc

This comment has been minimized.

Copy link
Contributor

lewismc commented Sep 6, 2019

+1
Can someone please merge once build confirmed. Thanks

@djkevincr

This comment has been minimized.

Copy link
Member

djkevincr commented Sep 6, 2019

+1

2 similar comments
@cguzel

This comment has been minimized.

Copy link
Member

cguzel commented Sep 6, 2019

+1

@kamaci

This comment has been minimized.

Copy link
Member

kamaci commented Sep 6, 2019

+1

@lewismc lewismc merged commit d34e163 into apache:master Sep 6, 2019
@alfonsonishikawa

This comment has been minimized.

Copy link
Member

alfonsonishikawa commented Sep 6, 2019

Hi!

Sorry! I know I am a bit disconnected form this issue, but I don't understand what does gora-cassandra's pom.xml has to do with GORA-623 and GORA-632. Can anyone give me a fast insight? :S

Thank you!

@chanakadkb

This comment has been minimized.

Copy link
Contributor Author

chanakadkb commented Sep 6, 2019

Hi Alfonso,

Point is gora-compiler generates some erroneous Javadoc comments as mentioned in GORA-632. Generated files of cassandra (in #174 ) caused the build failure(GORA-623). But the question was, do we need to include those generated files in the Javadoc as they are used only for testing purposes. Here we named them as test sources so that they will be ignored when generating javadocs. But the root cause needs to be fixed in GORA-632

@alfonsonishikawa

This comment has been minimized.

Copy link
Member

alfonsonishikawa commented Sep 7, 2019

Hi Alfonso,

Point is gora-compiler generates some erroneous Javadoc comments as mentioned in GORA-632. Generated files of cassandra (in #174 ) caused the build failure(GORA-623). But the question was, do we need to include those generated files in the Javadoc as they are used only for testing purposes. Here we named them as test sources so that they will be ignored when generating javadocs. But the root cause needs to be fixed in GORA-632

Oh! I forgot that Cassadra has it's own generated test classes. Ok! Now I get it :) Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.