[GORA-638] Add gora-ignite into the gora-tutorial module #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djkevincr
requested changes
Oct 7, 2019
pom.xml
Outdated
| @@ -1012,6 +1012,17 @@ | |||
| <version>${project.version}</version> | |||
| <type>test-jar</type> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
<dependency>
<groupId>org.apache.gora</groupId>
<artifactId>gora-redis</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.gora</groupId>
<artifactId>gora-redis</artifactId>
<version>${project.version}</version>
<type>test-jar</type>
</dependency>
Do we need these redis dependencies as part of this PR?
There was a problem hiding this comment.
Sorry for that. I unintentionally mixed code from other experiments.
|
@joseph6x Thank you for your contribution. :) This looks good to me. I will locally test and merge the PR. |
djkevincr
approved these changes
Oct 22, 2019
djkevincr
approved these changes
Mar 4, 2020
|
@joseph6x I merged your PR. Thank you for this and looking forward for your future contributions. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Ignite in the gora-tutorial module.
As part of my experiments with Gora, I tried to add ignite in the tutorial module using other other databases as example. Please let me know if I missed something.