Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue GORA-503 #94

Merged
merged 1 commit into from Dec 17, 2017
Merged

Fixed issue GORA-503 #94

merged 1 commit into from Dec 17, 2017

Conversation

@cloudysunny14
Copy link
Contributor

cloudysunny14 commented Feb 16, 2017

Field index 0 is always considered as clean even if it is dirty.

@lewismc

This comment has been minimized.

Copy link
Contributor

lewismc commented Feb 16, 2017

Any comments @renato2099 ?

@renato2099

This comment has been minimized.

Copy link
Contributor

renato2099 commented Feb 16, 2017

none @lewismc , would you mind committing this please?

@lewismc

This comment has been minimized.

Copy link
Contributor

lewismc commented Feb 16, 2017

OK I tried to test locally and I get the following

2017-02-16 10:35:10,490 INFO  [StorageServiceShutdownHook] gms.Gossiper (Gossiper.java:stop(1197)) - Announcing shutdown
2017-02-16 10:35:12,494 INFO  [StorageServiceShutdownHook] net.MessagingService (MessagingService.java:shutdown(686)) - Waiting for messaging service to quiesce
2017-02-16 10:35:12,495 INFO  [ACCEPT-localhost/127.0.0.1] net.MessagingService (MessagingService.java:run(868)) - MessagingService shutting down server thread.
2017-02-16 10:35:12,496 ERROR [StorageServiceShutdownHook] service.CassandraDaemon (CassandraDaemon.java:uncaughtException(187)) - Exception in thread Thread[StorageServiceShutdownHook,5,main]
java.io.IOError: java.io.IOException: Unknown error: 316
	at org.apache.cassandra.net.MessagingService.shutdown(MessagingService.java:701)
	at org.apache.cassandra.service.StorageService$1.runMayThrow(StorageService.java:546)
	at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28)
	at java.lang.Thread.run(Thread.java:745)
Caused by: java.io.IOException: Unknown error: 316
	at sun.nio.ch.NativeThread.signal(Native Method)
	at sun.nio.ch.ServerSocketChannelImpl.implCloseSelectableChannel(ServerSocketChannelImpl.java:292)
	at java.nio.channels.spi.AbstractSelectableChannel.implCloseChannel(AbstractSelectableChannel.java:234)
	at java.nio.channels.spi.AbstractInterruptibleChannel.close(AbstractInterruptibleChannel.java:115)
	at sun.nio.ch.ServerSocketAdaptor.close(ServerSocketAdaptor.java:137)
	at org.apache.cassandra.net.MessagingService$SocketThread.close(MessagingService.java:885)
	at org.apache.cassandra.net.MessagingService.shutdown(MessagingService.java:697)
	... 3 more

Results :

Failed tests:   org.apache.gora.cassandra.store.TestCassandraStore: attempted to delete non-existing file system-compaction_history-jb-531-CompressionInfo.db
@renato2099

This comment has been minimized.

Copy link
Contributor

renato2099 commented Feb 16, 2017

I have seen this as well but as the error points out it is the CassandraDeamon not being able to be stopped.

2017-02-16 10:35:12,496 ERROR [StorageServiceShutdownHook] service.CassandraDaemon (CassandraDaemon.java:uncaughtException(187)) - Exception in thread Thread[StorageServiceShutdownHook,5,main]
java.io.IOError: java.io.IOException: Unknown error: 316

Would you mind trying again? or with the same cassandra currently version supported by Gora?

@lewismc

This comment has been minimized.

Copy link
Contributor

lewismc commented Feb 17, 2017

I cannot avoid the error as above. Can you try running the test suite @renato2099 ?

@cloudysunny14

This comment has been minimized.

Copy link
Contributor Author

cloudysunny14 commented Mar 6, 2017

I tried to test localy, but I can't reproduce the error.
@lewismc Did you get this error since merging this fixes?

Thank you.

@lewismc

This comment has been minimized.

Copy link
Contributor

lewismc commented Mar 7, 2017

@lewismc

This comment has been minimized.

Copy link
Contributor

lewismc commented Dec 16, 2017

Any comments folks?

@alfonsonishikawa

This comment has been minimized.

Copy link
Member

alfonsonishikawa commented Dec 17, 2017

I tried locally too and can't reproduce the error. All tests pass.

I found this about your error: https://issues.apache.org/jira/browse/CASSANDRA-8220
Seems related to OSX and JDK8. https://stackoverflow.com/questions/32508530/cassandra-on-mac-stopping-cassandra-shows-error

I guess it can be committed safely :)

@asfgit asfgit merged commit 21ad6e9 into apache:master Dec 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.