minor refactor: fix read(char[], int, int) loop bound in LineColumnReader#2406
Closed
cuiweixie wants to merge 1 commit into
Closed
minor refactor: fix read(char[], int, int) loop bound in LineColumnReader#2406cuiweixie wants to merge 1 commit into
cuiweixie wants to merge 1 commit into
Conversation
…ader Use i < startOffset + length instead of i <= startOffset + length so the method reads at most length characters into the destination slice, matching BufferedReader semantics and avoiding an off-by-one past the requested range.
Contributor
|
It looks like JsonLexer usage makes assumptions about the old behavior. |
Contributor
|
Actually, the |
Contributor
|
Merged with an additional fix. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the loop upper bound in
LineColumnReader.read(char[], int, int)fromi <= startOffset + lengthtoi < startOffset + length.Rationale
The method should read at most
lengthcharacters into the slice[startOffset, startOffset + length), consistent withBufferedReadersemantics. The previous bound could process one character past that range.