Remove duplicate ReferenceBundle definitions #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed static initialization of default Soft/Weak bundles in ReferenceManager class. The methods in that class were not used in the codebase. Looking at the history of those static bundle references it appeared that 500 was the original threshold setting. Typical startup creates roughly 1000 managed references, so 500 seems like a more appropriate value than 5000.
|
+1 |
asfgit
pushed a commit
that referenced
this pull request
Jan 28, 2016
Removed static initialization of default Soft/Weak bundles in ReferenceManager class. The methods in that class were not used in the codebase. Looking at the history of those static bundle references it appeared that 500 was the original threshold setting. Typical startup creates roughly 1000 managed references, so 500 seems like a more appropriate value than 5000.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed static initialization of default Soft/Weak bundles in ReferenceManager class. The methods in that class were not used in the codebase. Looking at the history of those static bundle references it appeared that 500 was the original threshold setting. Typical startup creates roughly 1000 managed references, so 500 seems like a more appropriate value than 5000.
Note: the deprecated methods are in the
org.codehaus.groovy.utilpackage which might be considered non-public even though the methods are public. But just to be safe left them in place just in case they may be referenced in others code.