Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GROOVY-9175 migrate private methods to protected #956

Merged

Conversation

@aalmiray
Copy link
Contributor

@aalmiray aalmiray commented Jun 15, 2019

Fix for https://issues.apache.org/jira/browse/GROOVY-9175

@aalmiray
Copy link
Contributor Author

@aalmiray aalmiray commented Jun 15, 2019

PR failed to build with JDK10. Do we still have ti support this JDK version given that it has been superseded by JDK 11?

Loading

@danielsun1106
Copy link
Member

@danielsun1106 danielsun1106 commented Jun 15, 2019

Let me try to restart the build with JDK10. As far as I know, Groovy 3 requires Java 8+(not Java 11+).

Loading

@danielsun1106
Copy link
Member

@danielsun1106 danielsun1106 commented Jun 15, 2019

All builds are green ;-)

Loading

@danielsun1106 danielsun1106 merged commit 9a8f123 into apache:master Jun 28, 2019
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants