GUACAMOLE-753: Add TOTP auth method to Docker image #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necouchman
reviewed
Feb 6, 2020
mike-jumper
reviewed
Feb 10, 2020
|
Let's merge this @mike-jumper @necouchman ? |
necouchman
requested changes
Mar 4, 2020
jolentes
reviewed
Mar 24, 2020
necouchman
requested changes
Mar 24, 2020
|
Many thanks @jolentes for your positive feedback 👍 |
necouchman
approved these changes
Mar 24, 2020
|
Many thanks @necouchman 👍 |
|
Perhaps I should have rather pushed to the |
|
Sorry, it isn't slated for 1.2.0, it's slated for 1.3.0, so it was merged correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds TOTP authentication method to the Docker image.
It's really helpful, making TOTP easy to use with Docker.
Let's merge this low-impact PR with #469 in a 1.1.1 Docker image ?
Many thanks 👍