Permalink
Browse files

HADOOP-9247. Parametrize Clover generateXxx properties to make them r…

…e-definable via -D in mvn calls. Contributed by Ivan A. Veselovsky.

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1438698 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information...
1 parent 55f0d03 commit 75fd77d46b542af772c9d0b0e271e4eb614b5699 Suresh Srinivas committed Jan 25, 2013
Showing with 19 additions and 2 deletions.
  1. +3 −0 hadoop-common-project/hadoop-common/CHANGES.txt
  2. +16 −2 pom.xml
@@ -152,6 +152,9 @@ Trunk (Unreleased)
HADOOP-9245. mvn clean without running mvn install before fails.
(Karthik Kambatla via suresh)
+ HADOOP-9247. Parametrize Clover "generateXxx" properties to make them
+ re-definable via -D in mvn calls. (Ivan A. Veselovsky via suresh)
+
BUG FIXES
HADOOP-8419. Fixed GzipCode NPE reset for IBM JDK. (Yu Li via eyang)
View
18 pom.xml
@@ -517,6 +517,18 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<properties>
<cloverLicenseLocation>${user.home}/.clover.license</cloverLicenseLocation>
<cloverDatabase>${project.build.directory}/clover/hadoop-coverage.db</cloverDatabase>
+ <!-- NB: This additional parametrization is made in order
+ to be able to re-define these properties with "-Dk=v" maven options.
+ By some reason the expressions declared in clover
+ docs like "${maven.clover.generateHtml}" do not work in that way.
+ However, the below properties are confirmed to work: e.g.
+ -DcloverGenHtml=false switches off the Html generation.
+ The default values provided here exactly correspond to Clover defaults, so
+ the behavior is 100% backwards compatible. -->
+ <cloverAlwaysReport>true</cloverAlwaysReport>
+ <cloverGenHtml>true</cloverGenHtml>
+ <cloverGenXml>true</cloverGenXml>
+ <cloverGenHistorical>false</cloverGenHistorical>
</properties>
<build>
<plugins>
@@ -530,8 +542,10 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<cloverDatabase>${cloverDatabase}</cloverDatabase>
<targetPercentage>50%</targetPercentage>
<outputDirectory>${project.build.directory}/clover</outputDirectory>
- <generateHtml>true</generateHtml>
- <generateXml>true</generateXml>
+ <alwaysReport>${cloverAlwaysReport}</alwaysReport>
+ <generateHtml>${cloverGenHtml}</generateHtml>
+ <generateXml>${cloverGenXml}</generateXml>
+ <generateHistorical>${cloverGenHistorical}</generateHistorical>
</configuration>
<executions>
<execution>

0 comments on commit 75fd77d

Please sign in to comment.