Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-2565. Handle InterruptedException in VolumeSet #268

Closed
wants to merge 3 commits into from

Conversation

@cxorm
Copy link
Contributor

cxorm commented Nov 25, 2019

What changes were proposed in this pull request?

Re-Interrupt when catching the InterruptedException.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-2565

How was this patch tested?

UT Updating to validate the behavior.

@cxorm

This comment has been minimized.

Copy link
Contributor Author

cxorm commented Dec 3, 2019

/retest

@elek

This comment has been minimized.

Copy link
Member

elek commented Dec 3, 2019

FYI: /retest is not working (yet) with github actions. Just push an empty commit (git commit --allow-empty -m "...") and push it.

@cxorm

This comment has been minimized.

Copy link
Contributor Author

cxorm commented Dec 4, 2019

Thanks @elek for the information.

@cxorm

This comment has been minimized.

Copy link
Contributor Author

cxorm commented Dec 5, 2019

The acceptance test failure does not seem to be related to this patch.

@elek
elek approved these changes Dec 5, 2019
Copy link
Member

elek left a comment

+1 Thanks the contrinution @cxorm

The acceptance test is fixed in a newer commit (6c1a9ff) (Checked the error and this is the same).

Will merge it soon.

@elek elek closed this in 4f1869c Dec 5, 2019
@cxorm

This comment has been minimized.

Copy link
Contributor Author

cxorm commented Dec 5, 2019

Thanks @elek for the review and commit.

ChenSammi added a commit that referenced this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.