Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-1761. Fix class hierarchy for KeyRequest and FileRequest classes. #1052

Merged
merged 1 commit into from Jul 16, 2019

Conversation

bharatviswa504
Copy link
Contributor

No description provided.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 31 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 517 trunk passed
+1 compile 262 trunk passed
+1 checkstyle 64 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 836 branch has no errors when building and testing our client artifacts.
+1 javadoc 145 trunk passed
0 spotbugs 353 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 554 trunk passed
_ Patch Compile Tests _
+1 mvninstall 461 the patch passed
+1 compile 275 the patch passed
+1 javac 275 the patch passed
+1 checkstyle 68 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 654 patch has no errors when building and testing our client artifacts.
+1 javadoc 157 the patch passed
+1 findbugs 567 the patch passed
_ Other Tests _
+1 unit 253 hadoop-hdds in the patch passed.
-1 unit 2232 hadoop-ozone in the patch failed.
+1 asflicense 51 The patch does not generate ASF License warnings.
7286
Reason Tests
Failed junit tests hadoop.ozone.om.TestOzoneManagerHA
hadoop.ozone.scm.node.TestQueryNode
hadoop.ozone.TestStorageContainerManager
hadoop.hdds.scm.pipeline.TestSCMPipelineManager
hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1052/1/artifact/out/Dockerfile
GITHUB PR #1052
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux a601e36bba90 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 8965ddc
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1052/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1052/1/testReport/
Max. process+thread count 4515 (vs. ulimit of 5500)
modules C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1052/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@arp7 arp7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bharatviswa504
Copy link
Contributor Author

Thank You @arp7 for the review.
Test failures are not related to this patch. Will commit this to the trunk.

@bharatviswa504 bharatviswa504 merged commit 585f4d5 into apache:trunk Jul 16, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
![image](https://user-images.githubusercontent.com/46942335/58350496-e8b5f880-7e1a-11e9-8736-16f968146109.png)

Author: mynameborat <bharath.kumarasubramanian@gmail.com>

Reviewers: Prateek Maheshwari <pmaheshwari@apache.org>

Closes apache#1052 from mynameborat/async-documentation
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants