Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-1801. Make Topology Aware Replication/Read non-default for ozone… #1098

Closed
wants to merge 1 commit into from

Conversation

@xiaoyuyao
Copy link
Contributor

xiaoyuyao commented Jul 15, 2019

… 0.4.1. Contributed by Xiaoyu Yao.

… 0.4.1. Contributed by Xiaoyu Yao.
@xiaoyuyao xiaoyuyao self-assigned this Jul 15, 2019
@xiaoyuyao xiaoyuyao added the ozone label Jul 15, 2019
@hadoop-yetus

This comment has been minimized.

Copy link

hadoop-yetus commented Jul 15, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 36 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
0 shelldocs 0 Shelldocs was not available.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
0 mvndep 76 Maven dependency ordering for branch
+1 mvninstall 494 trunk passed
+1 compile 267 trunk passed
+1 checkstyle 71 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 764 branch has no errors when building and testing our client artifacts.
+1 javadoc 154 trunk passed
0 spotbugs 332 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 534 trunk passed
_ Patch Compile Tests _
0 mvndep 36 Maven dependency ordering for patch
+1 mvninstall 458 the patch passed
+1 compile 268 the patch passed
+1 javac 268 the patch passed
+1 checkstyle 84 the patch passed
+1 mvnsite 0 the patch passed
+1 shellcheck 0 There were no new shellcheck issues.
+1 whitespace 1 The patch has no whitespace issues.
+1 xml 1 The patch has no ill-formed XML file.
+1 shadedclient 665 patch has no errors when building and testing our client artifacts.
+1 javadoc 172 the patch passed
+1 findbugs 556 the patch passed
_ Other Tests _
-1 unit 291 hadoop-hdds in the patch failed.
-1 unit 1758 hadoop-ozone in the patch failed.
+1 asflicense 61 The patch does not generate ASF License warnings.
7007
Reason Tests
Failed junit tests hadoop.hdds.scm.container.placement.algorithms.TestContainerPlacementFactory
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestWatchForCommit
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1098/1/artifact/out/Dockerfile
GITHUB PR #1098
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml shellcheck shelldocs
uname Linux f654934193c1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 1411513
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1098/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1098/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1098/1/testReport/
Max. process+thread count 5238 (vs. ulimit of 5500)
modules C: hadoop-hdds/client hadoop-hdds/common hadoop-hdds/server-scm hadoop-ozone/dist U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1098/1/console
versions git=2.7.4 maven=3.3.9 shellcheck=0.4.6 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@xiaoyuyao xiaoyuyao requested review from ChenSammi and anuengineer Jul 16, 2019
Copy link
Contributor

anuengineer left a comment

+1, LGTM.

@anuengineer

This comment has been minimized.

Copy link
Contributor

anuengineer commented Jul 17, 2019

Thanks for the patch. I have committed this to the trunk

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
* [Docs] Adding rayman to committers list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.