HDDS-1768. Audit xxxAcl methods in OzoneManager

[dineshchitlangia]

@xiaoyuyao , @ajayydv - Request you to please review this PR. Thank you.

[dineshchitlangia]

/label ozone

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	46	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	25	Maven dependency ordering for branch
+1	mvninstall	621	trunk passed
+1	compile	380	trunk passed
+1	checkstyle	67	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	869	branch has no errors when building and testing our client artifacts.
+1	javadoc	154	trunk passed
0	spotbugs	456	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	669	trunk passed
		_ Patch Compile Tests _
0	mvndep	29	Maven dependency ordering for patch
+1	mvninstall	601	the patch passed
+1	compile	454	the patch passed
+1	javac	454	the patch passed
+1	checkstyle	82	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	1	The patch has no whitespace issues.
+1	shadedclient	687	patch has no errors when building and testing our client artifacts.
+1	javadoc	196	the patch passed
+1	findbugs	828	the patch passed
		_ Other Tests _
+1	unit	329	hadoop-hdds in the patch passed.
-1	unit	2874	hadoop-ozone in the patch failed.
+1	asflicense	59	The patch does not generate ASF License warnings.
		9127

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestReadRetries
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.client.rpc.TestOzoneRpcClientForAclAuditLog
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.TestMiniChaosOzoneCluster
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1204/1/artifact/out/Dockerfile
GITHUB PR	#1204
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux dc27ac67b899 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / e111789
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1204/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1204/1/testReport/
Max. process+thread count	3553 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-ozone/common hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1204/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	102	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	26	Maven dependency ordering for branch
+1	mvninstall	591	trunk passed
+1	compile	378	trunk passed
+1	checkstyle	79	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	955	branch has no errors when building and testing our client artifacts.
+1	javadoc	190	trunk passed
0	spotbugs	450	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	654	trunk passed
		_ Patch Compile Tests _
0	mvndep	30	Maven dependency ordering for patch
-1	mvninstall	311	hadoop-ozone in the patch failed.
-1	compile	256	hadoop-ozone in the patch failed.
-1	javac	256	hadoop-ozone in the patch failed.
+1	checkstyle	78	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	719	patch has no errors when building and testing our client artifacts.
+1	javadoc	165	the patch passed
-1	findbugs	416	hadoop-ozone in the patch failed.
		_ Other Tests _
-1	unit	359	hadoop-hdds in the patch failed.
-1	unit	44	hadoop-ozone in the patch failed.
+1	asflicense	36	The patch does not generate ASF License warnings.
		5993

Reason	Tests
Failed junit tests	hadoop.hdds.scm.block.TestBlockManager

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1204/2/artifact/out/Dockerfile
GITHUB PR	#1204
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 99deb6b4f21e 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 70b4617
Default Java	1.8.0_212
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1204/2/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1204/2/artifact/out/patch-compile-hadoop-ozone.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1204/2/artifact/out/patch-compile-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1204/2/artifact/out/patch-findbugs-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1204/2/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1204/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1204/2/testReport/
Max. process+thread count	358 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-ozone/common hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1204/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[dineshchitlangia]

@bharatviswa504 Thanks for reviewing. Updated PR to address review comments.

[bharatviswa504]

Overall LGTM.
Few minor comments posted in place

[dineshchitlangia]

@bharatviswa504 , @anuengineer - Verified the failures are unrelated to the test.

[bharatviswa504]

+1 LGTM.

[bharatviswa504]

Thank You @dineshchitlangia for the contribution.
I will commit this to the trunk.

[dineshchitlangia]

@bharatviswa504 thanks for review & commit.