Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-16481. ITestS3GuardDDBRootOperations.test_300_MetastorePrune needs to set region #1209

Merged

Conversation

@steveloughran
Copy link
Contributor

commented Aug 1, 2019

Change-Id: I26f8e9bc441bd1cb7b0d9b37161984049df6bac4

…eeds to set region.

Change-Id: I26f8e9bc441bd1cb7b0d9b37161984049df6bac4
@hadoop-yetus

This comment has been minimized.

Copy link

commented Aug 1, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 140 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 1544 trunk passed
+1 compile 47 trunk passed
+1 checkstyle 30 trunk passed
+1 mvnsite 53 trunk passed
+1 shadedclient 965 branch has no errors when building and testing our client artifacts.
+1 javadoc 35 trunk passed
0 spotbugs 79 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 76 hadoop-tools/hadoop-aws in trunk has 1 extant findbugs warnings.
_ Patch Compile Tests _
+1 mvninstall 42 the patch passed
+1 compile 43 the patch passed
+1 javac 43 the patch passed
+1 checkstyle 27 the patch passed
+1 mvnsite 43 the patch passed
+1 whitespace 1 The patch has no whitespace issues.
+1 shadedclient 987 patch has no errors when building and testing our client artifacts.
+1 javadoc 28 the patch passed
+1 findbugs 88 the patch passed
_ Other Tests _
+1 unit 308 hadoop-aws in the patch passed.
+1 asflicense 37 The patch does not generate ASF License warnings.
4599
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/1/artifact/out/Dockerfile
GITHUB PR #1209
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 5ada70474057 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / a7371a7
Default Java 1.8.0_222
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/1/artifact/out/branch-findbugs-hadoop-tools_hadoop-aws-warnings.html
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/1/testReport/
Max. process+thread count 307 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

This comment has been minimized.

Copy link

commented Aug 1, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 142 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 1443 trunk passed
+1 compile 45 trunk passed
+1 checkstyle 28 trunk passed
+1 mvnsite 50 trunk passed
+1 shadedclient 894 branch has no errors when building and testing our client artifacts.
+1 javadoc 31 trunk passed
0 spotbugs 81 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 78 hadoop-tools/hadoop-aws in trunk has 1 extant findbugs warnings.
_ Patch Compile Tests _
+1 mvninstall 39 the patch passed
+1 compile 34 the patch passed
+1 javac 34 the patch passed
+1 checkstyle 17 the patch passed
+1 mvnsite 41 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 847 patch has no errors when building and testing our client artifacts.
+1 javadoc 28 the patch passed
+1 findbugs 78 the patch passed
_ Other Tests _
+1 unit 288 hadoop-aws in the patch passed.
+1 asflicense 30 The patch does not generate ASF License warnings.
4211
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/2/artifact/out/Dockerfile
GITHUB PR #1209
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 2efbe3f0b231 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / e111789
Default Java 1.8.0_212
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/2/artifact/out/branch-findbugs-hadoop-tools_hadoop-aws-warnings.html
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/2/testReport/
Max. process+thread count 399 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@steveloughran

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

This is ready for review. @bgaborg -got a chance?

@steveloughran steveloughran requested a review from bgaborg Aug 7, 2019
@hadoop-yetus

This comment has been minimized.

Copy link

commented Aug 8, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 103 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 1238 trunk passed
+1 compile 35 trunk passed
+1 checkstyle 24 trunk passed
+1 mvnsite 34 trunk passed
+1 shadedclient 793 branch has no errors when building and testing our client artifacts.
+1 javadoc 27 trunk passed
0 spotbugs 67 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 65 trunk passed
_ Patch Compile Tests _
+1 mvninstall 37 the patch passed
+1 compile 29 the patch passed
+1 javac 29 the patch passed
+1 checkstyle 20 the patch passed
+1 mvnsite 33 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 812 patch has no errors when building and testing our client artifacts.
+1 javadoc 22 the patch passed
+1 findbugs 66 the patch passed
_ Other Tests _
+1 unit 283 hadoop-aws in the patch passed.
+1 asflicense 28 The patch does not generate ASF License warnings.
3738
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/3/artifact/out/Dockerfile
GITHUB PR #1209
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 18ef35084534 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 3cc0ace
Default Java 1.8.0_212
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/3/testReport/
Max. process+thread count 342 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/3/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

This comment has been minimized.

Copy link

commented Aug 8, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 48 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 1257 trunk passed
+1 compile 31 trunk passed
+1 checkstyle 20 trunk passed
+1 mvnsite 36 trunk passed
+1 shadedclient 713 branch has no errors when building and testing our client artifacts.
+1 javadoc 23 trunk passed
0 spotbugs 62 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 58 trunk passed
_ Patch Compile Tests _
+1 mvninstall 34 the patch passed
+1 compile 26 the patch passed
+1 javac 26 the patch passed
+1 checkstyle 17 the patch passed
+1 mvnsite 32 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 761 patch has no errors when building and testing our client artifacts.
+1 javadoc 25 the patch passed
+1 findbugs 75 the patch passed
_ Other Tests _
+1 unit 271 hadoop-aws in the patch passed.
+1 asflicense 31 The patch does not generate ASF License warnings.
3539
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/4/artifact/out/Dockerfile
GITHUB PR #1209
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux a2a91f184f9a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 00b5a27
Default Java 1.8.0_212
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/4/testReport/
Max. process+thread count 414 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/4/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@steveloughran

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

Thought: we could be collecting stats on observed inconsistencies

Here'd we'd count #of times retried on open/rename

@bgaborg

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

+1; will commit now.

@bgaborg
bgaborg approved these changes Aug 9, 2019
@bgaborg bgaborg merged commit 189dc10 into apache:trunk Aug 9, 2019
@steveloughran

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

thx

@steveloughran steveloughran deleted the steveloughran:HADOOP-16481-test_300_prune_region branch Aug 20, 2019
arp7 pushed a commit to arp7/hadoop that referenced this pull request Sep 18, 2019
…eeds to set region. (apache#1209). Contributed by Steve Loughran.

(cherry picked from commit 189dc10)

Change-Id: I19478e4835b427bf6b3d11067819cf2e3f171314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.