Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-1964. TestOzoneClientProducer fails with ConnectException #1292

Closed
wants to merge 1 commit into from

Conversation

@adoroszlai
Copy link
Contributor

commented Aug 14, 2019

What changes were proposed in this pull request?

TestOzoneClientProducer verifies that RpcClient cannot be created because OM address is not configured. The call to producer.createClient() is expected to fail with the message Couldn't create protocol, which is triggered by IllegalArgumentException: Could not find any configured addresses for OM. Please configure the system with ozone.om.address. bf45779 added the default address as explicitly configured value, so client creation now progresses further and fails when it cannot connect to OM (which is not started by the unit test).

This change simply sets the previous empty OM address for this test.

It also adds log4j config for s3gateway tests to produce better output next time, because currently it is not very helpful.

https://issues.apache.org/jira/browse/HDDS-1964

How was this patch tested?

$ mvn -Phdds -pl :hadoop-ozone-s3gateway test
...
[INFO] Tests run: 77, Failures: 0, Errors: 0, Skipped: 0
...
[INFO] BUILD SUCCESS
@adoroszlai

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

/label ozone

@elek elek added the ozone label Aug 14, 2019

@hadoop-yetus

This comment has been minimized.

Copy link

commented Aug 14, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 50 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
-1 mvninstall 135 hadoop-ozone in trunk failed.
-1 compile 48 hadoop-ozone in trunk failed.
+1 checkstyle 59 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 837 branch has no errors when building and testing our client artifacts.
+1 javadoc 145 trunk passed
0 spotbugs 192 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 99 hadoop-ozone in trunk failed.
_ Patch Compile Tests _
-1 mvninstall 136 hadoop-ozone in the patch failed.
-1 compile 50 hadoop-ozone in the patch failed.
-1 javac 50 hadoop-ozone in the patch failed.
+1 checkstyle 61 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 632 patch has no errors when building and testing our client artifacts.
+1 javadoc 152 the patch passed
-1 findbugs 100 hadoop-ozone in the patch failed.
_ Other Tests _
+1 unit 295 hadoop-hdds in the patch passed.
-1 unit 104 hadoop-ozone in the patch failed.
+1 asflicense 36 The patch does not generate ASF License warnings.
3856
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1292/1/artifact/out/Dockerfile
GITHUB PR #1292
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux ebf668536fa9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 0e4b757
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1292/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1292/1/artifact/out/branch-compile-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1292/1/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1292/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1292/1/artifact/out/patch-compile-hadoop-ozone.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1292/1/artifact/out/patch-compile-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1292/1/artifact/out/patch-findbugs-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1292/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1292/1/testReport/
Max. process+thread count 520 (vs. ulimit of 5500)
modules C: hadoop-ozone/s3gateway U: hadoop-ozone/s3gateway
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1292/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@adoroszlai adoroszlai force-pushed the adoroszlai:HDDS-1964 branch from 7724f0b to b017fdb Aug 14, 2019

@hadoop-yetus

This comment has been minimized.

Copy link

commented Aug 14, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 71 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 595 trunk passed
+1 compile 368 trunk passed
+1 checkstyle 71 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 935 branch has no errors when building and testing our client artifacts.
+1 javadoc 167 trunk passed
0 spotbugs 434 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 633 trunk passed
_ Patch Compile Tests _
+1 mvninstall 559 the patch passed
+1 compile 375 the patch passed
+1 javac 375 the patch passed
+1 checkstyle 78 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 716 patch has no errors when building and testing our client artifacts.
+1 javadoc 167 the patch passed
+1 findbugs 726 the patch passed
_ Other Tests _
+1 unit 367 hadoop-hdds in the patch passed.
-1 unit 2560 hadoop-ozone in the patch failed.
+1 asflicense 56 The patch does not generate ASF License warnings.
8616
Reason Tests
Failed junit tests hadoop.ozone.om.TestOzoneManagerHA
hadoop.ozone.client.rpc.TestWatchForCommit
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.hdds.scm.safemode.TestSCMSafeModeWithPipelineRules
hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1292/2/artifact/out/Dockerfile
GITHUB PR #1292
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 47d0c0356561 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 83e452e
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1292/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1292/2/testReport/
Max. process+thread count 4873 (vs. ulimit of 5500)
modules C: hadoop-ozone/s3gateway U: hadoop-ozone/s3gateway
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1292/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@adoroszlai

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

@smengcl @anuengineer please review

Here are the fixed unit tests:
https://ci.anzix.net/job/ozone/17670/testReport/org.apache.hadoop.ozone.s3/TestOzoneClientProducer/

Failed acceptance test is being fixed in #1295.

@adoroszlai

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

Thanks @anuengineer (8242085) and @nandakumar131 (b1e4eee) for committing this.

@adoroszlai adoroszlai closed this Aug 14, 2019

@adoroszlai adoroszlai deleted the adoroszlai:HDDS-1964 branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.