Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-2222. Add a method to update ByteBuffer in PureJavaCrc32/PureJavaCrc32C #1595

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@szetszwo
Copy link
Contributor

szetszwo commented Oct 4, 2019

@szetszwo szetszwo added the ozone label Oct 4, 2019
@szetszwo szetszwo force-pushed the szetszwo:HDDS-2222 branch from 0ccc404 to ca478c1 Oct 4, 2019
@hadoop-yetus

This comment has been minimized.

Copy link

hadoop-yetus commented Oct 4, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 76 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
-1 mvninstall 41 hadoop-hdds in trunk failed.
-1 mvninstall 39 hadoop-ozone in trunk failed.
-1 compile 18 hadoop-hdds in trunk failed.
-1 compile 13 hadoop-ozone in trunk failed.
+1 checkstyle 58 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 941 branch has no errors when building and testing our client artifacts.
-1 javadoc 18 hadoop-hdds in trunk failed.
-1 javadoc 17 hadoop-ozone in trunk failed.
0 spotbugs 1030 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 31 hadoop-hdds in trunk failed.
-1 findbugs 18 hadoop-ozone in trunk failed.
_ Patch Compile Tests _
-1 mvninstall 31 hadoop-hdds in the patch failed.
-1 mvninstall 34 hadoop-ozone in the patch failed.
-1 compile 21 hadoop-hdds in the patch failed.
-1 compile 15 hadoop-ozone in the patch failed.
-1 javac 21 hadoop-hdds in the patch failed.
-1 javac 15 hadoop-ozone in the patch failed.
-0 checkstyle 24 hadoop-hdds: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 2 The patch has no ill-formed XML file.
+1 shadedclient 796 patch has no errors when building and testing our client artifacts.
-1 javadoc 19 hadoop-hdds in the patch failed.
-1 javadoc 16 hadoop-ozone in the patch failed.
-1 findbugs 28 hadoop-hdds in the patch failed.
-1 findbugs 17 hadoop-ozone in the patch failed.
_ Other Tests _
-1 unit 25 hadoop-hdds in the patch failed.
-1 unit 21 hadoop-ozone in the patch failed.
+1 asflicense 29 The patch does not generate ASF License warnings.
2488
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/Dockerfile
GITHUB PR #1595
Optional Tests dupname asflicense xml compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux c27d0ebfbb42 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / bffcd33
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/branch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/branch-compile-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/branch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/patch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/patch-compile-hadoop-ozone.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/patch-compile-hadoop-hdds.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/patch-compile-hadoop-ozone.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/diff-checkstyle-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/patch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/patch-findbugs-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/testReport/
Max. process+thread count 306 (vs. ulimit of 5500)
modules C: hadoop-hdds/common U: hadoop-hdds/common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

This comment has been minimized.

Copy link

hadoop-yetus commented Oct 4, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 54 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
-1 mvninstall 37 hadoop-hdds in trunk failed.
-1 mvninstall 42 hadoop-ozone in trunk failed.
-1 compile 23 hadoop-hdds in trunk failed.
-1 compile 14 hadoop-ozone in trunk failed.
+1 checkstyle 62 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 960 branch has no errors when building and testing our client artifacts.
-1 javadoc 23 hadoop-hdds in trunk failed.
-1 javadoc 19 hadoop-ozone in trunk failed.
0 spotbugs 1062 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 34 hadoop-hdds in trunk failed.
-1 findbugs 21 hadoop-ozone in trunk failed.
_ Patch Compile Tests _
-1 mvninstall 35 hadoop-hdds in the patch failed.
-1 mvninstall 40 hadoop-ozone in the patch failed.
-1 compile 25 hadoop-hdds in the patch failed.
-1 compile 19 hadoop-ozone in the patch failed.
-1 javac 25 hadoop-hdds in the patch failed.
-1 javac 19 hadoop-ozone in the patch failed.
-0 checkstyle 30 hadoop-hdds: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 2 The patch has no ill-formed XML file.
+1 shadedclient 713 patch has no errors when building and testing our client artifacts.
-1 javadoc 23 hadoop-hdds in the patch failed.
-1 javadoc 20 hadoop-ozone in the patch failed.
-1 findbugs 32 hadoop-hdds in the patch failed.
-1 findbugs 21 hadoop-ozone in the patch failed.
_ Other Tests _
-1 unit 28 hadoop-hdds in the patch failed.
-1 unit 26 hadoop-ozone in the patch failed.
+1 asflicense 33 The patch does not generate ASF License warnings.
2503
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/Dockerfile
GITHUB PR #1595
Optional Tests dupname asflicense xml compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 4a3e8233f620 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / d061c84
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/branch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/branch-compile-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/branch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/patch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/patch-compile-hadoop-ozone.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/patch-compile-hadoop-hdds.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/patch-compile-hadoop-ozone.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/diff-checkstyle-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/patch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/patch-findbugs-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/testReport/
Max. process+thread count 412 (vs. ulimit of 5500)
modules C: hadoop-hdds/common U: hadoop-hdds/common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1595/2/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@szetszwo

This comment has been minimized.

Copy link
Contributor Author

szetszwo commented Oct 4, 2019

There were no findbugs warnings. Since there are no code changes except findbugsExcludeFile.xml compared to #1578 , will merge the commit soon.

@szetszwo szetszwo merged commit 531cc93 into apache:trunk Oct 4, 2019
5 of 8 checks passed
5 of 8 checks passed
ci/acceptance acceptance is finished with failure status
Details
ci/checkstyle checkstyle check is finished with 10 violations
Details
ci/integration integration check is in progress...
Details
ci/author author is finished with success status
Details
ci/build build is finished with success status
Details
ci/findbugs findbugs is finished with success status
Details
ci/rat rat is finished with success status
Details
ci/unit unit is finished with success status
Details
@elek

This comment has been minimized.

Copy link
Member

elek commented Oct 4, 2019

Checkstyle errors seem to be introduced:

https://github.com/elek/ozone-ci-q4/blob/master/pr/pr-hdds-2222-6c7sc/checkstyle/summary.txt
@szetszwo

This comment has been minimized.

Copy link
Contributor Author

szetszwo commented Oct 5, 2019

Sorry about that. I thought we may ignore the checkstyle warnings like we are doing in Hadoop.

Thanks @vivekratnavel for the quick fix in #1603 (https://issues.apache.org/jira/browse/HDDS-2257)!

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.