HDFS-16107.Split RPC configuration to isolate RPC. #3170
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianghuazhu
force-pushed
the
HDFS-16107
branch
2 times, most recently
from
7a0c5ff to
74d93dd
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
jojochuang
reviewed
Jul 16, 2021
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
Looks good. Can you update the configurations and descriptions in core-default.xml?
Contributor
Author
|
@jojochuang , thanks for your comment. |
jianghuazhu
force-pushed
the
HDFS-16107
branch
2 times, most recently
from
d053a81 to
6a709d5
Compare
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@jojochuang , I submitted some new code, can you review it. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@jojochuang , do you have any new suggestions? I am willing to make more contributions. |
jianghuazhu
force-pushed
the
HDFS-16107
branch
from
cad27bd to
8e4239b
Compare
|
🎊 +1 overall
This message was automatically generated. |
tomscut
reviewed
Sep 17, 2021
Contributor
tomscut
left a comment
tomscut
left a comment
There was a problem hiding this comment.
I have one request and left some comments.
tomscut
reviewed
Sep 17, 2021
Contributor
There was a problem hiding this comment.
Would it be better to use conf.getInt here?
Contributor
Author
There was a problem hiding this comment.
Thanks @tomscut for the comment.
This is my neglect, I will update it later.
Contributor
There was a problem hiding this comment.
We can also use conf.getInt here and as well as in the next few places?
jianghuazhu
force-pushed
the
HDFS-16107
branch
from
8e4239b to
c7f6f3a
Compare
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@tomscut @virajjasani, I have submitted some changes, can you review it? |
tomscut
reviewed
Sep 18, 2021
| CommonConfigurationKeys.IPC_SERVER_RPC_READ_THREADS_KEY, | ||
| CommonConfigurationKeys.IPC_SERVER_RPC_READ_THREADS_DEFAULT); | ||
| this.readThreads = conf.getInt(getQueueClassPrefix() + "." + | ||
| CommonConfigurationKeys.SERVER_RPC_READ_THREADS_KEY, 0); |
Contributor
There was a problem hiding this comment.
Hi @jianghuazhu , if we share default value with IPC_SERVER_RPC_READ_THREADS_KEY, maybe we could change
this.readThreads = conf.getInt(getQueueClassPrefix() + "." +
CommonConfigurationKeys.SERVER_RPC_READ_THREADS_KEY, 0);
if (this.readThreads < 1) {
this.readThreads = conf.getInt(
CommonConfigurationKeys.IPC_SERVER_RPC_READ_THREADS_KEY,
CommonConfigurationKeys.IPC_SERVER_RPC_READ_THREADS_DEFAULT);
}
to
this.readThreads = conf.getInt(prefix + "." + CommonConfigurationKeys.SERVER_RPC_READ_THREADS_KEY, CommonConfigurationKeys.IPC_SERVER_RPC_READ_THREADS_DEFAULT);.
What do you think?
Contributor
Author
There was a problem hiding this comment.
Thanks @tomscut for the comment.
If there is an RPC service whose port is 8020, we hope that the number of read thread pools allocated for this RPC (ipc.8020.server.read.threadpool.size) is different from other RPCs.
The logic here is:
- First judge whether ipc.8020.server.read.threadpool.size has been allocated. If it is not allocated, the value we get should be 0, indicating that we want to use the public unified configuration (ipc.server.read.threadpool .size).
- If it is not allocated, we should use the public unified configuration ipc.server.read.threadpool.size.
At present, CommonConfigurationKeys.IPC_SERVER_RPC_READ_THREADS_DEFAULT is set to 1. If we use this attribute, we can still get a valid value when ipc.8020.server.read.threadpool.size is not set, which may cause a Ambiguity.
This is my idea, welcome to continue to communicate. @tomscut
Contributor
There was a problem hiding this comment.
Thanks @jianghuazhu for your comments.
@jojochuang @virajjasani Could you please review this PR. Thanks.
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
Hi @jianghuazhu excuse me any progress on this jira? |
Contributor
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute