Skip to content

HDFS-16118.Improve the number of handlers that initialize NameNodeRpcServer#clientRpcServer. #3186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

HDFS-16118.Improve the number of handlers that initialize NameNodeRpcServer#clientRpcServer. #3186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3588,6 +3588,11 @@ public int getNumReaders() {
return readThreads;
}

@VisibleForTesting
public int getHandlerCount() {
return handlerCount;
}

/**
* When the read or write buffer size is larger than this limit, i/o will be
* done in chunks of this size. Most RPC requests and responses would be
Expand Down
1 change: 1 addition & 0 deletions ...t/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,7 @@ public NameNodeRpcServer(Configuration conf, NameNode nn)
DFS_NAMENODE_LIFELINE_HANDLER_RATIO_DEFAULT);
lifelineHandlerCount = Math.max(
(int)(handlerCount * lifelineHandlerRatio), 1);
handlerCount = handlerCount - lifelineHandlerCount;
}
lifelineRpcServer = new RPC.Builder(conf)
.setProtocol(HAServiceProtocolPB.class)
Expand Down
26 changes: 26 additions & 0 deletions ...doop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeRpcServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@

import java.io.IOException;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hdfs.DFSConfigKeys;
import org.apache.hadoop.hdfs.HdfsConfiguration;
import org.apache.hadoop.hdfs.MiniDFSCluster;

Expand Down Expand Up @@ -59,5 +60,30 @@ public void testNamenodeRpcBindAny() throws IOException {
conf.unset(DFS_NAMENODE_RPC_BIND_HOST_KEY);
}
}

@Test
public void testLifelineHandlerCount() throws IOException {
Configuration conf = new HdfsConfiguration();
conf.set(DFSConfigKeys.DFS_NAMENODE_LIFELINE_RPC_ADDRESS_KEY, "0.0.0.0:0");
conf.setInt(DFSConfigKeys.DFS_NAMENODE_HANDLER_COUNT_KEY, 20);
conf.setInt(DFSConfigKeys.DFS_NAMENODE_LIFELINE_HANDLER_COUNT_KEY, -1);

MiniDFSCluster cluster = null;
try {
cluster = new MiniDFSCluster.Builder(conf).build();
cluster.waitActive();
int lifeHandlerCount = ((NameNodeRpcServer)cluster.getNameNodeRpc())
.getLifelineRpcServer().getHandlerCount();
assertEquals(2, lifeHandlerCount);

int clientHandlerCount = ((NameNodeRpcServer)cluster.getNameNodeRpc())
.getClientRpcServer().getHandlerCount();
assertEquals(18, clientHandlerCount);
} finally {
if (cluster != null) {
cluster.shutdown();
}
}
}
}