-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16192: ViewDistributedFileSystem#rename wrongly using src in the place of dst. #3353
Conversation
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Uma. Fix looks good to me.
One question about the test though
...-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestViewDistributedFileSystem.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
🎊 +1 overall
This message was automatically generated. |
Thanks a lot @jojochuang for the reviews!!! |
… place of dst. (apache#3353) Co-authored-by: Uma Maheswara Rao G <umagangumalla@cloudera.com>
… place of dst. (apache#3353) Co-authored-by: Uma Maheswara Rao G <umagangumalla@cloudera.com> (cherry picked from commit 164608b) Change-Id: I33b3731b7199e757d6de5d7334166bbdb5c8a205 (cherry picked from commit 16f2aa8) (cherry picked from commit 7159f574e19f8ac6a82875725d06636c17800ae3)
https://issues.apache.org/jira/browse/HDFS-16192
Description of PR
ViewDistributedFileSystem#rename with options API using src args wrongly in the place of dst. Corrected the same and also provided to access rename with options API via Util, so that we don't need to cast to distributed file system class. The reason is, if any other file system provides the implementation to that API, we will be able to use it.
How was this patch tested?
Added a test to verify the behavior.
For code changes:
same as explained in description.