HDFS-16193. Append & Rename APIs to support FGL.

[prasad-acit]

HDFS-16193. Append & Rename APIs to support FGL.
Switch the global lock with FGL for Append & Rename API.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	17m 48s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ fgl Compile Tests _
-1 ❌	mvninstall	33m 28s	/branch-mvninstall-root.txt	root in fgl failed.
+1 💚	compile	1m 23s		fgl passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	1m 13s		fgl passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	1m 0s		fgl passed
+1 💚	mvnsite	1m 22s		fgl passed
+1 💚	javadoc	0m 58s		fgl passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 26s		fgl passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	3m 20s		fgl passed
+1 💚	shadedclient	18m 55s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 15s		the patch passed
+1 💚	compile	1m 18s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
-1 ❌	javac	1m 18s	/results-compile-javac-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt	hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 generated 1 new + 469 unchanged - 1 fixed = 470 total (was 470)
+1 💚	compile	1m 8s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
-1 ❌	javac	1m 8s	/results-compile-javac-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt	hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu120.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu120.04-b10 generated 1 new + 453 unchanged - 1 fixed = 454 total (was 454)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 55s	/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs-project/hadoop-hdfs: The patch generated 7 new + 11 unchanged - 0 fixed = 18 total (was 11)
+1 💚	mvnsite	1m 15s		the patch passed
+1 💚	javadoc	0m 48s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 18s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
-1 ❌	spotbugs	3m 26s	/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs.html	hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	shadedclient	19m 6s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	370m 45s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 38s		The patch does not generate ASF License warnings.
		479m 58s

Reason	Tests
SpotBugs	module:hadoop-hdfs-project/hadoop-hdfs
	Dead store to error in org.apache.hadoop.hdfs.server.namenode.FSDirRenameOp.switchToFGL(FSDirectory, INodesInPath, INodesInPath) At FSDirRenameOp.java:org.apache.hadoop.hdfs.server.namenode.FSDirRenameOp.switchToFGL(FSDirectory, INodesInPath, INodesInPath) At FSDirRenameOp.java:[line 340]
Failed junit tests	hadoop.hdfs.server.namenode.TestCommitBlockSynchronization
	hadoop.hdfs.server.namenode.TestDecommissioningStatus
	hadoop.hdfs.server.namenode.snapshot.TestRandomOpsWithSnapshots
	hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport
	hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
	hadoop.hdfs.server.namenode.TestDeleteRace
	hadoop.hdfs.server.namenode.snapshot.TestSnapRootDescendantDiff
	hadoop.hdfs.TestDistributedFileSystem
	hadoop.hdfs.server.namenode.TestFSNamesystemLockReport
	hadoop.hdfs.server.namenode.TestFSNamesystemLock
	hadoop.hdfs.TestRollingUpgradeDowngrade
	hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
	hadoop.hdfs.server.namenode.snapshot.TestSnapshot
	hadoop.hdfs.server.namenode.TestAuditLogs
	hadoop.hdfs.TestViewDistributedFileSystem
	hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor
	hadoop.hdfs.TestErasureCodingPolicyWithSnapshot
	hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots
	hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot
	hadoop.hdfs.server.namenode.TestNameEditsConfigs
	hadoop.hdfs.server.namenode.TestNameNodeRecovery
	hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap
	hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
	hadoop.hdfs.TestErasureCodingPolicyWithSnapshotWithRandomECPolicy
	hadoop.hdfs.server.namenode.TestPersistentStoragePolicySatisfier
	hadoop.hdfs.server.namenode.TestStorageRestore
	hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
	hadoop.hdfs.server.namenode.TestFSNamesystem
	hadoop.hdfs.server.namenode.TestCacheDirectivesWithViewDFS
	hadoop.hdfs.server.namenode.ha.TestObserverNode
	hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
	hadoop.hdfs.TestHDFSFileSystemContract
	hadoop.hdfs.server.namenode.TestFSImage
	hadoop.hdfs.server.namenode.TestStartup
	hadoop.hdfs.server.namenode.snapshot.TestFSImageWithOrderedSnapshotDeletion
	hadoop.hdfs.server.namenode.snapshot.TestXAttrWithSnapshot
	hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
	hadoop.hdfs.TestRollingUpgradeRollback
	hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
	hadoop.hdfs.server.namenode.TestSecondaryNameNodeUpgrade
	hadoop.hdfs.server.namenode.TestCacheDirectives
	hadoop.hdfs.TestDFSUpgradeFromImage
	hadoop.hdfs.TestRollingUpgrade
	hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion
	hadoop.hdfs.server.datanode.TestBatchIbr
	hadoop.hdfs.server.namenode.snapshot.TestOrderedSnapshotDeletion

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3373/1/artifact/out/Dockerfile
GITHUB PR	#3373
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 4ae0d11f26b0 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	fgl / ef8b28dd4399daa4449aaf72b13e1772460a1b8a
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3373/1/testReport/
Max. process+thread count	2103 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3373/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	20m 29s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ fgl Compile Tests _
-1 ❌	mvninstall	34m 20s	/branch-mvninstall-root.txt	root in fgl failed.
+1 💚	compile	1m 27s		fgl passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 17s		fgl passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 1s		fgl passed
+1 💚	mvnsite	1m 28s		fgl passed
+1 💚	javadoc	1m 1s		fgl passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 25s		fgl passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 22s		fgl passed
+1 💚	shadedclient	19m 59s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 21s		the patch passed
+1 💚	compile	1m 26s		the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	javac	1m 26s		the patch passed
+1 💚	compile	1m 22s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	1m 22s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 56s		the patch passed
+1 💚	mvnsite	1m 37s		the patch passed
+1 💚	javadoc	1m 8s		the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 40s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 53s		the patch passed
+1 💚	shadedclient	20m 22s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	568m 15s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	2m 13s		The patch does not generate ASF License warnings.
		687m 22s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots
	hadoop.hdfs.server.namenode.TestStorageRestore
	hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
	hadoop.hdfs.TestDFSUpgradeFromImage
	hadoop.hdfs.server.namenode.TestSecondaryNameNodeUpgrade
	hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeHdfsFileSystemContract
	hadoop.hdfs.TestRollingUpgrade
	hadoop.hdfs.TestRollingUpgradeDowngrade
	hadoop.hdfs.server.namenode.snapshot.TestFSImageWithOrderedSnapshotDeletion
	hadoop.hdfs.server.namenode.TestFSNamesystem
	hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot
	hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
	hadoop.hdfs.server.namenode.snapshot.TestSnapRootDescendantDiff
	hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
	hadoop.hdfs.server.namenode.TestCommitBlockSynchronization
	hadoop.hdfs.TestDistributedFileSystem
	hadoop.hdfs.server.namenode.ha.TestEditLogTailer
	hadoop.hdfs.server.namenode.TestStartup
	hadoop.hdfs.TestFileChecksum
	hadoop.hdfs.server.namenode.TestNameEditsConfigs
	hadoop.hdfs.server.namenode.snapshot.TestXAttrWithSnapshot
	hadoop.hdfs.TestRollingUpgradeRollback
	hadoop.hdfs.server.datanode.TestBlockScanner
	hadoop.hdfs.server.namenode.TestFSNamesystemLock
	hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor
	hadoop.hdfs.server.namenode.TestFSNamesystemLockReport
	hadoop.hdfs.TestSnapshotCommands
	hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
	hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
	hadoop.fs.viewfs.TestViewFsAtHdfsRoot
	hadoop.hdfs.TestErasureCodingPolicyWithSnapshot
	hadoop.hdfs.client.impl.TestBlockReaderLocal
	hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
	hadoop.hdfs.TestViewDistributedFileSystem
	hadoop.hdfs.TestErasureCodingPolicyWithSnapshotWithRandomECPolicy
	hadoop.hdfs.server.namenode.TestDecommissioningStatus
	hadoop.hdfs.TestHDFSFileSystemContract
	hadoop.hdfs.server.namenode.snapshot.TestOrderedSnapshotDeletion
	hadoop.hdfs.server.namenode.TestCacheDirectives
	hadoop.hdfs.server.namenode.TestPersistentStoragePolicySatisfier
	hadoop.hdfs.server.namenode.snapshot.TestSnapshot
	hadoop.hdfs.server.datanode.TestBatchIbr
	hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap
	hadoop.hdfs.server.namenode.TestDeleteRace
	hadoop.hdfs.TestViewDistributedFileSystemContract
	hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
	hadoop.hdfs.server.namenode.TestFileTruncate
	hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport
	hadoop.hdfs.server.namenode.TestCacheDirectivesWithViewDFS
	hadoop.hdfs.web.TestWebHdfsFileSystemContract

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3373/1/artifact/out/Dockerfile
GITHUB PR	#3373
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 3c53b1b34574 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	fgl / 6cde0f1
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3373/1/testReport/
Max. process+thread count	2481 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3373/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

[prasad-acit]

@shvachko @xinglin Can you please take a look into this PR when you find time?

[github-actions]

We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
Thanks all for your contribution.