New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16269. [Fix] Improve NNThroughputBenchmark#blockReport operation. #3544
Conversation
🎊 +1 overall
This message was automatically generated. |
@ayushtkn @virajjasani, are you willing to spend some time reviewing this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thank you @jojochuang for your comments and reviews. |
Hi @aajisaka @ferhui @Hexiaoqiao , are you willing to spend some time to help review this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: will it guarantee each block is added to one TinyDataNode? It seems so when i ran the test but not sure how NN generates xferport.
Thanks @jojochuang for the comment. |
e66171d
to
288b4c5
Compare
🎊 +1 overall
This message was automatically generated. |
Some changes have been made here.
Below are some verified examples. Step 3: @jojochuang, would you like to take some time to help review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix mostly looks good to me.
...oop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNNThroughputBenchmark.java
Outdated
Show resolved
Hide resolved
288b4c5
to
75c4e6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. thanks for catching the bug.
🎊 +1 overall
This message was automatically generated. |
Thanks for your comments and reviews, @aajisaka @jojochuang . |
@virajjasani @ferhui, are you willing to spend some time to help review this pr. |
75c4e6d
to
6979d3b
Compare
🎊 +1 overall
This message was automatically generated. |
6979d3b
to
d889386
Compare
🎊 +1 overall
This message was automatically generated. |
I have made some changes, can you review this pr again, @aajisaka . |
...oop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNNThroughputBenchmark.java
Outdated
Show resolved
Hide resolved
d889386
to
bfedca8
Compare
💔 -1 overall
This message was automatically generated. |
Merged. Thank you @jianghuazhu @ferhui @jojochuang |
#3544) Reviewed-by: Fei Hui <feihui.ustc@gmail.com> Reviewed-by: Wei-Chiu Chuang <weichiu@apache.org> Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit 618fea2) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNNThroughputBenchmark.java
apache#3544) Reviewed-by: Fei Hui <feihui.ustc@gmail.com> Reviewed-by: Wei-Chiu Chuang <weichiu@apache.org> Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
Description of PR
When using NNThroughputBenchmark to test blockReport, some exceptions will be prompted.
E.g:
The purpose of this issue is to solve this problem.
How was this patch tested?
When using the same command, the same exception will not occur.