Skip to content

HDFS-16284: Unboxing long value in old version's block report cause full GC #3586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

HDFS-16284: Unboxing long value in old version's block report cause full GC #3586

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc09dbc
Unboxing long value in old version's block report cause full GC
Oct 26, 2021
c1c7625
Fix check style issue
Dec 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions ...s-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/BlockListAsLongs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,14 +437,17 @@ public void remove() {

// decode old style block report of longs
private static class LongsDecoder extends BlockListAsLongs {
private final List<Long> values;
private final long[] values;
private final int finalizedBlocks;
private final int numBlocks;
private final int maxDataLength;

// set the header
LongsDecoder(List<Long> values, int maxDataLength) {
this.values = values.subList(2, values.size());
this.values = new long[values.size() - 2];
for (int i = 2; i < values.size(); i++) {
this.values[i - 2] = values.get(i);
}
this.finalizedBlocks = values.get(0).intValue();
this.numBlocks = finalizedBlocks + values.get(1).intValue();
this.maxDataLength = maxDataLength;
Expand All @@ -466,11 +469,11 @@ public ByteString getBlocksBuffer() {

@Override
public long[] getBlockListAsLongs() {
long[] longs = new long[2+values.size()];
long[] longs = new long[2 + values.length];
longs[0] = finalizedBlocks;
longs[1] = numBlocks - finalizedBlocks;
for(int i=0; i<values.size(); i++) {
longs[2+i] = values.get(i);
for (int i = 0; i < values.length; i++) {
longs[2 + i] = values[i];
}
return longs;
}
Expand All @@ -479,7 +482,7 @@ public long[] getBlockListAsLongs() {
public Iterator<BlockReportReplica> iterator() {
return new Iterator<BlockReportReplica>() {
private final BlockReportReplica block = new BlockReportReplica();
final Iterator<Long> iter = values.iterator();
private int idx = 0;
private int currentBlockIndex = 0;

@Override
Expand All @@ -502,15 +505,15 @@ public BlockReportReplica next() {
if (currentBlockIndex++ < finalizedBlocks) {
block.setState(ReplicaState.FINALIZED);
} else {
block.setState(ReplicaState.getState(iter.next().intValue()));
block.setState(ReplicaState.getState((int) values[idx++]));
}
return block;
}

private void readBlock() {
block.setBlockId(iter.next());
block.setNumBytes(iter.next());
block.setGenerationStamp(iter.next());
block.setBlockId(values[idx++]);
block.setNumBytes(values[idx++]);
block.setGenerationStamp(values[idx++]);
}

@Override
Expand Down