Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDFS-16344. Improve DirectoryScanner.Stats#toString #3695

Merged
merged 1 commit into from
Nov 29, 2021
Merged

HDFS-16344. Improve DirectoryScanner.Stats#toString #3695

merged 1 commit into from
Nov 29, 2021

Conversation

tomscut
Copy link
Contributor

@tomscut tomscut commented Nov 21, 2021

JIRA: HDFS-16344.

Improve DirectoryScanner.Stats#toString.

scan

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 34m 50s trunk passed
+1 💚 compile 1m 26s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 1m 17s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 0m 59s trunk passed
+1 💚 mvnsite 1m 25s trunk passed
+1 💚 javadoc 1m 1s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 26s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 3m 25s trunk passed
+1 💚 shadedclient 25m 20s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 19s the patch passed
+1 💚 compile 1m 23s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 1m 23s the patch passed
+1 💚 compile 1m 11s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 1m 11s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 53s the patch passed
+1 💚 mvnsite 1m 18s the patch passed
+1 💚 javadoc 0m 52s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 24s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 3m 25s the patch passed
+1 💚 shadedclient 25m 28s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 314m 37s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 42s The patch does not generate ASF License warnings.
421m 44s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3695/1/artifact/out/Dockerfile
GITHUB PR #3695
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux f6517f89ba74 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 7dbde50
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3695/1/testReport/
Max. process+thread count 2431 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3695/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani approved these changes Nov 21, 2021
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (non-binding)

@tomscut
Copy link
Contributor Author

tomscut commented Nov 22, 2021

+1 (non-binding)

Thanks @virajjasani for your review.

@tomscut
Copy link
Contributor Author

tomscut commented Nov 24, 2021

Hi @tasanuma @ayushtkn , PTAL. Thanks.

@tomscut
Copy link
Contributor Author

tomscut commented Nov 25, 2021

Hi @ferhui , please also take a look. Thanks a lot.

@tomscut
Copy link
Contributor Author

tomscut commented Nov 25, 2021

Hi @ferhui , please also take a look. Thanks a lot.

Thanks @ferhui for your review.

@tomscut
Copy link
Contributor Author

tomscut commented Nov 29, 2021

@tasanuma PTAL. Thanks.

@tasanuma tasanuma merged commit 829af89 into apache:trunk Nov 29, 2021
@tasanuma
Copy link
Member

Thanks for your contribution, @tomscut. Thanks for your reviews, @virajjasani, @ayushtkn, @ferhui.

tasanuma pushed a commit that referenced this pull request Nov 29, 2021
@tomscut @tasanuma
HDFS-16344. Improve DirectoryScanner.Stats#toString (#3695)
f5e15df 
Reviewed-by: Viraj Jasani <vjasani@apache.org>
Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
Reviewed-by: Hui Fei <ferhui@apache.org>
(cherry picked from commit 829af89)
sunchao pushed a commit that referenced this pull request Jan 4, 2022
@tomscut @sunchao
HDFS-16344. Improve DirectoryScanner.Stats#toString (#3695)
ce0bc7b 
Reviewed-by: Viraj Jasani <vjasani@apache.org>
Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
Reviewed-by: Hui Fei <ferhui@apache.org>
(cherry picked from commit 829af89)
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
@tomscut
HDFS-16344. Improve DirectoryScanner.Stats#toString (apache#3695)
2fe1142 
Reviewed-by: Viraj Jasani <vjasani@apache.org>
Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
Reviewed-by: Hui Fei <ferhui@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferhui ferhui ferhui approved these changes

@tasanuma tasanuma tasanuma approved these changes

@ayushtkn ayushtkn ayushtkn approved these changes

@virajjasani virajjasani virajjasani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tomscut @hadoop-yetus @tasanuma @ferhui @ayushtkn @virajjasani