Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDFS-16579. Fix build failure for TestBlockManager on branch-3.2 #4310

Merged
merged 1 commit into from May 15, 2022

Conversation

tomscut
Copy link
Contributor

@tomscut tomscut commented May 14, 2022

JIRA: HDFS-16579.

Fix build failure for TestBlockManager on branch-3.2. See HDFS-16552.

Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your quick fix.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 12m 16s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.2 Compile Tests _
-1 ❌ mvninstall 14m 28s /branch-mvninstall-root.txt root in branch-3.2 failed.
-1 ❌ compile 1m 4s /branch-compile-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in branch-3.2 failed.
+1 💚 checkstyle 0m 57s branch-3.2 passed
-1 ❌ mvnsite 1m 7s /branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in branch-3.2 failed.
+1 💚 javadoc 1m 8s branch-3.2 passed
-1 ❌ spotbugs 1m 7s /branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in branch-3.2 failed.
-1 ❌ shadedclient 8m 13s branch has errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 12s the patch passed
+1 💚 compile 1m 4s the patch passed
-1 ❌ javac 1m 4s /results-compile-javac-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs-project_hadoop-hdfs generated 1 new + 577 unchanged - 3 fixed = 578 total (was 580)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 45s the patch passed
+1 💚 mvnsite 1m 10s the patch passed
+1 💚 javadoc 0m 53s the patch passed
+1 💚 spotbugs 3m 33s the patch passed
+1 💚 shadedclient 19m 46s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 213m 47s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 58s The patch does not generate ASF License warnings.
279m 14s
Reason Tests
Failed junit tests hadoop.hdfs.TestDatanodeRegistration
hadoop.hdfs.TestRollingUpgrade
hadoop.hdfs.server.datanode.TestBPOfferService
hadoop.hdfs.TestReconstructStripedFileWithValidator
hadoop.hdfs.server.datanode.TestDirectoryScanner
hadoop.hdfs.server.namenode.TestCacheDirectives
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4310/1/artifact/out/Dockerfile
GITHUB PR #4310
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 79f1529df906 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.2 / 8f0e643
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4310/1/testReport/
Max. process+thread count 2060 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4310/1/console
versions git=2.17.1 maven=3.6.0
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@tomscut
Copy link
Contributor Author

tomscut commented May 14, 2022

The failed unit tests seem unrelated to the change.

Copy link
Member

@tasanuma tasanuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it's my bad. The fix looks good to me.

@tasanuma tasanuma merged commit 48ca153 into apache:branch-3.2 May 15, 2022
@tasanuma
Copy link
Member

Thanks for fixing it quickly, @tomscut. Thanks for reporting the issue and your review, @aajisaka.

@tomscut
Copy link
Contributor Author

tomscut commented May 15, 2022

Thanks @tasanuma for merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants