-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16604. Install gtest via FetchContent_Declare in CMake #4374
Conversation
This reverts commit 49d6677.
This comment was marked as outdated.
This comment was marked as outdated.
💔 -1 overall
This message was automatically generated. |
Just to explain the failures in the CI run above - #4374 (comment),
In conclusion, once we merge this PR to trunk, the above failures won't show up for those PRs which are newly created, or those which gets rebased on top of trunk. |
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists.txt
Show resolved
Hide resolved
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists.txt
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
💔 -1 overall
This message was automatically generated. |
Merged. Thank you @GauthamBanasandra @goiri |
Description of PR
CMake is unable to checkout
release-1.10.0
version of GoogleTest -Jenkins run - https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4370/6/artifact/out/branch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client.txt
We need to use
FetchContent_Declare
since we're getting the source code exactly at the given commit SHA. This avoids the checkout step altogether and solves the above issue.How was this patch tested?
Hadoop Jenkins CI run.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?