HDFS-17072. DFSAdmin: add a triggerDirectoryScanner command. #5825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
changed the title
hfutatzhanghb
force-pushed
the
HDFS-17072
branch
from
886af14 to
5577c8d
Compare
Contributor
Author
|
@ayushtkn @Hexiaoqiao @tomscut @zhangshuyan0 Sir, could you please help me review this PR when you have free time? Thanks a lot. |
|
💔 -1 overall
This message was automatically generated. |
hfutatzhanghb
force-pushed
the
HDFS-17072
branch
from
5577c8d to
77dad80
Compare
|
💔 -1 overall
This message was automatically generated. |
tomscut
reviewed
Jul 24, 2023
| } | ||
|
|
||
| /** | ||
| * result - execution reulst. |
tomscut
reviewed
Jul 24, 2023
| */ | ||
| public String triggerDirectoryScanner() throws IOException { | ||
| if (reconcileRunning.get()) { | ||
| return "Trigger DirectoryScanner failed, beacause it's running. Please try again later."; |
Contributor
Author
There was a problem hiding this comment.
have fixed. Thanks a lot ~
tomscut
reviewed
Jul 24, 2023
| "Try again later.", e); | ||
| reconcileRunning.set(false); | ||
| throw e; | ||
| } |
Contributor
There was a problem hiding this comment.
It's safer to capture the Throwable.
try {
reconcile();
} catch (Exception e) {
...
} catch (Throwable e) {
reconcileRunning.set(false);
}
Contributor
Author
There was a problem hiding this comment.
Nice suggestions. Have fixed it. Thanks~
|
💔 -1 overall
This message was automatically generated. |
hfutatzhanghb
force-pushed
the
HDFS-17072
branch
from
24a42c6 to
327e937
Compare
|
💔 -1 overall
This message was automatically generated. |
hfutatzhanghb
force-pushed
the
HDFS-17072
branch
from
327e937 to
373d9ea
Compare
|
💔 -1 overall
This message was automatically generated. |
hfutatzhanghb
force-pushed
the
HDFS-17072
branch
from
373d9ea to
b193a44
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
The failed unit tests were all passed in my local. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@ayushtkn @Hexiaoqiao @zhangshuyan0 Sir, could you please help me review this PR when you have free time? Thanks a lot~ |
Member
|
There is a test failure for directory scanner itself, can you check? |
zhangshuyan0
requested changes
Oct 6, 2023
| "This cycle terminating immediately because 'shouldRun' has been deactivated"); | ||
| return; | ||
| } | ||
| if (reconcileRunning.get()) { |
Contributor
There was a problem hiding this comment.
Using the reconcileRunning variable in this way cannot prevent two threads from executing reconcile() at the same time. When this thread is running after line410 and before line416, another thread may set reconcileRunning to true.
| * @return | ||
| */ | ||
| public String triggerDirectoryScanner() throws IOException { | ||
| if (reconcileRunning.get()) { |
Contributor
There was a problem hiding this comment.
Just as mentioned above.
Contributor
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Please see HDFS-17072.
How was this patch tested?
Add unit tests.