HADOOP-16193. add extra S3A MPU test to see what happens if a file is created during the MPU #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… created during the MPU Change-Id: I15942ff8c7a772e1bf718bccbe4a249d20fa3ef2
|
Tested: S3 ireland. Remember to use -Dscale when running this test suite, even though this case isn't a slow one |
|
🎊 +1 overall
This message was automatically generated. |
steveloughran
added
the
fs/s3
bgaborg
reviewed
Apr 4, 2019
...p-aws/src/test/java/org/apache/hadoop/fs/contract/s3a/ITestS3AContractMultipartUploader.java
Show resolved
Hide resolved
steveloughran
added
failed
|
Aaron has reported a failure, marking as failed |
ehiggs
reviewed
Apr 6, 2019
| LOG.info("0-byte file has been created: {}", touchStatus); | ||
| fs.delete(path, false); | ||
| // now complete the upload | ||
| mpu.complete(path, handles, upload1); |
There was a problem hiding this comment.
Is there anything we can assert about the PathHandle returned here?
There was a problem hiding this comment.
that it's not empty?
There was a problem hiding this comment.
That you can use it to open the file again and read it?
There was a problem hiding this comment.
You may be able to use a PathHandle but these aren't, are they? They're PathHandles: Serializable representations of an uploaded file part.
There was a problem hiding this comment.
No, I mean mpu.complete returns a PathHandle. The part handles are PartHandles. Indeed PartHandles aren't useful out of the context of putPart (intentionally). But PathHandle is indeed useful and can be used to open the file to make sure it's the same file.
We use the path later to get the mpuStatus, so maybe this is just moot.
There was a problem hiding this comment.
I don't think I fully understand pathhandles. I thought that was an HDFS thing only right, or is there something obvious I haven't noticed?
Pauses, looks at code. I see: S3A MPU returns the etag, which isn't enough to refer to it when reopening.
We've been doing work on S3 & versioning now: one thing I'd like to get back from the upload is a reference which can be guaranteed to open that specific file, or failfast if it has changed; something like (path, etag, version). Returning these immediately from the upload in an S3AFileStatus would be one approach, but a pathhandle for S3A which contained all of those would be exactly what someone needs, isn't it?
Do you fancy getting busy on that?
There was a problem hiding this comment.
one thing I'd like to get back from the upload is a reference which can be guaranteed to open that specific file
That does sound better. We should make a ticket as soon as apache jira is back online.
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
LGTM! |
|
Merged. |
|
ok, if this doesn't work as is -what should our next step be? |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…sNotFound on deserial Exception type was serialized as a Class. However in case of Exceptions defined in non-samza-related or user-defined libs, the ExceptionEvent fails to be serialized. Author: rmatharu@linkedin.com <rmatharu@linkedin.com> Reviewers: Jagadish<jagadish@apache.org> Closes apache#609 from rmatharu/stringclasstype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HADOOP-16193. add extra S3A MPU test to see what happens if a file is created during the MPU
Change-Id: I15942ff8c7a772e1bf718bccbe4a249d20fa3ef2