Skip to content

HADOOP-19500. Skip tests that require JavaScript engine when it's not available #7503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 17, 2025
Merged

HADOOP-19500. Skip tests that require JavaScript engine when it's not available #7503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
815fc30
HADOOP-19500. Skip tests that require JavaScript engine when it's not…
stoty Mar 13, 2025
709e50a
use Junit 5 API in TestMetricsInvariantChecker
stoty Mar 14, 2025
ec336f4
refactor checks
stoty Mar 14, 2025
6adae46
whitespace fix
stoty Mar 14, 2025
7dae910
add missing import
stoty Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/BaseSLSRunnerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@
import org.apache.hadoop.yarn.server.resourcemanager.monitor.invariants.MetricsInvariantChecker;
import org.junit.After;
import org.junit.Assert;
import org.junit.Assume;
import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.junit.runners.Parameterized.Parameter;
Expand All @@ -35,6 +37,8 @@
import java.util.List;
import java.util.UUID;

import javax.script.ScriptEngineManager;

/**
* This is a base class to ease the implementation of SLS-based tests.
*/
Expand All @@ -59,6 +63,12 @@ public abstract class BaseSLSRunnerTest {
protected String ongoingInvariantFile;
protected String exitInvariantFile;

@BeforeClass
public static void checkForJavaScript() {
Assume.assumeNotNull("JavaScript engine not available (JEP 372)",
new ScriptEngineManager().getEngineByName("JavaScript"));
}

@Before
public abstract void setup();

Expand Down
10 changes: 10 additions & 0 deletions ...he/hadoop/yarn/server/resourcemanager/monitor/invariants/TestMetricsInvariantChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,15 @@
import org.apache.hadoop.yarn.server.resourcemanager.nodelabels.RMNodeLabelsManager;
import org.apache.hadoop.yarn.server.resourcemanager.scheduler.QueueMetrics;
import org.apache.log4j.Logger;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.Timeout;

import static org.junit.jupiter.api.Assertions.fail;
import static org.junit.jupiter.api.Assumptions.assumeFalse;

import javax.script.ScriptEngineManager;

/**
* This class tests the {@code MetricsInvariantChecker} by running it multiple
Expand All @@ -45,6 +49,12 @@ public class TestMetricsInvariantChecker {
private MetricsInvariantChecker ic;
private Configuration conf;

@BeforeAll
public static void checkForJavaScript() {
assumeFalse(new ScriptEngineManager().getEngineByName("JavaScript") == null,
"JavaScript engine not available (JEP 372)");
}

@BeforeEach
public void setup() {
this.metricsSystem = DefaultMetricsSystem.instance();
Expand Down