HDDS-1654. Ensure container state on datanode gets synced to disk whennever state change happens. #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…never state change happens.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
...a/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Hi @bshashikant
Thanks for the fix.
I have one comment. Rest LGTM.
|
+1 LGTM. |
|
This patch needs to be rebased I believe, previously there is a bug where acceptance test run used to hang. To get a Jenkins run, this needs to be rebased. |
|
/retest |
|
The unit test failures are not related and acceptance test results show it all passed in the details. I am going to commit this patch. |
|
Thanks @bharatviswa504 for the review. I have committed this change to trunk. |
asfgit
pushed a commit
that referenced
this pull request
Jul 18, 2019
…nnever state change happens. Cotributed by Shashikant Banerjee. (#923)
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Being a sync call, eventHubManagers can cause the container-start or the runLoop to block. Like so, "Samza StreamProcessor Container Thread-0" # 340 daemon prio=5 os_prio=0 tid=0x00007f5e38427800 nid=0x579e waiting on condition [0x00007f5e888cc000] java.lang.Thread.State: WAITING (parking) at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x00000005c1e04bf0> (a java.util.concurrent.CompletableFuture$Signaller) at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) at java.util.concurrent.CompletableFuture$Signaller.block(CompletableFuture.java:1693) at java.util.concurrent.ForkJoinPool.managedBlock(ForkJoinPool.java:3323) at java.util.concurrent.CompletableFuture.waitingGet(CompletableFuture.java:1729) at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1895) at com.microsoft.azure.eventhubs.EventHubClient.lambda$createReceiverSync$7(EventHubClient.java:336) at com.microsoft.azure.eventhubs.EventHubClient$$Lambda$371/65833266.execute(Unknown Source) at com.microsoft.azure.eventhubs.impl.ExceptionUtil.sync(ExceptionUtil.java:191) at com.microsoft.azure.eventhubs.EventHubClient.createReceiverSync(EventHubClient.java:336) at org.apache.samza.system.eventhub.consumer.EventHubSystemConsumer.initializeEventHubsManagers(EventHubSystemConsumer.java:320) - locked <0x00000005c1e04cd0> (a com.linkedin.samza.eventhub.consumer.LiEventHubSystemConsumer) at org.apache.samza.system.eventhub.consumer.EventHubSystemConsumer.start(EventHubSystemConsumer.java:355) at org.apache.samza.system.SystemConsumers$$anonfun$start$5.apply(SystemConsumers.scala:168) at org.apache.samza.system.SystemConsumers$$anonfun$start$5.apply(SystemConsumers.scala:168) at scala.collection.Iterator$class.foreach(Iterator.scala:727) at scala.collection.AbstractIterator.foreach(Iterator.scala:1157) at scala.collection.MapLike$DefaultValuesIterable.foreach(MapLike.scala:206) at org.apache.samza.system.SystemConsumers.start(SystemConsumers.scala:168) at org.apache.samza.container.SamzaContainer.startConsumers(SamzaContainer.scala:999) at org.apache.samza.container.SamzaContainer.run(SamzaContainer.scala:779) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) This PR introduces a bound on it. Author: Ray Matharu <rmatharu@linkedin.com> Reviewers: Jagadish <jagadish@apache.org> Closes apache#923 from rmatharu/test-bounded-event-hub-init
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
…nnever state change happens. Cotributed by Shashikant Banerjee. (apache#923)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.