Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-1692. RDBTable#iterator should disabled caching of the keys duri… #975

Merged
merged 1 commit into from Jun 17, 2019

Conversation

@bharatviswa504
Copy link
Contributor

bharatviswa504 commented Jun 16, 2019

…ng iterator.

…ng iterator.
@bharatviswa504 bharatviswa504 requested a review from mukul1987 Jun 16, 2019
@bharatviswa504

This comment has been minimized.

Copy link
Contributor Author

bharatviswa504 commented Jun 16, 2019

Thank You @mukul1987 for reporting this. I think this should help not to replace cache with bulk read contents when list operation has happened.

I see there are 2 more option verify checksum and readHeadASize which might help read performance. Let me know your thoughts about those options.

@bharatviswa504 bharatviswa504 self-assigned this Jun 16, 2019
@hadoop-yetus

This comment has been minimized.

Copy link

hadoop-yetus commented Jun 16, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 27 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 543 trunk passed
+1 compile 281 trunk passed
+1 checkstyle 84 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 954 branch has no errors when building and testing our client artifacts.
+1 javadoc 171 trunk passed
0 spotbugs 338 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 531 trunk passed
_ Patch Compile Tests _
+1 mvninstall 459 the patch passed
+1 compile 288 the patch passed
+1 javac 288 the patch passed
+1 checkstyle 84 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 734 patch has no errors when building and testing our client artifacts.
+1 javadoc 167 the patch passed
+1 findbugs 548 the patch passed
_ Other Tests _
-1 unit 164 hadoop-hdds in the patch failed.
-1 unit 1147 hadoop-ozone in the patch failed.
+1 asflicense 50 The patch does not generate ASF License warnings.
6413
Reason Tests
Failed junit tests hadoop.ozone.container.common.impl.TestHddsDispatcher
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.client.rpc.TestOzoneRpcClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-975/1/artifact/out/Dockerfile
GITHUB PR #975
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux e6eb89338407 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 1da09bd
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-975/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-975/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-975/1/testReport/
Max. process+thread count 4361 (vs. ulimit of 5500)
modules C: hadoop-hdds/common U: hadoop-hdds/common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-975/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

mukul1987 left a comment

Thanks for the change @bharatviswa504 , +1, change looks good to me.

@bharatviswa504

This comment has been minimized.

Copy link
Contributor Author

bharatviswa504 commented Jun 17, 2019

Thank You @mukul1987 for the review.

Any thoughts on using below 2 options.

I see there are 2 more option verify checksum and readHeadASize which might help read performance. Let me know your thoughts about those options.

@bharatviswa504 bharatviswa504 merged commit ba681bb into apache:trunk Jun 17, 2019
6 of 7 checks passed
6 of 7 checks passed
ci/ozone/unit unit check is failed
Details
ci/ozone/acceptance acceptance check is passed
Details
ci/ozone/author author check is passed
Details
ci/ozone/build build check is passed
Details
ci/ozone/checkstyle checkstyle check is passed
Details
ci/ozone/findbugs findbugs check is passed
Details
ci/ozone/rat rat check is passed
Details
bshashikant added a commit to bshashikant/hadoop that referenced this pull request Jul 10, 2019
arp7 pushed a commit to arp7/hadoop that referenced this pull request Sep 18, 2019
…ng iterator. (apache#975)

(cherry picked from commit ba681bb)

Change-Id: Ib9f2e74a93842e471ca64a753fcb9e5064e9f40d
shanthoosh added a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
…lease validation page. (apache#975)

* Fix the rendering of bash and sql scripts in samza-sql release validation page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.