Skip to content
Permalink
Browse files
HBASE-26895 on hbase shell, 'delete/deleteall' for a columnfamily is …
…not working (#4283)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
  • Loading branch information
eomiks committed Apr 12, 2022
1 parent 7ac9e0b commit ea9bc92ce2aa43a18c944b10153678f86eca2d7a
Showing 2 changed files with 25 additions and 2 deletions.
@@ -189,10 +189,18 @@ def _createdelete_internal(row, column = nil,
if column != ""
if column && all_version
family, qualifier = parse_column_name(column)
d.addColumns(family, qualifier, timestamp)
if qualifier
d.addColumns(family, qualifier, timestamp)
else
d.addFamily(family, timestamp)
end
elsif column && !all_version
family, qualifier = parse_column_name(column)
d.addColumn(family, qualifier, timestamp)
if qualifier
d.addColumn(family, qualifier, timestamp)
else
d.addFamilyVersion(family, timestamp)
end
end
end
d
@@ -164,6 +164,21 @@ def teardown
assert_nil(res)
end

define_test "delete should set proper cell type" do
del = @test_table._createdelete_internal('104', 'x:a', 1212)
assert_equal(del.get('x'.to_java_bytes, 'a'.to_java_bytes).get(0).getType.getCode,
org.apache.hadoop.hbase::KeyValue::Type::DeleteColumn.getCode)
del = @test_table._createdelete_internal('104', 'x:a', 1212, [], false)
assert_equal(del.get('x'.to_java_bytes, 'a'.to_java_bytes).get(0).getType.getCode,
org.apache.hadoop.hbase::KeyValue::Type::Delete.getCode)
del = @test_table._createdelete_internal('104', 'x', 1212)
assert_equal(del.get('x'.to_java_bytes, nil).get(0).getType.getCode,
org.apache.hadoop.hbase::KeyValue::Type::DeleteFamily.getCode)
del = @test_table._createdelete_internal('104', 'x', 1212, [], false)
assert_equal(del.get('x'.to_java_bytes, nil).get(0).getType.getCode,
org.apache.hadoop.hbase::KeyValue::Type::DeleteFamilyVersion.getCode)
end

#-------------------------------------------------------------------------------

define_test "deleteall should work w/o columns and timestamps" do

0 comments on commit ea9bc92

Please sign in to comment.