Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-22364 Fixed remaining Checkstyle issue in hbase-hadoop2-compat #218

Merged
merged 1 commit into from May 6, 2019

Conversation

@HorizonNet
Copy link
Contributor

HorizonNet commented May 5, 2019

No description provided.

@Apache-HBase

This comment has been minimized.

Copy link

Apache-HBase commented May 5, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 222 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 mvninstall 265 master passed
+1 compile 17 master passed
+1 checkstyle 12 master passed
+1 shadedjars 263 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 25 master passed
+1 javadoc 13 master passed
_ Patch Compile Tests _
+1 mvninstall 226 the patch passed
+1 compile 15 the patch passed
+1 javac 15 the patch passed
+1 checkstyle 10 hbase-hadoop2-compat: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 243 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 497 Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1 findbugs 34 the patch passed
+1 javadoc 14 the patch passed
_ Other Tests _
+1 unit 33 hbase-hadoop2-compat in the patch passed.
+1 asflicense 12 The patch does not generate ASF License warnings.
1969
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-218/1/artifact/out/Dockerfile
GITHUB PR #218
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 20b3af103a32 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / e884a25
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-218/1/testReport/
Max. process+thread count 288 (vs. ulimit of 10000)
modules C: hbase-hadoop2-compat U: hbase-hadoop2-compat
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-218/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@carp84
carp84 approved these changes May 6, 2019
Copy link
Member

carp84 left a comment

+1, LGTM. Thanks.

@HorizonNet HorizonNet merged commit 45bcb4f into apache:master May 6, 2019
@HorizonNet HorizonNet deleted the ultratendency:HBASE-22364 branch May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.