-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-22586 Javadoc Warnings related to @param tag #322
Conversation
@SyedMurtazaHassan Could you please resolve the merge conflict? |
@SyedMurtazaHassan any updates on this? |
6cfcbff
to
e67cf2b
Compare
@jatsakthi Resolved the merge conflict. Kindly review. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments for improvements.
hbase-server/src/main/java/org/apache/hadoop/hbase/HealthChecker.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/HealthChecker.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/namespace/NamespaceStateManager.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
Outdated
Show resolved
Hide resolved
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java
Outdated
Show resolved
Hide resolved
hbase-server/src/test/java/org/apache/hadoop/hbase/util/ProcessBasedLocalHBaseCluster.java
Outdated
Show resolved
Hide resolved
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/EncodedSeekPerformanceTest.java
Outdated
Show resolved
Hide resolved
hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/TestZKProcedure.java
Outdated
Show resolved
Hide resolved
hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/TestZKProcedure.java
Outdated
Show resolved
Hide resolved
hbase-common/src/main/java/org/apache/hadoop/hbase/PrivateCellUtil.java
Outdated
Show resolved
Hide resolved
… according to Jan's comments
@HorizonNet Thank you. Addressed your comments. Kindly have a look. |
💔 -1 overall
This message was automatically generated. |
Re-running build. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of class links in the params is not consistent in few places. For e.g. CellComparator's link is added in compareWithoutRow() but not in compare(). Can we fix all such cases?
@jatsakthi |
hbase-common/src/test/java/org/apache/hadoop/hbase/util/ClassLoaderTestHelper.java
Show resolved
Hide resolved
* @throws IOException | ||
* @param zk single zookeeper watcher | ||
* @param expectedAddress the expected address of the master | ||
* @throws KeeperException unexpected zookeeper exception |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ZooKeeper"
@SyedMurtazaHassan My suggestion is, if you need to touch the class due to param changes, you can do it in this PR. |
@HorizonNet |
@jatsakthi @HorizonNet Adressed the comments. Kindly have a look when you have time. |
💔 -1 overall
This message was automatically generated. |
LGTM |
💔 -1 overall
This message was automatically generated. |
Fixed javadoc warnings related to @param tag.