Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… #361

Merged
merged 6 commits into from Sep 19, 2019

Conversation

@srdo
Copy link
Contributor

commented Jul 6, 2019

…tTokenUtil, and move ClientTokenUtil to hbase-client

See https://issues.apache.org/jira/browse/HBASE-22027

…tTokenUtil, and move ClientTokenUtil to hbase-client
});
return future;
}

This comment has been minimized.

Copy link
@Apache-HBase

Apache-HBase Jul 6, 2019

whitespace:end of line

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 6, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 187 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 26 Maven dependency ordering for branch
+1 mvninstall 242 master passed
+1 compile 74 master passed
+1 checkstyle 98 master passed
+1 shadedjars 264 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 266 master passed
+1 javadoc 55 master passed
_ Patch Compile Tests _
0 mvndep 16 Maven dependency ordering for patch
+1 mvninstall 235 the patch passed
+1 compile 76 the patch passed
+1 javac 76 the patch passed
-1 checkstyle 28 hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1 whitespace 0 The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 shadedjars 271 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 730 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 269 the patch passed
+1 javadoc 53 the patch passed
_ Other Tests _
+1 unit 113 hbase-client in the patch passed.
-1 unit 15519 hbase-server in the patch failed.
+1 asflicense 44 The patch does not generate ASF License warnings.
18968
Reason Tests
Failed junit tests hadoop.hbase.client.TestFromClientSide
hadoop.hbase.master.assignment.TestOpenRegionProcedureHang
hadoop.hbase.util.TestFromClientSide3WoUnsafe
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/1/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux d3808d750a20 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 9116534
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/1/artifact/out/diff-checkstyle-hbase-client.txt
whitespace https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/1/artifact/out/whitespace-eol.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/1/testReport/
Max. process+thread count 5127 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.


package org.apache.hadoop.hbase.security.token;

import com.google.protobuf.ByteString;

This comment has been minimized.

Copy link
@busbey

busbey Jul 6, 2019

Contributor

Why are we using the non-relocated classes here?

This comment has been minimized.

Copy link
@srdo

srdo Jul 6, 2019

Author Contributor

This is a mistake, nice catch. Will fix.

This comment has been minimized.

Copy link
@srdo

srdo Jul 6, 2019

Author Contributor

The deleted code in TokenUtil was using non relocated classes, as AuthenticationProtos uses the unshaded classes. Should I update AuthenticationProtos to reference shaded classes, or what do you think I should do here?

This comment has been minimized.

Copy link
@srdo

srdo Jul 6, 2019

Author Contributor

Which I guess would require figuring out how to modify the generated code.

This comment has been minimized.

Copy link
@srdo

srdo Jul 6, 2019

Author Contributor

I've left the imports as-is for now.

This comment has been minimized.

Copy link
@saintstack

saintstack Sep 14, 2019

Contributor

I think thats right for this client-facing class. Client stuff is all unshaded 2.5 pb hbase-protocol (as opposed to hbase-protocol-shaded).

This comment has been minimized.

Copy link
@saintstack

saintstack Sep 14, 2019

Contributor

Having second thoughts now.

Why can't this new class be an Interface?

If an Interface, can hide stuff like this.

I can help refactor if you think Interface will work. Thanks

This comment has been minimized.

Copy link
@srdo

srdo Sep 15, 2019

Author Contributor

I'm not sure I follow. How does making ClientTokenUtil an interface affect class shading? The implementation of the ClientTokenUtil interface would still have to reference the unshaded classes, right?

If you have an idea for refactoring this, I'd be happy to merge it into this PR. If you put up a PR against the HBASE-22027 branch at https://github.com/srdo/hbase, I could update this PR with your changes.

This comment has been minimized.

Copy link
@saintstack

saintstack Sep 16, 2019

Contributor

I tried my 'idea' and realize my suggestion of no help -- pardon me. Trying my idea did help me w/ this review though.

Yes, it is appropriate here to use the non-relocated protobuf stuff --i.e. as you have it -- while auth goes via Coprocessor API.

* @throws IOException if a remote error or serialization problem occurs.
* @return the authentication token instance
* See {@link ClientTokenUtil#obtainToken(org.apache.hadoop.hbase.client.Connection)}.
* @deprecated Please use the corresponding method in {@link ClientTokenUtil} instead.

This comment has been minimized.

Copy link
@busbey

busbey Jul 6, 2019

Contributor

This and several of the other deprecated methods point folks to a method that's labeled IA.Private.

If there isn't a IA.Public method to send folks to, we should call out in the deprecation that folks should stop using the functionality or come ask dev@ if it's needed

This comment has been minimized.

Copy link
@srdo

srdo Jul 6, 2019

Author Contributor

I'm going by the posts here https://issues.apache.org/jira/browse/HBASE-22027?focusedCommentId=16789499&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16789499. As I understand, these methods should be IA.Private, as they return types that are IA.Private.

I don't know if there's a public replacement, but I'm happy to update the deprecation notice.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 7, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 47 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 13 Maven dependency ordering for branch
+1 mvninstall 233 master passed
+1 compile 77 master passed
+1 checkstyle 96 master passed
+1 shadedjars 262 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 258 master passed
+1 javadoc 54 master passed
_ Patch Compile Tests _
0 mvndep 15 Maven dependency ordering for patch
+1 mvninstall 238 the patch passed
+1 compile 77 the patch passed
+1 javac 77 the patch passed
-1 checkstyle 29 hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1 checkstyle 69 hbase-server: The patch generated 10 new + 1 unchanged - 0 fixed = 11 total (was 1)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 269 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 730 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 274 the patch passed
+1 javadoc 55 the patch passed
_ Other Tests _
+1 unit 112 hbase-client in the patch passed.
-1 unit 14703 hbase-server in the patch failed.
+1 asflicense 55 The patch does not generate ASF License warnings.
17985
Reason Tests
Failed junit tests hadoop.hbase.quotas.TestQuotaAdmin
hadoop.hbase.client.TestAsyncRegionAdminApi
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/2/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 1cc384b61a44 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 9116534
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/2/artifact/out/diff-checkstyle-hbase-client.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/2/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/2/testReport/
Max. process+thread count 4896 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 7, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 51 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 21 Maven dependency ordering for branch
+1 mvninstall 247 master passed
+1 compile 75 master passed
+1 checkstyle 92 master passed
+1 shadedjars 267 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 262 master passed
+1 javadoc 55 master passed
_ Patch Compile Tests _
0 mvndep 16 Maven dependency ordering for patch
+1 mvninstall 240 the patch passed
+1 compile 77 the patch passed
+1 javac 77 the patch passed
+1 checkstyle 97 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 265 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 746 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 276 the patch passed
+1 javadoc 52 the patch passed
_ Other Tests _
+1 unit 104 hbase-client in the patch passed.
+1 unit 14999 hbase-server in the patch passed.
+1 asflicense 49 The patch does not generate ASF License warnings.
18313
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/3/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux ffbdffaa2a8e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 9116534
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/3/testReport/
Max. process+thread count 4918 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/3/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 12, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 70 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 27 Maven dependency ordering for branch
-1 mvninstall 13 root in master failed.
-1 compile 42 hbase-server in master failed.
+1 checkstyle 101 master passed
+1 shadedjars 288 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 304 master passed
+1 javadoc 62 master passed
_ Patch Compile Tests _
0 mvndep 15 Maven dependency ordering for patch
+1 mvninstall 271 the patch passed
-1 compile 46 hbase-server in the patch failed.
-1 javac 46 hbase-server in the patch failed.
+1 checkstyle 104 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 289 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 842 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 331 the patch passed
-1 javadoc 42 hbase-server generated 28 new + 0 unchanged - 0 fixed = 28 total (was 0)
_ Other Tests _
+1 unit 131 hbase-client in the patch passed.
-1 unit 43 hbase-server in the patch failed.
+1 asflicense 23 The patch does not generate ASF License warnings.
3478
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/4/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 671995e839d7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 438bf32
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/4/artifact/out/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/4/artifact/out/branch-compile-hbase-server.txt
findbugs v3.1.11
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/4/artifact/out/patch-compile-hbase-server.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/4/artifact/out/patch-compile-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/4/artifact/out/diff-javadoc-javadoc-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/4/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/4/testReport/
Max. process+thread count 293 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/4/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 15, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 67 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 24 Maven dependency ordering for branch
+1 mvninstall 240 master passed
+1 compile 74 master passed
+1 checkstyle 91 master passed
+1 shadedjars 254 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 256 master passed
+1 javadoc 50 master passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 230 the patch passed
+1 compile 74 the patch passed
+1 javac 74 the patch passed
+1 checkstyle 88 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 254 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 699 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
-1 findbugs 62 hbase-server in the patch failed.
-1 javadoc 32 hbase-server generated 28 new + 0 unchanged - 0 fixed = 28 total (was 0)
_ Other Tests _
+1 unit 103 hbase-client in the patch passed.
-1 unit 39 hbase-server in the patch failed.
+1 asflicense 19 The patch does not generate ASF License warnings.
3050
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/5/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux e1478cc72d11 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 74731c2
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/5/artifact/out/patch-findbugs-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/5/artifact/out/diff-javadoc-javadoc-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/5/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/5/testReport/
Max. process+thread count 284 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/5/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@srdo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

The failure on Jenkins seems to be the hbase-server not compiling because it can't find the new ClientTokenUtil class (e.g. https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/5/artifact/out/patch-unit-hbase-server.txt). This build command runs fine for me locally.

Is the script maybe set up so it is pulling in an old hbase-client jar?

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 16, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 194 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 44 Maven dependency ordering for branch
+1 mvninstall 288 master passed
+1 compile 76 master passed
+1 checkstyle 96 master passed
+1 shadedjars 262 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 255 master passed
+1 javadoc 56 master passed
_ Patch Compile Tests _
0 mvndep 16 Maven dependency ordering for patch
+1 mvninstall 251 the patch passed
+1 compile 80 the patch passed
+1 javac 80 the patch passed
+1 checkstyle 98 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 266 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 727 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 279 the patch passed
+1 javadoc 56 the patch passed
_ Other Tests _
+1 unit 110 hbase-client in the patch passed.
-1 unit 14950 hbase-server in the patch failed.
+1 asflicense 52 The patch does not generate ASF License warnings.
18470
Reason Tests
Failed junit tests hadoop.hbase.master.procedure.TestSCPWithReplicas
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/6/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f800ddb354ca 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / cc38de1
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/6/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/6/testReport/
Max. process+thread count 4783 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/6/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 17, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 58 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 27 Maven dependency ordering for branch
+1 mvninstall 244 master passed
+1 compile 74 master passed
+1 checkstyle 90 master passed
+1 shadedjars 258 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 263 master passed
+1 javadoc 52 master passed
_ Patch Compile Tests _
0 mvndep 15 Maven dependency ordering for patch
+1 mvninstall 230 the patch passed
-1 compile 38 hbase-server in the patch failed.
-1 javac 38 hbase-server in the patch failed.
+1 checkstyle 89 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 252 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 710 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 270 the patch passed
-1 javadoc 33 hbase-server generated 28 new + 0 unchanged - 0 fixed = 28 total (was 0)
_ Other Tests _
+1 unit 103 hbase-client in the patch passed.
-1 unit 37 hbase-server in the patch failed.
+1 asflicense 22 The patch does not generate ASF License warnings.
3213
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/7/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux c89af6836b49 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 72e58a8
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/7/artifact/out/patch-compile-hbase-server.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/7/artifact/out/patch-compile-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/7/artifact/out/diff-javadoc-javadoc-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/7/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/7/testReport/
Max. process+thread count 274 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/7/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 20, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 70 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 26 Maven dependency ordering for branch
+1 mvninstall 255 master passed
+1 compile 77 master passed
+1 checkstyle 101 master passed
+1 shadedjars 271 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 267 master passed
+1 javadoc 53 master passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 240 the patch passed
+1 compile 77 the patch passed
+1 javac 77 the patch passed
+1 checkstyle 102 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 271 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 856 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 304 the patch passed
+1 javadoc 55 the patch passed
_ Other Tests _
+1 unit 110 hbase-client in the patch passed.
+1 unit 13246 hbase-server in the patch passed.
+1 asflicense 47 The patch does not generate ASF License warnings.
16770
Subsystem Report/Notes
Docker Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/8/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 32e4ef2272c6 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 00075ea
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/8/testReport/
Max. process+thread count 4514 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/8/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 22, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 68 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 50 Maven dependency ordering for branch
+1 mvninstall 274 master passed
+1 compile 75 master passed
+1 checkstyle 102 master passed
+1 shadedjars 268 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 55 master passed
0 spotbugs 234 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 299 master passed
_ Patch Compile Tests _
0 mvndep 14 Maven dependency ordering for patch
+1 mvninstall 248 the patch passed
+1 compile 75 the patch passed
+1 javac 75 the patch passed
+1 checkstyle 99 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 262 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 736 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 51 the patch passed
+1 findbugs 319 the patch passed
_ Other Tests _
+1 unit 101 hbase-client in the patch passed.
-1 unit 16947 hbase-server in the patch failed.
+1 asflicense 48 The patch does not generate ASF License warnings.
20412
Reason Tests
Failed junit tests hadoop.hbase.replication.TestReplicationSmallTests
hadoop.hbase.client.TestCloneSnapshotFromClientNormal
hadoop.hbase.namespace.TestNamespaceAuditor
hadoop.hbase.replication.TestReplicationSmallTestsSync
hadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.client.TestConnection
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
Subsystem Report/Notes
Docker Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/9/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 368aab1b1d41 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / c9293b0
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/9/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/9/testReport/
Max. process+thread count 4725 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/9/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 22, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 180 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 29 Maven dependency ordering for branch
+1 mvninstall 326 master passed
+1 compile 84 master passed
+1 checkstyle 109 master passed
+1 shadedjars 409 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 144 master passed
0 spotbugs 228 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 295 master passed
_ Patch Compile Tests _
0 mvndep 15 Maven dependency ordering for patch
+1 mvninstall 284 the patch passed
+1 compile 81 the patch passed
+1 javac 81 the patch passed
+1 checkstyle 109 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 282 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 749 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 54 the patch passed
+1 findbugs 322 the patch passed
_ Other Tests _
+1 unit 111 hbase-client in the patch passed.
-1 unit 14913 hbase-server in the patch failed.
+1 asflicense 52 The patch does not generate ASF License warnings.
18873
Subsystem Report/Notes
Docker Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/10/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 85c3e5180baa 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / aa9679d
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/10/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/10/testReport/
Max. process+thread count 4974 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/10/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@srdo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

@busbey Is there anything I should do to get this approved?

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 23, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 84 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 34 Maven dependency ordering for branch
+1 mvninstall 283 master passed
+1 compile 75 master passed
+1 checkstyle 103 master passed
+1 shadedjars 254 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 53 master passed
0 spotbugs 363 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 18 hbase-client in master failed.
-1 findbugs 37 hbase-server in master failed.
_ Patch Compile Tests _
0 mvndep 14 Maven dependency ordering for patch
+1 mvninstall 272 the patch passed
+1 compile 79 the patch passed
+1 javac 79 the patch passed
+1 checkstyle 98 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 263 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 743 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 57 the patch passed
+1 findbugs 314 the patch passed
_ Other Tests _
+1 unit 113 hbase-client in the patch passed.
-1 unit 14935 hbase-server in the patch failed.
+1 asflicense 50 The patch does not generate ASF License warnings.
18231
Reason Tests
Failed junit tests hadoop.hbase.regionserver.TestSplitTransactionOnCluster
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/13/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 36ef92337a30 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / 9615c64
Default Java 1.8.0_181
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/13/artifact/out/branch-findbugs-hbase-client.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/13/artifact/out/branch-findbugs-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/13/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/13/testReport/
Max. process+thread count 4767 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/13/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 23, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 61 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 11 Maven dependency ordering for branch
+1 mvninstall 242 master passed
+1 compile 77 master passed
+1 checkstyle 105 master passed
+1 shadedjars 259 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 55 master passed
0 spotbugs 239 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 304 master passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 238 the patch passed
-1 compile 36 hbase-server in the patch failed.
-1 javac 36 hbase-server in the patch failed.
+1 checkstyle 98 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 260 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 739 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 52 the patch passed
+1 findbugs 316 the patch passed
_ Other Tests _
+1 unit 100 hbase-client in the patch passed.
-1 unit 1575 hbase-server in the patch failed.
+1 asflicense 23 The patch does not generate ASF License warnings.
4899
Reason Tests
Failed junit tests hadoop.hbase.io.hfile.TestSeekTo
hadoop.hbase.io.hfile.TestLruBlockCache
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/15/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 9187f4337692 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / 06f5c43
Default Java 1.8.0_181
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/15/artifact/out/patch-compile-hbase-server.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/15/artifact/out/patch-compile-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/15/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/15/testReport/
Max. process+thread count 695 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/15/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 23, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 116 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 59 Maven dependency ordering for branch
+1 mvninstall 363 master passed
+1 compile 76 master passed
+1 checkstyle 114 master passed
+1 shadedjars 302 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 56 master passed
0 spotbugs 242 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 310 master passed
_ Patch Compile Tests _
0 mvndep 16 Maven dependency ordering for patch
+1 mvninstall 289 the patch passed
+1 compile 78 the patch passed
+1 javac 78 the patch passed
+1 checkstyle 105 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 311 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 869 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 55 the patch passed
+1 findbugs 343 the patch passed
_ Other Tests _
+1 unit 105 hbase-client in the patch passed.
-1 unit 14566 hbase-server in the patch failed.
+1 asflicense 47 The patch does not generate ASF License warnings.
18543
Reason Tests
Failed junit tests hadoop.hbase.replication.TestMasterReplication
hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalGiveUpSplitting
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.replication.TestAddToSerialReplicationPeer
hadoop.hbase.replication.TestReplicationMetricsforUI
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/14/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 36037f64697e 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / 0e34dcb
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/14/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/14/testReport/
Max. process+thread count 4425 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/14/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 23, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 37 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 23 Maven dependency ordering for branch
+1 mvninstall 257 master passed
+1 compile 77 master passed
+1 checkstyle 105 master passed
+1 shadedjars 271 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 55 master passed
0 spotbugs 238 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 301 master passed
_ Patch Compile Tests _
0 mvndep 14 Maven dependency ordering for patch
+1 mvninstall 244 the patch passed
+1 compile 76 the patch passed
+1 javac 76 the patch passed
+1 checkstyle 106 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 265 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 721 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 55 the patch passed
+1 findbugs 309 the patch passed
_ Other Tests _
+1 unit 109 hbase-client in the patch passed.
+1 unit 7643 hbase-server in the patch passed.
+1 asflicense 51 The patch does not generate ASF License warnings.
11050
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/16/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 9b0f4d31e45c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / 06f5c43
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/16/testReport/
Max. process+thread count 4138 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/16/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 23, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 60 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 22 Maven dependency ordering for branch
-1 mvninstall 331 root in master failed.
+1 compile 74 master passed
+1 checkstyle 103 master passed
+1 shadedjars 288 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 57 master passed
0 spotbugs 238 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 304 master passed
_ Patch Compile Tests _
0 mvndep 16 Maven dependency ordering for patch
-1 mvninstall 320 root in the patch failed.
+1 compile 80 the patch passed
+1 javac 80 the patch passed
+1 checkstyle 105 the patch passed
+1 whitespace 1 The patch has no whitespace issues.
+1 shadedjars 269 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 268 The patch causes 10 errors with Hadoop v2.8.5.
-1 hadoopcheck 544 The patch causes 10 errors with Hadoop v2.9.2.
-1 hadoopcheck 789 The patch causes 10 errors with Hadoop v3.1.2.
+1 javadoc 55 the patch passed
+1 findbugs 310 the patch passed
_ Other Tests _
+1 unit 108 hbase-client in the patch passed.
-1 unit 13501 hbase-server in the patch failed.
+1 asflicense 48 The patch does not generate ASF License warnings.
16931
Reason Tests
Failed junit tests hadoop.hbase.client.TestAsyncRegionAdminApi2
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/17/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux a220360c7c71 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / e74d501
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/17/artifact/out/branch-mvninstall-root.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/17/artifact/out/patch-mvninstall-root.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/17/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/17/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/17/artifact/out/patch-javac-3.1.2.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/17/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/17/testReport/
Max. process+thread count 4986 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/17/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 24, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 64 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 12 Maven dependency ordering for branch
+1 mvninstall 279 master passed
+1 compile 73 master passed
+1 checkstyle 98 master passed
+1 shadedjars 262 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 52 master passed
0 spotbugs 225 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 290 master passed
_ Patch Compile Tests _
0 mvndep 14 Maven dependency ordering for patch
+1 mvninstall 287 the patch passed
+1 compile 75 the patch passed
+1 javac 75 the patch passed
+1 checkstyle 97 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 255 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 875 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 52 the patch passed
+1 findbugs 312 the patch passed
_ Other Tests _
+1 unit 108 hbase-client in the patch passed.
-1 unit 17035 hbase-server in the patch failed.
+1 asflicense 50 The patch does not generate ASF License warnings.
20666
Reason Tests
Failed junit tests hadoop.hbase.replication.TestReplicationSmallTests
hadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.replication.TestReplicationSmallTestsSync
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/20/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 6b734d0af78c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / 6705d4f
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/20/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/20/testReport/
Max. process+thread count 5060 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/20/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 24, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 41 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 38 Maven dependency ordering for branch
+1 mvninstall 343 master passed
+1 compile 87 master passed
+1 checkstyle 108 master passed
+1 shadedjars 311 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 53 master passed
0 spotbugs 227 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 290 master passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 300 the patch passed
+1 compile 76 the patch passed
+1 javac 76 the patch passed
+1 checkstyle 97 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 276 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 911 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
-1 javadoc 39 hbase-server generated 28 new + 0 unchanged - 0 fixed = 28 total (was 0)
-1 findbugs 36 hbase-server in the patch failed.
_ Other Tests _
+1 unit 108 hbase-client in the patch passed.
-1 unit 38 hbase-server in the patch failed.
+1 asflicense 21 The patch does not generate ASF License warnings.
3668
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/22/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 7b98ae9dba00 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / 7ebf80f
Default Java 1.8.0_181
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/22/artifact/out/diff-javadoc-javadoc-hbase-server.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/22/artifact/out/patch-findbugs-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/22/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/22/testReport/
Max. process+thread count 291 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/22/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 24, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 59 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 24 Maven dependency ordering for branch
+1 mvninstall 298 master passed
+1 compile 77 master passed
+1 checkstyle 107 master passed
+1 shadedjars 300 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 56 master passed
0 spotbugs 247 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 315 master passed
_ Patch Compile Tests _
0 mvndep 15 Maven dependency ordering for patch
+1 mvninstall 302 the patch passed
+1 compile 80 the patch passed
+1 javac 80 the patch passed
+1 checkstyle 110 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 302 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1023 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 60 the patch passed
+1 findbugs 329 the patch passed
_ Other Tests _
+1 unit 104 hbase-client in the patch passed.
-1 unit 16237 hbase-server in the patch failed.
+1 asflicense 54 The patch does not generate ASF License warnings.
20256
Reason Tests
Failed junit tests hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/21/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux d566142d5ceb 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / 7ebf80f
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/21/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/21/testReport/
Max. process+thread count 5186 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/21/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 24, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 73 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 25 Maven dependency ordering for branch
-1 mvninstall 332 root in master failed.
+1 compile 77 master passed
+1 checkstyle 103 master passed
+1 shadedjars 314 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 57 master passed
0 spotbugs 241 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 304 master passed
_ Patch Compile Tests _
0 mvndep 18 Maven dependency ordering for patch
-1 mvninstall 311 root in the patch failed.
+1 compile 80 the patch passed
+1 javac 80 the patch passed
+1 checkstyle 103 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 268 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 263 The patch causes 10 errors with Hadoop v2.8.5.
-1 hadoopcheck 533 The patch causes 10 errors with Hadoop v2.9.2.
-1 hadoopcheck 787 The patch causes 10 errors with Hadoop v3.1.2.
+1 javadoc 51 the patch passed
+1 findbugs 311 the patch passed
_ Other Tests _
+1 unit 108 hbase-client in the patch passed.
-1 unit 16570 hbase-server in the patch failed.
+1 asflicense 47 The patch does not generate ASF License warnings.
20034
Reason Tests
Failed junit tests hadoop.hbase.client.TestConnection
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
hadoop.hbase.util.TestFromClientSide3WoUnsafe
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/23/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f60596fa28ee 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / a399a14
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/23/artifact/out/branch-mvninstall-root.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/23/artifact/out/patch-mvninstall-root.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/23/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/23/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/23/artifact/out/patch-javac-3.1.2.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/23/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/23/testReport/
Max. process+thread count 5086 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/23/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 25, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 83 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 27 Maven dependency ordering for branch
+1 mvninstall 317 master passed
+1 compile 82 master passed
+1 checkstyle 109 master passed
+1 shadedjars 300 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 57 master passed
0 spotbugs 240 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 309 master passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 294 the patch passed
+1 compile 81 the patch passed
+1 javac 81 the patch passed
+1 checkstyle 105 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 298 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1008 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 59 the patch passed
+1 findbugs 326 the patch passed
_ Other Tests _
+1 unit 114 hbase-client in the patch passed.
-1 unit 17998 hbase-server in the patch failed.
+1 asflicense 52 The patch does not generate ASF License warnings.
22018
Reason Tests
Failed junit tests hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.replication.TestReplicationSmallTestsSync
hadoop.hbase.master.procedure.TestSCPWithReplicas
hadoop.hbase.client.TestAsyncTableAdminApi
hadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.client.TestAsyncTableBatch
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/26/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f84646f27595 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / a65e72d
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/26/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/26/testReport/
Max. process+thread count 5482 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/26/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 25, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 104 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 28 Maven dependency ordering for branch
+1 mvninstall 344 master passed
+1 compile 81 master passed
+1 checkstyle 120 master passed
+1 shadedjars 294 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 56 master passed
0 spotbugs 253 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 320 master passed
_ Patch Compile Tests _
0 mvndep 16 Maven dependency ordering for patch
+1 mvninstall 322 the patch passed
+1 compile 83 the patch passed
+1 javac 83 the patch passed
+1 checkstyle 122 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 295 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1003 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 57 the patch passed
+1 findbugs 338 the patch passed
_ Other Tests _
+1 unit 106 hbase-client in the patch passed.
-1 unit 9134 hbase-server in the patch failed.
+1 asflicense 47 The patch does not generate ASF License warnings.
13281
Reason Tests
Failed junit tests hadoop.hbase.master.replication.TestTransitPeerSyncReplicationStateProcedureRetry
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/28/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 4ba302ffb42d 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / b83d0c0
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/28/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/28/testReport/
Max. process+thread count 4424 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/28/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Jul 25, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 85 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 27 Maven dependency ordering for branch
+1 mvninstall 310 master passed
+1 compile 80 master passed
+1 checkstyle 106 master passed
+1 shadedjars 275 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 56 master passed
0 spotbugs 227 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 288 master passed
_ Patch Compile Tests _
0 mvndep 14 Maven dependency ordering for patch
+1 mvninstall 288 the patch passed
+1 compile 75 the patch passed
+1 javac 75 the patch passed
+1 checkstyle 100 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 265 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 899 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 51 the patch passed
+1 findbugs 293 the patch passed
_ Other Tests _
+1 unit 106 hbase-client in the patch passed.
-1 unit 18166 hbase-server in the patch failed.
+1 asflicense 45 The patch does not generate ASF License warnings.
21906
Reason Tests
Failed junit tests hadoop.hbase.replication.TestReplicationKillSlaveRS
hadoop.hbase.namespace.TestNamespaceAuditor
hadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.replication.TestReplicationSmallTestsSync
hadoop.hbase.tool.TestSecureBulkLoadHFiles
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
hadoop.hbase.replication.TestReplicationSmallTests
hadoop.hbase.tool.TestBulkLoadHFiles
hadoop.hbase.util.TestFromClientSide3WoUnsafe
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/27/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 9ffe8c771f11 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / e28afec
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/27/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/27/testReport/
Max. process+thread count 5106 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/27/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment has been minimized.

Copy link

commented Jul 25, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 75 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 1 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 30 Maven dependency ordering for branch
+1 mvninstall 352 master passed
+1 compile 81 master passed
+1 checkstyle 104 master passed
+1 shadedjars 278 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 56 master passed
0 spotbugs 277 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 354 master passed
_ Patch Compile Tests _
0 mvndep 17 Maven dependency ordering for patch
+1 mvninstall 311 the patch passed
-1 compile 41 hbase-server in the patch failed.
-1 javac 41 hbase-server in the patch failed.
+1 checkstyle 106 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 308 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 491 The patch causes 10 errors with Hadoop v2.9.2.
-1 hadoopcheck 649 The patch causes 10 errors with Hadoop v3.1.2.
-1 javadoc 36 hbase-server generated 28 new + 0 unchanged - 0 fixed = 28 total (was 0)
-1 findbugs 43 hbase-server in the patch failed.
_ Other Tests _
+1 unit 110 hbase-client in the patch passed.
-1 unit 47 hbase-server in the patch failed.
+1 asflicense 24 The patch does not generate ASF License warnings.
3247
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/29/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 214ac9725f02 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / de98fee
Default Java 1.8.0_181
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/29/artifact/out/patch-compile-hbase-server.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/29/artifact/out/patch-compile-hbase-server.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/29/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/29/artifact/out/patch-javac-3.1.2.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/29/artifact/out/diff-javadoc-javadoc-hbase-server.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/29/artifact/out/patch-findbugs-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/29/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/29/testReport/
Max. process+thread count 295 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/29/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Aug 27, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 35 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 36 Maven dependency ordering for branch
+1 mvninstall 315 master passed
+1 compile 80 master passed
+1 checkstyle 108 master passed
+1 shadedjars 282 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 61 master passed
0 spotbugs 238 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 304 master passed
_ Patch Compile Tests _
0 mvndep 18 Maven dependency ordering for patch
+1 mvninstall 296 the patch passed
+1 compile 83 the patch passed
+1 javac 83 the patch passed
+1 checkstyle 118 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 308 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 952 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 57 the patch passed
+1 findbugs 277 the patch passed
_ Other Tests _
+1 unit 108 hbase-client in the patch passed.
+1 unit 8908 hbase-server in the patch passed.
+1 asflicense 62 The patch does not generate ASF License warnings.
12795
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/140/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux e51a0917294e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / ec68bf3
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/140/testReport/
Max. process+thread count 4550 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/140/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Aug 28, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 36 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 36 Maven dependency ordering for branch
+1 mvninstall 311 master passed
+1 compile 82 master passed
+1 checkstyle 108 master passed
+1 shadedjars 273 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 60 master passed
0 spotbugs 240 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 303 master passed
_ Patch Compile Tests _
0 mvndep 18 Maven dependency ordering for patch
+1 mvninstall 293 the patch passed
+1 compile 80 the patch passed
+1 javac 80 the patch passed
+1 checkstyle 108 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 267 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 921 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 57 the patch passed
+1 findbugs 314 the patch passed
_ Other Tests _
+1 unit 108 hbase-client in the patch passed.
+1 unit 9039 hbase-server in the patch passed.
+1 asflicense 62 The patch does not generate ASF License warnings.
12869
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/141/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux ac2085a30b3f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / 3e2cfc1
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/141/testReport/
Max. process+thread count 4377 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/141/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Aug 28, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 78 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 34 Maven dependency ordering for branch
+1 mvninstall 350 master passed
+1 compile 85 master passed
+1 checkstyle 125 master passed
+1 shadedjars 303 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 58 master passed
0 spotbugs 251 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 320 master passed
_ Patch Compile Tests _
0 mvndep 15 Maven dependency ordering for patch
+1 mvninstall 330 the patch passed
+1 compile 94 the patch passed
+1 javac 94 the patch passed
+1 checkstyle 127 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 315 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1039 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 56 the patch passed
+1 findbugs 343 the patch passed
_ Other Tests _
+1 unit 106 hbase-client in the patch passed.
-1 unit 13193 hbase-server in the patch failed.
+1 asflicense 48 The patch does not generate ASF License warnings.
17441
Reason Tests
Failed junit tests hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/142/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 5c6dde94041e 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / 56980fb
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/142/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/142/testReport/
Max. process+thread count 4758 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/142/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Aug 29, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 336 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 49 Maven dependency ordering for branch
+1 mvninstall 630 master passed
+1 compile 128 master passed
+1 checkstyle 150 master passed
+1 shadedjars 433 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 93 master passed
0 spotbugs 377 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 480 master passed
_ Patch Compile Tests _
0 mvndep 22 Maven dependency ordering for patch
+1 mvninstall 510 the patch passed
+1 compile 128 the patch passed
+1 javac 128 the patch passed
+1 checkstyle 142 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 399 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1543 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 78 the patch passed
+1 findbugs 468 the patch passed
_ Other Tests _
+1 unit 133 hbase-client in the patch passed.
-1 unit 16811 hbase-server in the patch failed.
+1 asflicense 55 The patch does not generate ASF License warnings.
23156
Reason Tests
Failed junit tests hadoop.hbase.replication.TestReplicationKillSlaveRS
hadoop.hbase.replication.TestReplicationChangingPeerRegionservers
hadoop.hbase.replication.TestSyncReplicationRemoveRemoteWAL
hadoop.hbase.replication.TestReplicationSmallTests
hadoop.hbase.replication.TestMasterReplication
hadoop.hbase.tool.TestBulkLoadHFiles
hadoop.hbase.replication.TestNamespaceReplication
hadoop.hbase.io.hfile.bucket.TestBucketCache
hadoop.hbase.master.TestMasterShutdown
hadoop.hbase.replication.TestReplicationDisableInactivePeer
hadoop.hbase.tool.TestSecureBulkLoadHFiles
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/143/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux c0cdd61c8980 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / 56980fb
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/143/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/143/testReport/
Max. process+thread count 4669 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/143/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Aug 30, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 35 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 35 Maven dependency ordering for branch
+1 mvninstall 321 master passed
+1 compile 85 master passed
+1 checkstyle 111 master passed
+1 shadedjars 282 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 60 master passed
0 spotbugs 255 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 325 master passed
_ Patch Compile Tests _
0 mvndep 17 Maven dependency ordering for patch
+1 mvninstall 314 the patch passed
+1 compile 84 the patch passed
+1 javac 84 the patch passed
+1 checkstyle 133 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 355 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1159 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 66 the patch passed
+1 findbugs 381 the patch passed
_ Other Tests _
+1 unit 117 hbase-client in the patch passed.
+1 unit 9963 hbase-server in the patch passed.
+1 asflicense 52 The patch does not generate ASF License warnings.
14370
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/144/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 0fb2de274066 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / f6a4c66
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/144/testReport/
Max. process+thread count 4870 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/144/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Aug 30, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 40 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 34 Maven dependency ordering for branch
+1 mvninstall 341 master passed
+1 compile 84 master passed
+1 checkstyle 121 master passed
+1 shadedjars 309 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 63 master passed
0 spotbugs 233 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 305 master passed
_ Patch Compile Tests _
0 mvndep 17 Maven dependency ordering for patch
+1 mvninstall 346 the patch passed
+1 compile 88 the patch passed
+1 javac 88 the patch passed
+1 checkstyle 129 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 303 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1037 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 57 the patch passed
+1 findbugs 373 the patch passed
_ Other Tests _
+1 unit 120 hbase-client in the patch passed.
-1 unit 10808 hbase-server in the patch failed.
+1 asflicense 52 The patch does not generate ASF License warnings.
15051
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/145/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 802e2ed61235 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / 090c55f
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/145/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/145/testReport/
Max. process+thread count 4833 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/145/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Aug 30, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 52 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 68 Maven dependency ordering for branch
+1 mvninstall 335 master passed
+1 compile 86 master passed
+1 checkstyle 120 master passed
+1 shadedjars 289 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 59 master passed
0 spotbugs 240 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 309 master passed
_ Patch Compile Tests _
0 mvndep 18 Maven dependency ordering for patch
+1 mvninstall 306 the patch passed
+1 compile 84 the patch passed
+1 javac 84 the patch passed
+1 checkstyle 119 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 301 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 931 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 58 the patch passed
+1 findbugs 320 the patch passed
_ Other Tests _
+1 unit 114 hbase-client in the patch passed.
+1 unit 9319 hbase-server in the patch passed.
+1 asflicense 60 The patch does not generate ASF License warnings.
13343
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/146/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f2d700eaa3ed 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / 090c55f
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/146/testReport/
Max. process+thread count 4403 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/146/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Aug 31, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 149 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 286 Maven dependency ordering for branch
+1 mvninstall 495 master passed
+1 compile 106 master passed
+1 checkstyle 137 master passed
+1 shadedjars 373 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 76 master passed
0 spotbugs 303 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 391 master passed
_ Patch Compile Tests _
0 mvndep 20 Maven dependency ordering for patch
+1 mvninstall 438 the patch passed
+1 compile 110 the patch passed
+1 javac 110 the patch passed
+1 checkstyle 140 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 367 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1359 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 74 the patch passed
+1 findbugs 411 the patch passed
_ Other Tests _
+1 unit 120 hbase-client in the patch passed.
+1 unit 14452 hbase-server in the patch passed.
+1 asflicense 49 The patch does not generate ASF License warnings.
20062
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/147/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 61a8ccb7b5a4 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / ee5cf0d
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/147/testReport/
Max. process+thread count 4658 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/147/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Sep 1, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 35 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 36 Maven dependency ordering for branch
+1 mvninstall 341 master passed
+1 compile 82 master passed
+1 checkstyle 108 master passed
+1 shadedjars 274 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 61 master passed
0 spotbugs 235 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 298 master passed
_ Patch Compile Tests _
0 mvndep 18 Maven dependency ordering for patch
+1 mvninstall 303 the patch passed
+1 compile 83 the patch passed
+1 javac 83 the patch passed
+1 checkstyle 107 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 274 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 934 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 59 the patch passed
+1 findbugs 333 the patch passed
_ Other Tests _
+1 unit 109 hbase-client in the patch passed.
+1 unit 9324 hbase-server in the patch passed.
+1 asflicense 65 The patch does not generate ASF License warnings.
13239
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/148/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux b15dbf14e11b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / b642ee0
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/148/testReport/
Max. process+thread count 4795 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/148/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Sep 1, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 73 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 36 Maven dependency ordering for branch
+1 mvninstall 349 master passed
+1 compile 86 master passed
+1 checkstyle 126 master passed
+1 shadedjars 311 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 60 master passed
0 spotbugs 281 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 351 master passed
_ Patch Compile Tests _
0 mvndep 16 Maven dependency ordering for patch
+1 mvninstall 337 the patch passed
+1 compile 88 the patch passed
+1 javac 88 the patch passed
+1 checkstyle 142 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 367 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1345 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 79 the patch passed
+1 findbugs 444 the patch passed
_ Other Tests _
+1 unit 130 hbase-client in the patch passed.
-1 unit 15917 hbase-server in the patch failed.
+1 asflicense 48 The patch does not generate ASF License warnings.
20843
Reason Tests
Failed junit tests hadoop.hbase.master.TestShutdownBackupMaster
hadoop.hbase.master.TestSplitWALManager
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/149/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 6c87c28ded8f 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / 97fbaa6
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/149/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/149/testReport/
Max. process+thread count 4947 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/149/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Sep 2, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 36 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 38 Maven dependency ordering for branch
+1 mvninstall 317 master passed
+1 compile 80 master passed
+1 checkstyle 106 master passed
+1 shadedjars 269 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 59 master passed
0 spotbugs 242 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 308 master passed
_ Patch Compile Tests _
0 mvndep 18 Maven dependency ordering for patch
+1 mvninstall 320 the patch passed
+1 compile 85 the patch passed
+1 javac 85 the patch passed
+1 checkstyle 123 the patch passed
+1 whitespace 1 The patch has no whitespace issues.
+1 shadedjars 295 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 931 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 59 the patch passed
+1 findbugs 314 the patch passed
_ Other Tests _
+1 unit 114 hbase-client in the patch passed.
+1 unit 9469 hbase-server in the patch passed.
+1 asflicense 64 The patch does not generate ASF License warnings.
13386
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/150/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 92a1e81173e2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / a5ef6b2
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/150/testReport/
Max. process+thread count 4816 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/150/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment was marked as outdated.

Copy link

commented Sep 2, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 32 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 36 Maven dependency ordering for branch
+1 mvninstall 345 master passed
+1 compile 88 master passed
+1 checkstyle 126 master passed
+1 shadedjars 299 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 66 master passed
0 spotbugs 298 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 383 master passed
_ Patch Compile Tests _
0 mvndep 17 Maven dependency ordering for patch
+1 mvninstall 329 the patch passed
+1 compile 90 the patch passed
+1 javac 90 the patch passed
+1 checkstyle 121 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 301 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1034 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 66 the patch passed
+1 findbugs 401 the patch passed
_ Other Tests _
+1 unit 110 hbase-client in the patch passed.
-1 unit 11228 hbase-server in the patch failed.
+1 asflicense 52 The patch does not generate ASF License warnings.
15546
Reason Tests
Failed junit tests hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/151/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 0fa9a034f36c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / d32bf8d
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/151/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/151/testReport/
Max. process+thread count 4473 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/151/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment has been minimized.

Copy link

commented Sep 2, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 38 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 38 Maven dependency ordering for branch
+1 mvninstall 314 master passed
+1 compile 83 master passed
+1 checkstyle 109 master passed
+1 shadedjars 274 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 58 master passed
0 spotbugs 248 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 312 master passed
_ Patch Compile Tests _
0 mvndep 17 Maven dependency ordering for patch
+1 mvninstall 296 the patch passed
+1 compile 81 the patch passed
+1 javac 80 the patch passed
+1 checkstyle 106 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 269 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 946 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 56 the patch passed
+1 findbugs 362 the patch passed
_ Other Tests _
+1 unit 121 hbase-client in the patch passed.
-1 unit 10276 hbase-server in the patch failed.
+1 asflicense 61 The patch does not generate ASF License warnings.
14222
Reason Tests
Failed junit tests hadoop.hbase.master.replication.TestTransitPeerSyncReplicationStateProcedureRetry
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/152/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 011e8c91f2e8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / 8e8bd8b
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/152/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/152/testReport/
Max. process+thread count 4873 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/152/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


package org.apache.hadoop.hbase.security.token;

import com.google.protobuf.ByteString;

This comment has been minimized.

Copy link
@saintstack

saintstack Sep 14, 2019

Contributor

I think thats right for this client-facing class. Client stuff is all unshaded 2.5 pb hbase-protocol (as opposed to hbase-protocol-shaded).

Copy link
Contributor

left a comment

Some notes informed by my trying to make an impl.


package org.apache.hadoop.hbase.security.token;

import com.google.protobuf.ByteString;

This comment has been minimized.

Copy link
@saintstack

saintstack Sep 16, 2019

Contributor

I tried my 'idea' and realize my suggestion of no help -- pardon me. Trying my idea did help me w/ this review though.

Yes, it is appropriate here to use the non-relocated protobuf stuff --i.e. as you have it -- while auth goes via Coprocessor API.

* @return the authentication token instance, wrapped by a {@link CompletableFuture}.
*/
@InterfaceAudience.Private
public static CompletableFuture<Token<AuthenticationTokenIdentifier>> obtainToken(

This comment has been minimized.

Copy link
@saintstack

saintstack Sep 16, 2019

Contributor

This is public so the TokenUtil on server can use this method? Can it be package private given both TokenUtil and this class are in the same java package? Then you could drop the IA Private.

This comment has been minimized.

Copy link
@saintstack

saintstack Sep 16, 2019

Contributor

Hmmm... but seems like you want these to be public now? You are pointing users of TokenUtil here?

This comment has been minimized.

Copy link
@srdo

srdo Sep 16, 2019

Author Contributor

Yes, this is public so TokenUtil can delegate to this method, but also so any internal HBase code that needs this method can use it. The TokenUtil methods have been deprecated, so new internal HBase code would ideally use ClientTokenUtil instead.

If there isn't a need for these methods elsewhere in HBase, I'm happy to try making them package private.

The Javadoc on the deprecated methods in TokenUtil explicitly says not to use these methods when you are developing non-HBase code. The only users I want to point to ClientTokenUtil (except obtainAndCacheToken) are internal HBase users.

This comment has been minimized.

Copy link
@srdo

srdo Sep 16, 2019

Author Contributor

I'm also happy to update any call sites in HBase so they use the ClientTokenUtil methods instead of the now deprecated TokenUtil methods.

This comment has been minimized.

Copy link
@saintstack

saintstack Sep 16, 2019

Contributor

The audience annotations are for downstreamers, not for hbase internally.

Given ClientTokenUtil is a new class, we have opportunity for setting access as we see fit.

The #toToken methods are used internal to the package only it seems (tests and the class-itself). Suggest these become package private or private especially the overrides that take protobufs.

Otherwise, methods seem innocuous-looking. The less API we make public, the better otherwise, make a call.

Regards changing internal usage, could do here or in a follow-on.

Thanks for persisting on this.

This comment has been minimized.

Copy link
@srdo

srdo Sep 17, 2019

Author Contributor

Only obtainToken(AsyncConnection) seems to need to be public, as it is used by SecureBulkLoadManager. Everything else can be package private. Updated the PR to make the methods package private, as well as to get rid of uses of the deprecated TokenUtil methods.

This comment has been minimized.

Copy link
@srdo

srdo Sep 18, 2019

Author Contributor

Replaced the use of reflection in TestClientTokenUtil with just calling the obtainToken methods directly. The existing code doesn't find package private methods, causing the test to fail. I grepped for the method names, and they don't seem to be used via reflection anywhere else in HBase.

* @return the authentication token instance
*/
@InterfaceAudience.Private
public static Token<AuthenticationTokenIdentifier> obtainToken(

This comment has been minimized.

Copy link
@saintstack

saintstack Sep 16, 2019

Contributor

ditto

This comment has been minimized.

Copy link
@saintstack

saintstack Sep 16, 2019

Contributor

Yeah, looks like used by test only and the tests are in same package.

…hods. Make methods that don't need to be public package-private
@Apache-HBase

This comment has been minimized.

Copy link

commented Sep 17, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 35s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ master Compile Tests _
💙 mvndep 0m 36s Maven dependency ordering for branch
💚 mvninstall 5m 18s master passed
💚 compile 1m 21s master passed
💚 checkstyle 1m 50s master passed
💚 shadedjars 4m 28s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 1m 2s master passed
💙 spotbugs 4m 4s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 5m 9s master passed
_ Patch Compile Tests _
💙 mvndep 0m 15s Maven dependency ordering for patch
💚 mvninstall 4m 58s the patch passed
💚 compile 1m 20s the patch passed
💚 javac 1m 20s the patch passed
💚 checkstyle 1m 48s the patch passed
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 4m 36s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 15m 28s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚 javadoc 0m 58s the patch passed
💚 findbugs 5m 23s the patch passed
_ Other Tests _
💔 unit 1m 39s hbase-client in the patch failed.
💚 unit 160m 49s hbase-server in the patch passed.
💚 asflicense 1m 5s The patch does not generate ASF License warnings.
225m 24s
Reason Tests
Failed junit tests hadoop.hbase.security.token.TestClientTokenUtil
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/153/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 10a411869ed2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / cb62f73
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/153/artifact/out/patch-unit-hbase-client.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/153/testReport/
Max. process+thread count 4610 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/153/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment has been minimized.

Copy link

commented Sep 18, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 29s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ master Compile Tests _
💙 mvndep 0m 35s Maven dependency ordering for branch
💚 mvninstall 5m 43s master passed
💚 compile 1m 22s master passed
💚 checkstyle 2m 3s master passed
💚 shadedjars 5m 16s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 1m 6s master passed
💙 spotbugs 4m 24s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 5m 40s master passed
_ Patch Compile Tests _
💙 mvndep 0m 13s Maven dependency ordering for patch
💚 mvninstall 5m 33s the patch passed
💚 compile 1m 26s the patch passed
💚 javac 1m 26s the patch passed
💔 checkstyle 0m 35s hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 5m 1s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 16m 58s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚 javadoc 0m 57s the patch passed
💚 findbugs 5m 48s the patch passed
_ Other Tests _
💚 unit 1m 49s hbase-client in the patch passed.
💚 unit 156m 57s hbase-server in the patch passed.
💚 asflicense 0m 47s The patch does not generate ASF License warnings.
226m 47s
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/154/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 4580648ed206 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / cb62f73
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/154/artifact/out/diff-checkstyle-hbase-client.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/154/testReport/
Max. process+thread count 4496 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/154/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@srdo srdo force-pushed the srdo:HBASE-22027 branch from 1373e11 to facfe8a Sep 18, 2019
@Apache-HBase

This comment has been minimized.

Copy link

commented Sep 18, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 1m 17s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ master Compile Tests _
💙 mvndep 0m 33s Maven dependency ordering for branch
💚 mvninstall 5m 47s master passed
💚 compile 1m 25s master passed
💚 checkstyle 2m 6s master passed
💚 shadedjars 5m 4s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 1m 1s master passed
💙 spotbugs 4m 28s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 5m 39s master passed
_ Patch Compile Tests _
💙 mvndep 0m 15s Maven dependency ordering for patch
💚 mvninstall 5m 26s the patch passed
💚 compile 1m 25s the patch passed
💚 javac 1m 25s the patch passed
💚 checkstyle 2m 0s the patch passed
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 5m 1s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 17m 25s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚 javadoc 0m 55s the patch passed
💚 findbugs 6m 17s the patch passed
_ Other Tests _
💚 unit 1m 55s hbase-client in the patch passed.
💔 unit 271m 13s hbase-server in the patch failed.
💚 asflicense 0m 52s The patch does not generate ASF License warnings.
342m 44s
Reason Tests
Failed junit tests hadoop.hbase.client.TestAsyncTableAdminApi
hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.master.TestMasterShutdown
Subsystem Report/Notes
Docker Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/155/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 8633bba476a7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / ab076b0
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/155/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/155/testReport/
Max. process+thread count 4812 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/155/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

This comment has been minimized.

Copy link

commented Sep 19, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 45s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ master Compile Tests _
💙 mvndep 0m 39s Maven dependency ordering for branch
💚 mvninstall 7m 1s master passed
💚 compile 1m 37s master passed
💚 checkstyle 2m 15s master passed
💚 shadedjars 5m 58s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 1m 16s master passed
💙 spotbugs 5m 2s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 6m 21s master passed
_ Patch Compile Tests _
💙 mvndep 0m 16s Maven dependency ordering for patch
💚 mvninstall 6m 27s the patch passed
💚 compile 1m 35s the patch passed
💚 javac 1m 35s the patch passed
💚 checkstyle 2m 17s the patch passed
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 5m 46s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 20m 0s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚 javadoc 1m 12s the patch passed
💚 findbugs 6m 39s the patch passed
_ Other Tests _
💚 unit 2m 2s hbase-client in the patch passed.
💚 unit 157m 44s hbase-server in the patch passed.
💚 asflicense 1m 44s The patch does not generate ASF License warnings.
240m 0s
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/1/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 102d9c34f74e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / a0e8723
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/1/testReport/
Max. process+thread count 5160 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

left a comment

Very nice.

@busbey Will commit in next day or so. Take a looksee if you get a chance.


@ClassRule
public static final HBaseClassTestRule CLASS_RULE =
HBaseClassTestRule.forClass(TestTokenUtil.class);
HBaseClassTestRule.forClass(TestClientTokenUtil.class);

This comment has been minimized.

Copy link
@saintstack

saintstack Sep 19, 2019

Contributor

nit spacing

@busbey
busbey approved these changes Sep 19, 2019
@saintstack saintstack merged commit 0ec0a94 into apache:master Sep 19, 2019
@Apache-HBase

This comment has been minimized.

Copy link

commented Sep 19, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 36s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ master Compile Tests _
💙 mvndep 0m 35s Maven dependency ordering for branch
💚 mvninstall 5m 21s master passed
💚 compile 1m 27s master passed
💚 checkstyle 1m 56s master passed
💚 shadedjars 4m 52s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 1m 2s master passed
💙 spotbugs 4m 17s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 5m 26s master passed
_ Patch Compile Tests _
💙 mvndep 0m 15s Maven dependency ordering for patch
💚 mvninstall 5m 3s the patch passed
💚 compile 1m 24s the patch passed
💚 javac 1m 24s the patch passed
💚 checkstyle 1m 51s the patch passed
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 4m 43s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 17m 18s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚 javadoc 1m 5s the patch passed
💚 findbugs 6m 22s the patch passed
_ Other Tests _
💚 unit 1m 58s hbase-client in the patch passed.
💚 unit 165m 40s hbase-server in the patch passed.
💚 asflicense 1m 2s The patch does not generate ASF License warnings.
236m 8s
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/2/artifact/out/Dockerfile
GITHUB PR #361
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 7c01b08952c7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
git revision master / 1fec3d1
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/2/testReport/
Max. process+thread count 4486 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

srdo added a commit to srdo/hbase that referenced this pull request Sep 20, 2019
apache#361)

* HBase-22027: Split non-MR related parts of TokenUtil off into a ClientTokenUtil, and move ClientTokenUtil to hbase-client

* Replace uses of deprecated TokenUtil methods with ClientTokenUtil methods. Make methods that don't need to be public package-private

* Don't use reflection where not necessary in TestClientTokenUtil

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: stack <stack@apache.org>
@srdo srdo referenced this pull request Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.