HBASE-22758 Remove the unneccesary info cf deletion in DeleteTableProcedure#deleteFromMeta #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openinx
requested review from
apurtell,
Apache9 and
saintstack
and removed request for
apurtell
|
💔 -1 overall
This message was automatically generated. |
Apache9
requested changes
Jul 28, 2019
| @@ -1819,7 +1819,8 @@ private static void updateLocation(Connection connection, RegionInfo regionInfo, | |||
| * @param regionInfo region to be deleted from META | |||
| * @throws IOException | |||
| */ | |||
| public static void deleteRegion(Connection connection, RegionInfo regionInfo) throws IOException { | |||
| public static void deleteRegionInfo(Connection connection, RegionInfo regionInfo) | |||
There was a problem hiding this comment.
Why change the method name?
There was a problem hiding this comment.
Because the method only delete the info column family (will keep other cf), so name it deleteRegionInfo will be better.
| @@ -1832,16 +1833,17 @@ public static void deleteRegion(Connection connection, RegionInfo regionInfo) th | |||
| * @param connection connection we're using | |||
| * @param regionsInfo list of regions to be deleted from META | |||
| */ | |||
| public static void deleteRegions(Connection connection, List<RegionInfo> regionsInfo) | |||
| public static void deleteRegionsInfo(Connection connection, List<RegionInfo> regionsInfo) | |||
There was a problem hiding this comment.
And this should be deleteRegionInfos?
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
saintstack
approved these changes
Jul 29, 2019
|
💔 -1 overall
This message was automatically generated. |
|
OK, the new introduced TestCatalogJanitorCluster is depending on the deleteRegions now, it will broke the compiling. Let me update the patch. |
…cedure#deleteFromMeta
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
…cedure#deleteFromMeta (apache#424)
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…cedure#deleteFromMeta (apache#424) (cherry picked from commit 09751f6) Change-Id: I2a9eb0f89c018d66e70dd5d3904c848b53cb6e3f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.