Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-23155 May NPE when concurrent AsyncNonMetaRegionLocator#updateC… #718

Merged
merged 1 commit into from Oct 15, 2019
Merged

HBASE-23155 May NPE when concurrent AsyncNonMetaRegionLocator#updateC… #718

merged 1 commit into from Oct 15, 2019

Conversation

infraio
Copy link
Contributor

@infraio infraio commented Oct 12, 2019

…achedLocationOnError

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 2m 1s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 1s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
💙 mvndep 0m 45s Maven dependency ordering for branch
💚 mvninstall 8m 16s master passed
💚 compile 1m 46s master passed
💚 checkstyle 2m 16s master passed
💚 shadedjars 6m 6s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 1m 11s master passed
💙 spotbugs 5m 28s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 6m 44s master passed
_ Patch Compile Tests _
💙 mvndep 0m 15s Maven dependency ordering for patch
💚 mvninstall 7m 2s the patch passed
💚 compile 1m 42s the patch passed
💚 javac 1m 42s the patch passed
💚 checkstyle 2m 15s the patch passed
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 5m 45s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 23m 22s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚 javadoc 1m 20s the patch passed
💚 findbugs 7m 13s the patch passed
_ Other Tests _
💚 unit 2m 4s hbase-client in the patch passed.
💔 unit 256m 53s hbase-server in the patch failed.
💚 asflicense 0m 48s The patch does not generate ASF License warnings.
347m 19s
Reason Tests
Failed junit tests hadoop.hbase.master.TestMasterShutdown
Subsystem Report/Notes
Docker Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-718/1/artifact/out/Dockerfile
GITHUB PR #718
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux b5e574ab8ad9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-718/out/precommit/personality/provided.sh
git revision master / 5848e14
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-718/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-718/1/testReport/
Max. process+thread count 4495 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-718/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

saintstack
saintstack approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Question on the test.

hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncNonMetaRegionLocator.java
HRegionLocation loc =
getDefaultRegionLocation(TABLE_NAME, EMPTY_START_ROW, RegionLocateType.CURRENT, false)
.get();
IntStream.range(0, 100).parallel()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If single-region table, will this produce a null RegionLocation? Should there be something going on in the background clearing tableCache?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updateCachedLocationOnError will produce a null RegionLocation.

Apache9
Apache9 approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@guangxuCheng
Copy link
Member

LGTM +1

@infraio infraio merged commit 7924ba3 into apache:master Oct 15, 2019
infraio added a commit that referenced this pull request Oct 15, 2019
@infraio
HBASE-23155 May NPE when concurrent AsyncNonMetaRegionLocator#updateC…
18ff188 
…achedLocationOnError (#718)
asfgit pushed a commit that referenced this pull request Oct 15, 2019
@infraio
HBASE-23155 May NPE when concurrent AsyncNonMetaRegionLocator#updateC…
9b0980f 
…achedLocationOnError (#718)
asfgit pushed a commit that referenced this pull request Oct 15, 2019
@infraio
HBASE-23155 May NPE when concurrent AsyncNonMetaRegionLocator#updateC…
ff63bca 
…achedLocationOnError (#718)
infraio added a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@infraio
HBASE-23155 May NPE when concurrent AsyncNonMetaRegionLocator#updateC…
8c7ae33 
…achedLocationOnError (apache#718)
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@infraio
HBASE-23155 May NPE when concurrent AsyncNonMetaRegionLocator#updateC…
2e6ca9d 
…achedLocationOnError (apache#718)

(cherry picked from commit 9b0980f)

Change-Id: I535a1d57881e3fa8f11546b938188fa2ae475aec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintstack saintstack saintstack approved these changes

@Apache9 Apache9 Apache9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@infraio @Apache-HBase @guangxuCheng @saintstack @Apache9