diff --git a/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java b/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java index 9d1b03e18eba..2a97668e0f97 100644 --- a/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java +++ b/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java @@ -26,6 +26,7 @@ import java.util.List; import java.util.Map; import java.util.Set; +import java.util.SortedSet; import java.util.concurrent.Future; import java.util.stream.Collectors; import org.apache.commons.lang3.StringUtils; @@ -47,7 +48,6 @@ import org.apache.hadoop.hbase.master.RegionState; import org.apache.hadoop.hbase.master.ServerManager; import org.apache.hadoop.hbase.master.TableStateManager; -import org.apache.hadoop.hbase.master.assignment.AssignmentManager; import org.apache.hadoop.hbase.master.assignment.RegionStateNode; import org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait; import org.apache.hadoop.hbase.net.Address; @@ -532,8 +532,7 @@ public BalanceResponse balanceRSGroup(String groupName, BalanceRequest request) Map groupRIT = rsGroupGetRegionsInTransition(groupName); if (groupRIT.size() > 0 && !request.isIgnoreRegionsInTransition()) { LOG.debug("Not running balancer because {} region(s) in transition: {}", groupRIT.size(), - StringUtils.abbreviate( - master.getAssignmentManager().getRegionStates().getRegionsInTransition().toString(), + StringUtils.abbreviate(master.getAssignmentManager().getRegionsInTransition().toString(), 256)); return responseBuilder.build(); } @@ -654,14 +653,12 @@ public void updateConfiguration(String groupName) throws IOException { private Map rsGroupGetRegionsInTransition(String groupName) throws IOException { + SortedSet tablesInGroup = getRSGroupInfo(groupName).getTables(); Map rit = Maps.newTreeMap(); - AssignmentManager am = master.getAssignmentManager(); - for (TableName tableName : getRSGroupInfo(groupName).getTables()) { - for (RegionInfo regionInfo : am.getRegionStates().getRegionsOfTable(tableName)) { - RegionState state = am.getRegionStates().getRegionTransitionState(regionInfo); - if (state != null) { - rit.put(regionInfo.getEncodedName(), state); - } + for (RegionStateNode regionNode : master.getAssignmentManager().getRegionsInTransition()) { + TableName tn = regionNode.getTable(); + if (tablesInGroup.contains(tn)) { + rit.put(regionNode.getRegionInfo().getEncodedName(), regionNode.toRegionState()); } } return rit; diff --git a/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsOfflineMode.java b/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsOfflineMode.java index 452fd63d3c88..0d1810101a38 100644 --- a/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsOfflineMode.java +++ b/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsOfflineMode.java @@ -138,7 +138,7 @@ public boolean evaluate() throws Exception { @Override public boolean evaluate() throws Exception { return groupRS.getNumberOfOnlineRegions() < 1 - && master.getAssignmentManager().getRegionStates().getRegionsInTransitionCount() < 1; + && master.getAssignmentManager().getRegionsInTransitionCount() < 1; } }); // Move table to group and wait. diff --git a/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/AssignmentManagerStatusTmpl.jamon b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/AssignmentManagerStatusTmpl.jamon index ee899a7340dc..8a7ca8baf7d4 100644 --- a/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/AssignmentManagerStatusTmpl.jamon +++ b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/AssignmentManagerStatusTmpl.jamon @@ -40,8 +40,7 @@ int limit = 100; <%java> -SortedSet rit = assignmentManager.getRegionStates() - .getRegionsInTransitionOrderedByTimestamp(); +SortedSet rit = assignmentManager.getRegionsStateInTransition(); <%if !rit.isEmpty() %> diff --git a/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon index d1b3f8719d2e..d305ca6239fb 100644 --- a/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon +++ b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon @@ -736,7 +736,7 @@ AssignmentManager assignmentManager = master.getAssignmentManager(); <% deadServerName %> - <% deadServerUtil.getTimeOfDeath(deadServerName) %> + <% new Date(deadServerUtil.getTimeOfDeath(deadServerName)) %> <%if rsGroupName != null %> <% rsGroupName %> diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/DeadServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/DeadServer.java index 84d660e66ee6..d85a040c4894 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/DeadServer.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/DeadServer.java @@ -19,7 +19,6 @@ import java.util.ArrayList; import java.util.Collections; -import java.util.Date; import java.util.HashMap; import java.util.HashSet; import java.util.Iterator; @@ -115,6 +114,10 @@ public synchronized void finish(ServerName sn) { } } + synchronized void putIfAbsent(ServerName sn, long crashedTime) { + this.deadServers.putIfAbsent(sn, crashedTime); + } + public synchronized int size() { return deadServers.size(); } @@ -209,9 +212,9 @@ synchronized List> copyDeadServersSince(long ts) { * @param deadServerName the dead server name * @return the date when the server died */ - public synchronized Date getTimeOfDeath(final ServerName deadServerName) { + public synchronized long getTimeOfDeath(final ServerName deadServerName) { Long time = deadServers.get(deadServerName); - return time == null ? null : new Date(time); + return time == null ? 0 : time; } /** diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java index 35f212b44597..f2a9ea69cee2 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java @@ -1001,6 +1001,14 @@ private void finishActiveMasterInitialization() throws IOException, InterruptedE Map, List>> procsByType = procedureExecutor .getActiveProceduresNoCopy().stream().collect(Collectors.groupingBy(p -> p.getClass())); + // This manager will be started AFTER hbase:meta is confirmed on line and must be initialised + // before assignment manager + // hbase.mirror.table.state.to.zookeeper is so hbase1 clients can connect. They read table + // state from zookeeper while hbase2 reads it from hbase:meta. Disable if no hbase1 clients. + this.tableStateManager = + this.conf.getBoolean(MirroringTableStateManager.MIRROR_TABLE_STATE_TO_ZK_KEY, true) + ? new MirroringTableStateManager(this) + : new TableStateManager(this); // Create Assignment Manager this.assignmentManager = createAssignmentManager(this, masterRegion); this.assignmentManager.start(); @@ -1020,16 +1028,10 @@ private void finishActiveMasterInitialization() throws IOException, InterruptedE // TODO: Generate the splitting and live Set in one pass instead of two as we currently do. this.regionServerTracker.upgrade( procsByType.getOrDefault(ServerCrashProcedure.class, Collections.emptyList()).stream() - .map(p -> (ServerCrashProcedure) p).map(p -> p.getServerName()).collect(Collectors.toSet()), + .map(p -> (ServerCrashProcedure) p).collect( + Collectors.toMap(ServerCrashProcedure::getServerName, Procedure::getSubmittedTime)), Sets.union(rsListStorage.getAll(), walManager.getLiveServersFromWALDir()), walManager.getSplittingServersFromWALDir()); - // This manager will be started AFTER hbase:meta is confirmed on line. - // hbase.mirror.table.state.to.zookeeper is so hbase1 clients can connect. They read table - // state from zookeeper while hbase2 reads it from hbase:meta. Disable if no hbase1 clients. - this.tableStateManager = - this.conf.getBoolean(MirroringTableStateManager.MIRROR_TABLE_STATE_TO_ZK_KEY, true) - ? new MirroringTableStateManager(this) - : new TableStateManager(this); startupTaskGroup.addTask("Initializing ZK system trackers"); initializeZKBasedSystemTrackers(); @@ -1944,7 +1946,7 @@ private void balanceThrottling(long nextBalanceStartTime, int maxRegionsInTransi // But if there are zero regions in transition, it can skip sleep to speed up. while ( !interrupted && EnvironmentEdgeManager.currentTime() < nextBalanceStartTime - && this.assignmentManager.getRegionStates().hasRegionsInTransition() + && this.assignmentManager.getRegionTransitScheduledCount() > 0 ) { try { Thread.sleep(100); @@ -1956,8 +1958,7 @@ private void balanceThrottling(long nextBalanceStartTime, int maxRegionsInTransi // Throttling by max number regions in transition while ( !interrupted && maxRegionsInTransition > 0 - && this.assignmentManager.getRegionStates().getRegionsInTransitionCount() - >= maxRegionsInTransition + && this.assignmentManager.getRegionTransitScheduledCount() >= maxRegionsInTransition && EnvironmentEdgeManager.currentTime() <= cutoffTime ) { try { @@ -2036,7 +2037,7 @@ public BalanceResponse balance(BalanceRequest request) throws IOException { synchronized (this.balancer) { // Only allow one balance run at at time. - if (this.assignmentManager.hasRegionsInTransition()) { + if (this.assignmentManager.getRegionTransitScheduledCount() > 0) { List regionsInTransition = assignmentManager.getRegionsInTransition(); // if hbase:meta region is in transition, result of assignment cannot be recorded // ignore the force flag in that case @@ -2051,7 +2052,8 @@ public BalanceResponse balance(BalanceRequest request) throws IOException { if (!request.isIgnoreRegionsInTransition() || metaInTransition) { LOG.info("Not running balancer (ignoreRIT=false" + ", metaRIT=" + metaInTransition - + ") because " + regionsInTransition.size() + " region(s) in transition: " + toPrint + + ") because " + assignmentManager.getRegionTransitScheduledCount() + + " region(s) are scheduled to transit " + toPrint + (truncated ? "(truncated list)" : "")); return responseBuilder.build(); } @@ -2188,7 +2190,7 @@ public boolean normalizeRegions(final NormalizeTableFilterParams ntfp, if (skipRegionManagementAction("region normalizer")) { return false; } - if (assignmentManager.hasRegionsInTransition()) { + if (assignmentManager.getRegionTransitScheduledCount() > 0) { return false; } @@ -3012,7 +3014,7 @@ public ClusterMetrics getClusterMetricsWithoutCoprocessor(EnumSet