From ec8d57577b85f2fd9ee3d0a47760da8b169a25d5 Mon Sep 17 00:00:00 2001
From: Kevin Geiszler <kevin.j.geiszler@gmail.com>
Date: Wed, 19 Nov 2025 19:20:44 -0800
Subject: [PATCH 1/2] Skip all foreign tables when collecting metrics

Change-Id: I976431d363df438c95feaa2c0d5cc23028858947
---
 .../apache/hadoop/hbase/master/HMaster.java   |  8 +--
 .../hbase/master/TestMasterMetrics.java       | 66 +++++++++++++++++++
 2 files changed, 69 insertions(+), 5 deletions(-)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
index f849a19a2511..6fdcbb9861b3 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
@@ -3117,13 +3117,11 @@ public ClusterMetrics getClusterMetricsWithoutCoprocessor(EnumSet<Option> option
             try {
               Map<TableName, RegionStatesCount> tableRegionStatesCountMap = new HashMap<>();
               Map<String, TableDescriptor> tableDescriptorMap = getTableDescriptors().getAll();
+              List<TableName> tableNames = listTableNames(null, null, true);
               for (TableDescriptor tableDescriptor : tableDescriptorMap.values()) {
                 TableName tableName = tableDescriptor.getTableName();
-                if (
-                  tableName.isSystemTable() && tableName.getQualifierAsString().startsWith("meta")
-                    && !tableName.equals(TableName.META_TABLE_NAME)
-                ) {
-                  LOG.info("Skipping foreign meta table {} in cluster metrics", tableName);
+                if (!tableNames.contains(tableName)) {
+                  LOG.info("Skipping foreign table {} in cluster metrics", tableName);
                   continue;
                 }
                 RegionStatesCount regionStatesCount =
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterMetrics.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterMetrics.java
index 07dacf6f35cb..e594b5fb65b0 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterMetrics.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterMetrics.java
@@ -22,14 +22,17 @@
 
 import java.io.IOException;
 import java.io.UncheckedIOException;
+import java.util.ArrayList;
 import java.util.EnumSet;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.hbase.ClusterMetrics;
 import org.apache.hadoop.hbase.CompatibilityFactory;
 import org.apache.hadoop.hbase.HBaseClassTestRule;
 import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
 import org.apache.hadoop.hbase.ServerMetricsBuilder;
 import org.apache.hadoop.hbase.ServerName;
 import org.apache.hadoop.hbase.SingleProcessHBaseCluster;
@@ -225,4 +228,67 @@ public void testClusterMetricsMetaTableSkipping() throws Exception {
       master.getTableDescriptors().remove(replicaMetaTable);
     }
   }
+
+  @Test
+  public void testClusterMetricsForeignTableSkipping() throws Exception {
+    List<TableName> allTables = new ArrayList<>();
+
+    // These tables, including the cluster's meta table, should not be foreign to the cluster.
+    // The cluster should be able to find their state.
+    allTables.add(TableName.META_TABLE_NAME);
+    List<TableName> familiarTables = new ArrayList<>();
+    familiarTables.add(TableName.valueOf(null, "familiarTable1"));
+    familiarTables.add(TableName.valueOf("", "familiarTable2"));
+    familiarTables.add(TableName.valueOf("default", "familiarTable3"));
+    familiarTables.add(TableName.valueOf("familiarNamespace", "familiarTable4"));
+    familiarTables.add(TableName.valueOf("familiarNamespace", "familiarTable5"));
+
+    // Create these "familiar" tables so their state can be found
+    TEST_UTIL.getAdmin().createNamespace(NamespaceDescriptor.create("familiarNamespace").build());
+    for (TableName familiarTable : familiarTables) {
+      TEST_UTIL.createTable(familiarTable, "cf");
+      allTables.add(familiarTable);
+    }
+
+    // These tables should be foreign to the cluster.
+    // The cluster should not be able to find their state.
+    allTables.add(TableName.valueOf("hbase", "meta_replica"));
+    allTables.add(TableName.valueOf(null, "defaultNamespaceTable1"));
+    allTables.add(TableName.valueOf("", "defaultNamespaceTable2"));
+    allTables.add(TableName.valueOf("default", "defaultNamespaceTable3"));
+    allTables.add(TableName.valueOf("customNamespace", "customNamespaceTable1"));
+    allTables.add(TableName.valueOf("customNamespace", "customNamespaceTable2"));
+    allTables.add(TableName.valueOf("anotherNamespace", "anotherNamespaceTable"));
+    allTables.add(TableName.valueOf("sharedNamespace", "sharedNamespaceTable1"));
+    allTables.add(TableName.valueOf("sharedNamespace", "sharedNamespaceTable2"));
+
+    // Update master's table descriptors to have all tables
+    TableDescriptor foreignTableDescriptor;
+    for (TableName tableName : allTables) {
+      foreignTableDescriptor = TableDescriptorBuilder.newBuilder(tableName)
+        .setColumnFamily(ColumnFamilyDescriptorBuilder.of("cf")).build();
+      master.getTableDescriptors().update(foreignTableDescriptor, true);
+    }
+
+    // The state of the meta table and the familiar tables we created should exist.
+    // The other tables' state should not exist.
+    for (TableName tableName : allTables) {
+      try {
+        ClusterMetrics metrics = master.getClusterMetricsWithoutCoprocessor(
+          EnumSet.of(ClusterMetrics.Option.TABLE_TO_REGIONS_COUNT));
+        Map<TableName, RegionStatesCount> tableRegionStatesCount =
+          metrics.getTableRegionStatesCount();
+
+        if (tableName.equals(TableName.META_TABLE_NAME) || tableName.getQualifierAsString().startsWith("familiar")) {
+          assertTrue("Expected this table's state to exist: " + tableName,
+            tableRegionStatesCount.containsKey(tableName));
+        } else {
+          assertFalse("This foreign table's state should not exist: " + tableName,
+            tableRegionStatesCount.containsKey(tableName));
+        }
+      } finally {
+        master.getTableDescriptors().remove(tableName);
+      }
+    }
+  }
 }

From 7c9c85a93cb07b487050ce0bca2eba67a58d6bd9 Mon Sep 17 00:00:00 2001
From: Kevin Geiszler <kevin.j.geiszler@gmail.com>
Date: Wed, 19 Nov 2025 19:21:57 -0800
Subject: [PATCH 2/2] Run mvn spotless:apply

Change-Id: I8cebc36512c7f59b437d74dfc376fb49d95bf422
---
 .../org/apache/hadoop/hbase/master/TestMasterMetrics.java    | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterMetrics.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterMetrics.java
index e594b5fb65b0..0f2d1a17634c 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterMetrics.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterMetrics.java
@@ -279,7 +279,10 @@ public void testClusterMetricsForeignTableSkipping() throws Exception {
         Map<TableName, RegionStatesCount> tableRegionStatesCount =
           metrics.getTableRegionStatesCount();
 
-        if (tableName.equals(TableName.META_TABLE_NAME) || tableName.getQualifierAsString().startsWith("familiar")) {
+        if (
+          tableName.equals(TableName.META_TABLE_NAME)
+            || tableName.getQualifierAsString().startsWith("familiar")
+        ) {
           assertTrue("Expected this table's state to exist: " + tableName,
             tableRegionStatesCount.containsKey(tableName));
         } else {