Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Test BestPossibleExternalViewVerifier #1321

Closed
kaisun2000 opened this issue Aug 27, 2020 · 0 comments · Fixed by #1328
Closed

Refactor Test BestPossibleExternalViewVerifier #1321

kaisun2000 opened this issue Aug 27, 2020 · 0 comments · Fixed by #1328

Comments

@kaisun2000
Copy link
Contributor

#526 can be mitigated by adding a fixed waiting (cool down) time period in the verifier. However, we don't want to do it in BestPossibleExternalViewVerifier as this class is used in production code. Thus, we will derive a sub class which would have this cool down.

Also, enhance some logging in BestPossibleExternalViewVerifier
kaisun2000 pushed a commit to kaisun2000/helix that referenced this issue Aug 27, 2020
Implement TestBestPossibleExternalViewVerifier apache#1321
c523d70 
TestBestPossibleExternalViewVerifier would have a default COOL_DOWN period
before verifyByPolling. Due to apache#526, currently we have randow sleep in the
test before verifyByPolling. We intend to use TestBestPossibeVerifier
instead in our unit test.  While keep using BestPossibleExternalViewVerifier
in production code.
@kaisun2000 kaisun2000 mentioned this issue Aug 27, 2020
Merged
4 tasks
kaisun2000 pushed a commit to kaisun2000/helix that referenced this issue Sep 10, 2020
Implement TestBestPossibleExternalViewVerifier apache#1321
50d0da0 
TestBestPossibleExternalViewVerifier would have a default COOL_DOWN period
before verifyByPolling. Due to apache#526, currently we have randow sleep in the
test before verifyByPolling. We intend to use TestBestPossibeVerifier
instead in our unit test.  While keep using BestPossibleExternalViewVerifier
in production code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhance ZkHelixVerifier and its related subclass to take a default wait period kaisun2000/helix
1 participant
@kaisun2000