Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestClusterAccessor test #2767

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Fix TestClusterAccessor test #2767

merged 2 commits into from
Feb 27, 2024

Conversation

junkaixue
Copy link
Contributor

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

closed #2749

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Set comparison in 11 considered the orders. So add an helper function to do this.

Tests

  • The following tests are written for this issue:

  • The following is the result of the "mvn test" command on the appropriate module:
    [INFO] Tests run: 226, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 256.424 s - in TestSuite
    [INFO]
    [INFO] Results:
    [INFO]
    [INFO] Tests run: 226, Failures: 0, Errors: 0, Skipped: 0
    [INFO]
    [INFO]
    [INFO] --- jacoco-maven-plugin:0.8.6:report (generate-code-coverage-report) @ helix-rest ---
    [INFO] Loading execution data file /Users/jxue/helix/helix-rest/target/jacoco.exec
    [INFO] Analyzed bundle 'Apache Helix :: Restful Interface' with 95 classes
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time: 04:22 min
    [INFO] Finished at: 2024-02-26T15:05:04-08:00
    [INFO] ------------------------------------------------------------------------

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@junkaixue junkaixue changed the title Fix TestClusterAccessor Fix TestClusterAccessor test Feb 26, 2024
@junkaixue junkaixue merged commit c0fa6dc into apache:master Feb 27, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failed CI Test] testGetClusters(org.apache.helix.rest.server.TestClusterAccessor)
1 participant