From a222687d991ece7096366ab61ce09428c58d4047 Mon Sep 17 00:00:00 2001
From: zhangbutao <zhangbutao@cmss.chinamobile.com>
Date: Tue, 7 Jun 2022 17:35:17 +0800
Subject: [PATCH] Address review

---
 .../plugin/AuthorizationMetaStoreFilterHook.java            | 6 +++---
 .../authorization/plugin/HivePrivilegeObjectUtils.java      | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/AuthorizationMetaStoreFilterHook.java b/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/AuthorizationMetaStoreFilterHook.java
index 989c5a6270a2..e40297620c20 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/AuthorizationMetaStoreFilterHook.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/AuthorizationMetaStoreFilterHook.java
@@ -49,7 +49,7 @@ public AuthorizationMetaStoreFilterHook(Configuration conf) {
   public List<String> filterTableNames(String catName, String dbName, List<String> tableList)
       throws MetaException {
     List<HivePrivilegeObject> listObjs = getHivePrivObjects(dbName, tableList);
-    return getObjectNames(getFilteredObjects(listObjs));
+    return getFilteredObjectNames(getFilteredObjects(listObjs));
   }
   @Override
   public List<Table> filterTables(List<Table> tableList) throws MetaException {
@@ -98,7 +98,7 @@ private List<String> getDbNames(List<HivePrivilegeObject> filteredObjects) {
     return tnames;
   }
 
-  private List<String> getObjectNames(List<HivePrivilegeObject> filteredObjects) {
+  private List<String> getFilteredObjectNames(List<HivePrivilegeObject> filteredObjects) {
     List<String> tnames = new ArrayList<String>();
     for(HivePrivilegeObject obj : filteredObjects) {
       tnames.add(obj.getObjectName());
@@ -156,7 +156,7 @@ public List<TableMeta> filterTableMetas(String catName,String dbName,List<TableM
   @Override
   public List<String> filterDataConnectors(List<String> dcList) throws MetaException {
     List<HivePrivilegeObject> listObjs = HivePrivilegeObjectUtils.getHivePrivDcObjects(dcList);
-    return getObjectNames(getFilteredObjects(listObjs));
+    return getFilteredObjectNames(getFilteredObjects(listObjs));
   }
 }
 
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeObjectUtils.java b/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeObjectUtils.java
index 437f53d17319..4ab7870e7b36 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeObjectUtils.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeObjectUtils.java
@@ -56,7 +56,7 @@ public static List<HivePrivilegeObject> getHivePrivDbObjects(List<String> dbList
   public static List<HivePrivilegeObject> getHivePrivDcObjects(List<String> dcList) {
     List<HivePrivilegeObject> objs = new ArrayList<HivePrivilegeObject>();
     for (String dcname : dcList) {
-      objs.add(new HivePrivilegeObject(HivePrivilegeObjectType.DATACONNECTOR, dcname, dcname));
+      objs.add(new HivePrivilegeObject(HivePrivilegeObjectType.DATACONNECTOR, null, dcname));
     }
     return objs;