HIVE-24266 #1576
Merged
HIVE-24266 #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I54f414af6b81f3180217f70ac7ac03d2c376324b
pvary
reviewed
Oct 13, 2020
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Oct 13, 2020
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java
Outdated
Show resolved
Hide resolved
Change-Id: I5ba9f0f98d694b99b4a62ee9a322177a2a1c914d
kgyrtkirk
added
tests failed
tests pending
tests passed
and removed
tests pending
tests failed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in HDFS environment if a writer is using hflush to write ORC ACID files during a transaction commit, the results might be seen as missing when reading the table before this file is completely persisted to disk (thus synced)
This is due to hflush not persisting the new buffers to disk, it rather just ensures that new readers can see the new content. This causes the block information to be incomplete, on which BISplitStrategy relies on. Although the side file (_flush_length) tracks the proper end of the file that is being written, this information is neglected in the favour of block information, and we may end up generating a very short split instead of the larger, available length.
When ETLSplitStrategy is used there is not even a try to rely on ACID side file when calculating file length, so that needs to fixed too.
Moreover we might see the newly committed rows not to appear due to OrcTail caching in ETLSplitStrategy. For now I'm just going to recommend turning that cache off to anyone that wants real time row updates to be read in:
set hive.orc.cache.stripe.details.mem.size=0;
..as tweaking with that code would probably open a can of worms..