Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-25665: Checkstyle LGPL files must not be in the release sources/binaries #3063

Merged
merged 3 commits into from Mar 1, 2022

Conversation

pvary
Copy link
Contributor

@pvary pvary commented Mar 1, 2022

What changes were proposed in this pull request?

remove the checkstyle directories from the release binaries

Why are the changes needed?

The checkstyle files were licensed under LGPL

Does this PR introduce any user-facing change?

No

How was this patch tested?

Checked the binaries manually

@kgyrtkirk
Copy link
Member

can't we simply remove these xsl -s from the repo and fix this issue?
if this file is LGPL ; I think we should remove it if possible

@pvary pvary merged commit 4aa4c89 into apache:master Mar 1, 2022
@pvary pvary deleted the HIVE-25665 branch March 1, 2022 22:16
nrg4878 pushed a commit to nrg4878/hive that referenced this pull request Mar 24, 2022
…binaries (Peter Vary reviewed by Zoltan Haindrich) (apache#3063)
DongWei-4 pushed a commit to DongWei-4/hive that referenced this pull request Oct 28, 2022
…binaries (Peter Vary reviewed by Zoltan Haindrich) (apache#3063)
dengzhhu653 pushed a commit to dengzhhu653/hive that referenced this pull request Dec 15, 2022
…binaries (Peter Vary reviewed by Zoltan Haindrich) (apache#3063)
amanraj2520 pushed a commit to amanraj2520/hive that referenced this pull request Apr 7, 2023
…binaries (Peter Vary reviewed by Zoltan Haindrich) (apache#3063)
udaynpusa pushed a commit to mapr/hive that referenced this pull request Jan 30, 2024
…binaries (Peter Vary reviewed by Zoltan Haindrich) (apache#3063)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants