HIVE-25971: Closing the thread pool created for async cache #3078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit a615317)
|
Old PR link with comments for later ref: #3046 |
|
Latest PR LGTM. +1. |
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Oct 28, 2022
) (cherry picked from commit a615317) Co-authored-by: Shailesh Gupta <shilgu@amazon.com>
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
) (cherry picked from commit a615317) Co-authored-by: Shailesh Gupta <shilgu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For branch-2.3 : CR
What changes were proposed in this pull request?
We are closing the cached thread pool which is delaying the tez task jvm shutdown.
The pool is used for loading hash table in case of mapjoin operator.
Why are the changes needed?
Without the change, tez task jvm takes upto 1 min to shutdown.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Monitored the JVM exit time.
2022-02-03 16:47:54,432 [INFO] [main] |util.Debug|: Hook: class org.apache.hadoop.hive.ql.exec.tez.ObjectCache$2 2022-02-03 16:48:04,079 [DEBUG] [Thread-4] |util.ShutdownHookManager|: Completed shutdown in 0.001 seconds; Timeouts: 0 2022-02-03 16:48:04,088 [DEBUG] [Thread-4] |util.ShutdownHookManager|: ShutdownHookManger completed shutdown.2022-02-03 17:04:05,491 [INFO] [main] |util.Debug|: Hook: org.apache.hadoop.hive.ql.exec.tez.ObjectCache$2@67fa5445 2022-02-03 17:04:05,508 [DEBUG] [Thread-4] |util.ShutdownHookManager|: Completed shutdown in 0.014 seconds; Timeouts: 0 2022-02-03 17:04:05,523 [DEBUG] [Thread-4] |util.ShutdownHookManager|: ShutdownHookManger completed shutdown.