Skip to content

HIVE-26227: Add support of catalog related statements for Hive ql - #3288

Merged
deniskuzZ merged 14 commits into
apache:masterfrom
wecharyu:HIVE-26227
Apr 3, 2025
Merged

deniskuzZ merged 14 commits into
apache:masterfrom
wecharyu:HIVE-26227

Conversation

@wecharyu

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Implement the ddl statements related to catalog, the statements can refer to HIVE-26227.

Why are the changes needed?

To support basic ddl operation for catalog through Hive ql.

Does this PR introduce any user-facing change?

Yes, we should add these new statements to DDL Document.

How was this patch tested?

Add a qtest catalog.q, can be test by command:

mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile=catalog.q

@wecharyu

Copy link
Copy Markdown
Contributor Author

@pvary @deniskuzZ: Could you also review this PR?

@boneanxs

Copy link
Copy Markdown

A very great work! it's much easier for us to manage catalogs with DDL.

,catalog.return_ratio
,catalog.return_rank
,catalog.currency_rank
,`catalog`.item

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a backward incompatible change. Could we make the catalog a non-reserved keyword?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, done

@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.

Catalog Name test_cat
Comment Hive test catalog
#### A masked pattern was here ####
Create Time 2025-03-06 17:08:12.000

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create Time should be masked.

https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-3288/6/tests

Error
Client Execution succeeded but contained differences (error code = 1) after executing catalog.q 
119c119
< Create Time 2025-03-06 20:17:53.000    
---
> Create Time 2025-03-06 17:08:12.000

@deniskuzZ

Copy link
Copy Markdown
Member

re-triggered the build

@sonarqubecloud

Copy link
Copy Markdown

@zhangbutao zhangbutao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

Waiting other folks to take another look.

@deniskuzZ deniskuzZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants