HIVE-14514: Cloning writerOptions when creating delete event writers … #3610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
difin
force-pushed
the
write_options_cloning
branch
from
8e4b11c to
127c3a7
Compare
kgyrtkirk
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
difin
force-pushed
the
write_options_cloning
branch
from
127c3a7 to
5e95f40
Compare
kgyrtkirk
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
…in OrcRecordUpdater.
difin
force-pushed
the
write_options_cloning
branch
from
5e95f40 to
9e0f913
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Author
|
Hey @ayushtkn thanks for reviewing! Can you please merge it? I have no write access yet.. |
Member
|
AFAIK, we have to wait 24 hrs after the first approval, so that people in all timezone can have a look. |
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Oct 28, 2022
…in OrcRecordUpdater. (apache#3610). (Dmitriy Fingerman, reviewed by Ayush Saxena)
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
…in OrcRecordUpdater. (apache#3610). (Dmitriy Fingerman, reviewed by Ayush Saxena)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in OrcRecordUpdater.
What changes were proposed in this pull request?
When split-update is enabled for ACID, OrcRecordUpdater creates two sets of writers: one for the insert deltas and one for the delete deltas. The deleteEventWriter is initialized with similar writerOptions as the normal writer, except that it has a different callback handler. Previously, when creating deleteWriterOptions it was needed to instantiate a new writer options similar to regular writer due to lack of clone method in WriterOptions class in Orc code. Now Orc WriterOptions class implements Cloneable and deleteWriterOptions can be instantiated by cloning the regular writer options.
Why are the changes needed?
Improving code quality.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests and integration tests.