HIVE-26631: Remove unused variable requestTimeout and beBackoffSlotLength in the initServer method of the ThriftBinaryCLIService class #3672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngth in the initServer method of the ThriftBinaryCLIService class
|
Kudos, SonarCloud Quality Gate passed!
|
|
@ayushtkn I was wondering if you got the chance to read my PR？I will thank you very much！ |
zabetak
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
LGTM. @xiuzhu9527 can you please check which commit/JIRA ticket made these variables unused and if it was intentional? Then add this information and the respective links under the current ticket.
zabetak
requested changes
Oct 27, 2022
|
@zabetak I don't think the variables unused are intentional. In thrift issuse（https://issues.apache.org/jira/browse/THRIFT-5297 ），the parameters requestTimeout and beBackoffSlotLength are removed, because it adds a lot of complexity to the code and doesn't make a whole lot of sense. |
zabetak
approved these changes
Nov 16, 2022
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
…exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis) Closes apache#3672
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Dec 29, 2022
…exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis) Closes apache#3672 (cherry picked from commit ae0cabf)
InvisibleProgrammer
pushed a commit
to InvisibleProgrammer/hive
that referenced
this pull request
Jul 13, 2023
Comment out classes to work on to be able to build the module Refator TestCopyUtils.java Before refactor: TestReplDumpTask Refactor TestReplDumpTask.java Before refactor: TestAtlasLoadTask Refactor TestAtlasLoadTask.java Refator TestRangerDumpTask.java Before refactor: TestCompactionHeartbeatService Refactor TestCompactionHeartbeatService.java Before refactor: TestRetryable Refactor TestRetryable.java Before refactor: TestRangerLoadTask Refactor: RangerLoadTask Before refactor: TestAtlasDumpTask Refactor: AtlasDumpTask Before refactor: TestPrimaryToReplicaResourceFunction Refactor TestPrimaryToReplicaResourceFunction Before refactor: TestExportService Refactor: TestExportService HIVE-26522: Added test for HIVE-22033 regarding delegation token renewal (apache#3585) HIVE-26676: Count distinct in subquery returning wrong results (Steve Carlin, reviewed by Alessandro Solimando, Aman Sinha, Krisztian Kasa) HIVE-26736: Authorization failure for nested Views having WITH clause. (apache#3760). (Ayush Saxena, reviewed by Denys Kuzmenko) HIVE-26628: Iceberg table is created when running explain ctas command (Krisztian Kasa, reviewed by Denys Kuzmenko) HIVE-26734: Iceberg: Add an option to allow positional delete files without actual row data. (apache#3758). (Ayush Saxena, reviewed by Adam Szita, Denys Kuzmenko) HIVE-26524: Use Calcite to remove sections of a query plan known never produces rows - ADDENDUM (Krisztian Kasa, reviewed by Stamatis Zampetakis) HIVE-26740: HS2 makes direct connections to HMS backend DB due to Compaction/StatsUpdater (apache#3765) (Adam Szita, reviewed by Zhihua Deng) HIVE-26631: Remove unused Thrift config parameters login.timeout and exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis) Closes apache#3672 HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) ADDENDUM HIVE-26745: HPL unable to handle Decimal or null values in hplsql mode (apache#3769) (Adam Szita, reviewed by Attila Magyar and Denys Kuzmenko) HIVE-26722: HiveFilterSetOpTransposeRule incorrectly prunes UNION ALL operands. (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa) HIVE-26746: Request tracking: change to X-Request-ID header (apache#3770) (Laszlo Bodor reviewed by Zhihua Deng) HIVE-26624: Set repl.background.enable on target after failover completion (Vinit Patni, reviewed by László Pintér, Teddy Choi) Co-authored-by: vpatni <vpatni@cloudera.com> HIVE-26712: HCatMapReduceTest writes test files in project base directory instead of build directory. (apache#3738) (Chris Nauroth reviewed by Ayush Saxena) HIVE-26726: Tinyint column with windowing fn crashes at runtime (Steve Carlin, reviewed by Aman Sinha, Krisztian Kasa) HIVE-26680: Make CMV use Direct Insert Semantics (Sourabh Badhya, reviewed by Denys Kuzmenko, Laszlo Vegh) Closes apache#3715 HIVE-26243: Add vectorized implementation of the 'ds_kll_sketch' UDAF (Alessandro Solimando, reviewed by Denys Kuzmenko, Zoltan Haindrich) Closes apache#3317 HIVE-26761: Add result sorting to complex_alias.q (apache#3783) (Balazs Cseh reviewed by Laszlo Bodor) HIVE-26759: Update SHOW COMPACTIONS query to support Postgres HMS (Akshat Mathur, reviewed by Denys Kuzmenko, Zsolt Miskolczi) Closes 3782 HIVE-26765: Hive Ranger URL policy for insert overwrite directory denies access when fully qualified paths are passed (apache#3790) (Simhadri Govindappa, reviewed by Adam Szita) Small refactors Fix bug
InvisibleProgrammer
pushed a commit
to InvisibleProgrammer/hive
that referenced
this pull request
Jul 13, 2023
Comment out classes to work on to be able to build the module Refator TestCopyUtils.java Before refactor: TestReplDumpTask Refactor TestReplDumpTask.java Before refactor: TestAtlasLoadTask Refactor TestAtlasLoadTask.java Refator TestRangerDumpTask.java Before refactor: TestCompactionHeartbeatService Refactor TestCompactionHeartbeatService.java Before refactor: TestRetryable Refactor TestRetryable.java Before refactor: TestRangerLoadTask Refactor: RangerLoadTask Before refactor: TestAtlasDumpTask Refactor: AtlasDumpTask Before refactor: TestPrimaryToReplicaResourceFunction Refactor TestPrimaryToReplicaResourceFunction Before refactor: TestExportService Refactor: TestExportService HIVE-26522: Added test for HIVE-22033 regarding delegation token renewal (apache#3585) HIVE-26676: Count distinct in subquery returning wrong results (Steve Carlin, reviewed by Alessandro Solimando, Aman Sinha, Krisztian Kasa) HIVE-26736: Authorization failure for nested Views having WITH clause. (apache#3760). (Ayush Saxena, reviewed by Denys Kuzmenko) HIVE-26628: Iceberg table is created when running explain ctas command (Krisztian Kasa, reviewed by Denys Kuzmenko) HIVE-26734: Iceberg: Add an option to allow positional delete files without actual row data. (apache#3758). (Ayush Saxena, reviewed by Adam Szita, Denys Kuzmenko) HIVE-26524: Use Calcite to remove sections of a query plan known never produces rows - ADDENDUM (Krisztian Kasa, reviewed by Stamatis Zampetakis) HIVE-26740: HS2 makes direct connections to HMS backend DB due to Compaction/StatsUpdater (apache#3765) (Adam Szita, reviewed by Zhihua Deng) HIVE-26631: Remove unused Thrift config parameters login.timeout and exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis) Closes apache#3672 HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) ADDENDUM HIVE-26745: HPL unable to handle Decimal or null values in hplsql mode (apache#3769) (Adam Szita, reviewed by Attila Magyar and Denys Kuzmenko) HIVE-26722: HiveFilterSetOpTransposeRule incorrectly prunes UNION ALL operands. (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa) HIVE-26746: Request tracking: change to X-Request-ID header (apache#3770) (Laszlo Bodor reviewed by Zhihua Deng) HIVE-26624: Set repl.background.enable on target after failover completion (Vinit Patni, reviewed by László Pintér, Teddy Choi) Co-authored-by: vpatni <vpatni@cloudera.com> HIVE-26712: HCatMapReduceTest writes test files in project base directory instead of build directory. (apache#3738) (Chris Nauroth reviewed by Ayush Saxena) HIVE-26726: Tinyint column with windowing fn crashes at runtime (Steve Carlin, reviewed by Aman Sinha, Krisztian Kasa) HIVE-26680: Make CMV use Direct Insert Semantics (Sourabh Badhya, reviewed by Denys Kuzmenko, Laszlo Vegh) Closes apache#3715 HIVE-26243: Add vectorized implementation of the 'ds_kll_sketch' UDAF (Alessandro Solimando, reviewed by Denys Kuzmenko, Zoltan Haindrich) Closes apache#3317 HIVE-26761: Add result sorting to complex_alias.q (apache#3783) (Balazs Cseh reviewed by Laszlo Bodor) HIVE-26759: Update SHOW COMPACTIONS query to support Postgres HMS (Akshat Mathur, reviewed by Denys Kuzmenko, Zsolt Miskolczi) Closes 3782 HIVE-26765: Hive Ranger URL policy for insert overwrite directory denies access when fully qualified paths are passed (apache#3790) (Simhadri Govindappa, reviewed by Adam Szita) Small refactors Fix bug
InvisibleProgrammer
pushed a commit
to InvisibleProgrammer/hive
that referenced
this pull request
Jul 14, 2023
Comment out classes to work on to be able to build the module Refator TestCopyUtils.java Before refactor: TestReplDumpTask Refactor TestReplDumpTask.java Before refactor: TestAtlasLoadTask Refactor TestAtlasLoadTask.java Refator TestRangerDumpTask.java Before refactor: TestCompactionHeartbeatService Refactor TestCompactionHeartbeatService.java Before refactor: TestRetryable Refactor TestRetryable.java Before refactor: TestRangerLoadTask Refactor: RangerLoadTask Before refactor: TestAtlasDumpTask Refactor: AtlasDumpTask Before refactor: TestPrimaryToReplicaResourceFunction Refactor TestPrimaryToReplicaResourceFunction Before refactor: TestExportService Refactor: TestExportService HIVE-26522: Added test for HIVE-22033 regarding delegation token renewal (apache#3585) HIVE-26676: Count distinct in subquery returning wrong results (Steve Carlin, reviewed by Alessandro Solimando, Aman Sinha, Krisztian Kasa) HIVE-26736: Authorization failure for nested Views having WITH clause. (apache#3760). (Ayush Saxena, reviewed by Denys Kuzmenko) HIVE-26628: Iceberg table is created when running explain ctas command (Krisztian Kasa, reviewed by Denys Kuzmenko) HIVE-26734: Iceberg: Add an option to allow positional delete files without actual row data. (apache#3758). (Ayush Saxena, reviewed by Adam Szita, Denys Kuzmenko) HIVE-26524: Use Calcite to remove sections of a query plan known never produces rows - ADDENDUM (Krisztian Kasa, reviewed by Stamatis Zampetakis) HIVE-26740: HS2 makes direct connections to HMS backend DB due to Compaction/StatsUpdater (apache#3765) (Adam Szita, reviewed by Zhihua Deng) HIVE-26631: Remove unused Thrift config parameters login.timeout and exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis) Closes apache#3672 HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) ADDENDUM HIVE-26745: HPL unable to handle Decimal or null values in hplsql mode (apache#3769) (Adam Szita, reviewed by Attila Magyar and Denys Kuzmenko) HIVE-26722: HiveFilterSetOpTransposeRule incorrectly prunes UNION ALL operands. (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa) HIVE-26746: Request tracking: change to X-Request-ID header (apache#3770) (Laszlo Bodor reviewed by Zhihua Deng) HIVE-26624: Set repl.background.enable on target after failover completion (Vinit Patni, reviewed by László Pintér, Teddy Choi) Co-authored-by: vpatni <vpatni@cloudera.com> HIVE-26712: HCatMapReduceTest writes test files in project base directory instead of build directory. (apache#3738) (Chris Nauroth reviewed by Ayush Saxena) HIVE-26726: Tinyint column with windowing fn crashes at runtime (Steve Carlin, reviewed by Aman Sinha, Krisztian Kasa) HIVE-26680: Make CMV use Direct Insert Semantics (Sourabh Badhya, reviewed by Denys Kuzmenko, Laszlo Vegh) Closes apache#3715 HIVE-26243: Add vectorized implementation of the 'ds_kll_sketch' UDAF (Alessandro Solimando, reviewed by Denys Kuzmenko, Zoltan Haindrich) Closes apache#3317 HIVE-26761: Add result sorting to complex_alias.q (apache#3783) (Balazs Cseh reviewed by Laszlo Bodor) HIVE-26759: Update SHOW COMPACTIONS query to support Postgres HMS (Akshat Mathur, reviewed by Denys Kuzmenko, Zsolt Miskolczi) Closes 3782 HIVE-26765: Hive Ranger URL policy for insert overwrite directory denies access when fully qualified paths are passed (apache#3790) (Simhadri Govindappa, reviewed by Adam Szita) Small refactors Fix bug
InvisibleProgrammer
pushed a commit
to InvisibleProgrammer/hive
that referenced
this pull request
Jul 19, 2023
Comment out classes to work on to be able to build the module Refator TestCopyUtils.java Before refactor: TestReplDumpTask Refactor TestReplDumpTask.java Before refactor: TestAtlasLoadTask Refactor TestAtlasLoadTask.java Refator TestRangerDumpTask.java Before refactor: TestCompactionHeartbeatService Refactor TestCompactionHeartbeatService.java Before refactor: TestRetryable Refactor TestRetryable.java Before refactor: TestRangerLoadTask Refactor: RangerLoadTask Before refactor: TestAtlasDumpTask Refactor: AtlasDumpTask Before refactor: TestPrimaryToReplicaResourceFunction Refactor TestPrimaryToReplicaResourceFunction Before refactor: TestExportService Refactor: TestExportService HIVE-26522: Added test for HIVE-22033 regarding delegation token renewal (apache#3585) HIVE-26676: Count distinct in subquery returning wrong results (Steve Carlin, reviewed by Alessandro Solimando, Aman Sinha, Krisztian Kasa) HIVE-26736: Authorization failure for nested Views having WITH clause. (apache#3760). (Ayush Saxena, reviewed by Denys Kuzmenko) HIVE-26628: Iceberg table is created when running explain ctas command (Krisztian Kasa, reviewed by Denys Kuzmenko) HIVE-26734: Iceberg: Add an option to allow positional delete files without actual row data. (apache#3758). (Ayush Saxena, reviewed by Adam Szita, Denys Kuzmenko) HIVE-26524: Use Calcite to remove sections of a query plan known never produces rows - ADDENDUM (Krisztian Kasa, reviewed by Stamatis Zampetakis) HIVE-26740: HS2 makes direct connections to HMS backend DB due to Compaction/StatsUpdater (apache#3765) (Adam Szita, reviewed by Zhihua Deng) HIVE-26631: Remove unused Thrift config parameters login.timeout and exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis) Closes apache#3672 HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) ADDENDUM HIVE-26745: HPL unable to handle Decimal or null values in hplsql mode (apache#3769) (Adam Szita, reviewed by Attila Magyar and Denys Kuzmenko) HIVE-26722: HiveFilterSetOpTransposeRule incorrectly prunes UNION ALL operands. (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa) HIVE-26746: Request tracking: change to X-Request-ID header (apache#3770) (Laszlo Bodor reviewed by Zhihua Deng) HIVE-26624: Set repl.background.enable on target after failover completion (Vinit Patni, reviewed by László Pintér, Teddy Choi) Co-authored-by: vpatni <vpatni@cloudera.com> HIVE-26712: HCatMapReduceTest writes test files in project base directory instead of build directory. (apache#3738) (Chris Nauroth reviewed by Ayush Saxena) HIVE-26726: Tinyint column with windowing fn crashes at runtime (Steve Carlin, reviewed by Aman Sinha, Krisztian Kasa) HIVE-26680: Make CMV use Direct Insert Semantics (Sourabh Badhya, reviewed by Denys Kuzmenko, Laszlo Vegh) Closes apache#3715 HIVE-26243: Add vectorized implementation of the 'ds_kll_sketch' UDAF (Alessandro Solimando, reviewed by Denys Kuzmenko, Zoltan Haindrich) Closes apache#3317 HIVE-26761: Add result sorting to complex_alias.q (apache#3783) (Balazs Cseh reviewed by Laszlo Bodor) HIVE-26759: Update SHOW COMPACTIONS query to support Postgres HMS (Akshat Mathur, reviewed by Denys Kuzmenko, Zsolt Miskolczi) Closes 3782 HIVE-26765: Hive Ranger URL policy for insert overwrite directory denies access when fully qualified paths are passed (apache#3790) (Simhadri Govindappa, reviewed by Adam Szita) Small refactors Fix bug
yeahyung
pushed a commit
to yeahyung/hive
that referenced
this pull request
Jul 20, 2023
…exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis) Closes apache#3672
InvisibleProgrammer
pushed a commit
to InvisibleProgrammer/hive
that referenced
this pull request
Aug 7, 2023
Comment out classes to work on to be able to build the module Refator TestCopyUtils.java Before refactor: TestReplDumpTask Refactor TestReplDumpTask.java Before refactor: TestAtlasLoadTask Refactor TestAtlasLoadTask.java Refator TestRangerDumpTask.java Before refactor: TestCompactionHeartbeatService Refactor TestCompactionHeartbeatService.java Before refactor: TestRetryable Refactor TestRetryable.java Before refactor: TestRangerLoadTask Refactor: RangerLoadTask Before refactor: TestAtlasDumpTask Refactor: AtlasDumpTask Before refactor: TestPrimaryToReplicaResourceFunction Refactor TestPrimaryToReplicaResourceFunction Before refactor: TestExportService Refactor: TestExportService HIVE-26522: Added test for HIVE-22033 regarding delegation token renewal (apache#3585) HIVE-26676: Count distinct in subquery returning wrong results (Steve Carlin, reviewed by Alessandro Solimando, Aman Sinha, Krisztian Kasa) HIVE-26736: Authorization failure for nested Views having WITH clause. (apache#3760). (Ayush Saxena, reviewed by Denys Kuzmenko) HIVE-26628: Iceberg table is created when running explain ctas command (Krisztian Kasa, reviewed by Denys Kuzmenko) HIVE-26734: Iceberg: Add an option to allow positional delete files without actual row data. (apache#3758). (Ayush Saxena, reviewed by Adam Szita, Denys Kuzmenko) HIVE-26524: Use Calcite to remove sections of a query plan known never produces rows - ADDENDUM (Krisztian Kasa, reviewed by Stamatis Zampetakis) HIVE-26740: HS2 makes direct connections to HMS backend DB due to Compaction/StatsUpdater (apache#3765) (Adam Szita, reviewed by Zhihua Deng) HIVE-26631: Remove unused Thrift config parameters login.timeout and exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis) Closes apache#3672 HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) ADDENDUM HIVE-26745: HPL unable to handle Decimal or null values in hplsql mode (apache#3769) (Adam Szita, reviewed by Attila Magyar and Denys Kuzmenko) HIVE-26722: HiveFilterSetOpTransposeRule incorrectly prunes UNION ALL operands. (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa) HIVE-26746: Request tracking: change to X-Request-ID header (apache#3770) (Laszlo Bodor reviewed by Zhihua Deng) HIVE-26624: Set repl.background.enable on target after failover completion (Vinit Patni, reviewed by László Pintér, Teddy Choi) Co-authored-by: vpatni <vpatni@cloudera.com> HIVE-26712: HCatMapReduceTest writes test files in project base directory instead of build directory. (apache#3738) (Chris Nauroth reviewed by Ayush Saxena) HIVE-26726: Tinyint column with windowing fn crashes at runtime (Steve Carlin, reviewed by Aman Sinha, Krisztian Kasa) HIVE-26680: Make CMV use Direct Insert Semantics (Sourabh Badhya, reviewed by Denys Kuzmenko, Laszlo Vegh) Closes apache#3715 HIVE-26243: Add vectorized implementation of the 'ds_kll_sketch' UDAF (Alessandro Solimando, reviewed by Denys Kuzmenko, Zoltan Haindrich) Closes apache#3317 HIVE-26761: Add result sorting to complex_alias.q (apache#3783) (Balazs Cseh reviewed by Laszlo Bodor) HIVE-26759: Update SHOW COMPACTIONS query to support Postgres HMS (Akshat Mathur, reviewed by Denys Kuzmenko, Zsolt Miskolczi) Closes 3782 HIVE-26765: Hive Ranger URL policy for insert overwrite directory denies access when fully qualified paths are passed (apache#3790) (Simhadri Govindappa, reviewed by Adam Szita) Small refactors Fix bug
InvisibleProgrammer
pushed a commit
to InvisibleProgrammer/hive
that referenced
this pull request
Sep 11, 2023
Comment out classes to work on to be able to build the module Refator TestCopyUtils.java Before refactor: TestReplDumpTask Refactor TestReplDumpTask.java Before refactor: TestAtlasLoadTask Refactor TestAtlasLoadTask.java Refator TestRangerDumpTask.java Before refactor: TestCompactionHeartbeatService Refactor TestCompactionHeartbeatService.java Before refactor: TestRetryable Refactor TestRetryable.java Before refactor: TestRangerLoadTask Refactor: RangerLoadTask Before refactor: TestAtlasDumpTask Refactor: AtlasDumpTask Before refactor: TestPrimaryToReplicaResourceFunction Refactor TestPrimaryToReplicaResourceFunction Before refactor: TestExportService Refactor: TestExportService HIVE-26522: Added test for HIVE-22033 regarding delegation token renewal (apache#3585) HIVE-26676: Count distinct in subquery returning wrong results (Steve Carlin, reviewed by Alessandro Solimando, Aman Sinha, Krisztian Kasa) HIVE-26736: Authorization failure for nested Views having WITH clause. (apache#3760). (Ayush Saxena, reviewed by Denys Kuzmenko) HIVE-26628: Iceberg table is created when running explain ctas command (Krisztian Kasa, reviewed by Denys Kuzmenko) HIVE-26734: Iceberg: Add an option to allow positional delete files without actual row data. (apache#3758). (Ayush Saxena, reviewed by Adam Szita, Denys Kuzmenko) HIVE-26524: Use Calcite to remove sections of a query plan known never produces rows - ADDENDUM (Krisztian Kasa, reviewed by Stamatis Zampetakis) HIVE-26740: HS2 makes direct connections to HMS backend DB due to Compaction/StatsUpdater (apache#3765) (Adam Szita, reviewed by Zhihua Deng) HIVE-26631: Remove unused Thrift config parameters login.timeout and exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis) Closes apache#3672 HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) ADDENDUM HIVE-26745: HPL unable to handle Decimal or null values in hplsql mode (apache#3769) (Adam Szita, reviewed by Attila Magyar and Denys Kuzmenko) HIVE-26722: HiveFilterSetOpTransposeRule incorrectly prunes UNION ALL operands. (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa) HIVE-26746: Request tracking: change to X-Request-ID header (apache#3770) (Laszlo Bodor reviewed by Zhihua Deng) HIVE-26624: Set repl.background.enable on target after failover completion (Vinit Patni, reviewed by László Pintér, Teddy Choi) Co-authored-by: vpatni <vpatni@cloudera.com> HIVE-26712: HCatMapReduceTest writes test files in project base directory instead of build directory. (apache#3738) (Chris Nauroth reviewed by Ayush Saxena) HIVE-26726: Tinyint column with windowing fn crashes at runtime (Steve Carlin, reviewed by Aman Sinha, Krisztian Kasa) HIVE-26680: Make CMV use Direct Insert Semantics (Sourabh Badhya, reviewed by Denys Kuzmenko, Laszlo Vegh) Closes apache#3715 HIVE-26243: Add vectorized implementation of the 'ds_kll_sketch' UDAF (Alessandro Solimando, reviewed by Denys Kuzmenko, Zoltan Haindrich) Closes apache#3317 HIVE-26761: Add result sorting to complex_alias.q (apache#3783) (Balazs Cseh reviewed by Laszlo Bodor) HIVE-26759: Update SHOW COMPACTIONS query to support Postgres HMS (Akshat Mathur, reviewed by Denys Kuzmenko, Zsolt Miskolczi) Closes 3782 HIVE-26765: Hive Ranger URL policy for insert overwrite directory denies access when fully qualified paths are passed (apache#3790) (Simhadri Govindappa, reviewed by Adam Szita) Small refactors Fix bug
InvisibleProgrammer
pushed a commit
to InvisibleProgrammer/hive
that referenced
this pull request
Sep 11, 2023
Comment out classes to work on to be able to build the module Refator TestCopyUtils.java Before refactor: TestReplDumpTask Refactor TestReplDumpTask.java Before refactor: TestAtlasLoadTask Refactor TestAtlasLoadTask.java Refator TestRangerDumpTask.java Before refactor: TestCompactionHeartbeatService Refactor TestCompactionHeartbeatService.java Before refactor: TestRetryable Refactor TestRetryable.java Before refactor: TestRangerLoadTask Refactor: RangerLoadTask Before refactor: TestAtlasDumpTask Refactor: AtlasDumpTask Before refactor: TestPrimaryToReplicaResourceFunction Refactor TestPrimaryToReplicaResourceFunction Before refactor: TestExportService Refactor: TestExportService HIVE-26522: Added test for HIVE-22033 regarding delegation token renewal (apache#3585) HIVE-26676: Count distinct in subquery returning wrong results (Steve Carlin, reviewed by Alessandro Solimando, Aman Sinha, Krisztian Kasa) HIVE-26736: Authorization failure for nested Views having WITH clause. (apache#3760). (Ayush Saxena, reviewed by Denys Kuzmenko) HIVE-26628: Iceberg table is created when running explain ctas command (Krisztian Kasa, reviewed by Denys Kuzmenko) HIVE-26734: Iceberg: Add an option to allow positional delete files without actual row data. (apache#3758). (Ayush Saxena, reviewed by Adam Szita, Denys Kuzmenko) HIVE-26524: Use Calcite to remove sections of a query plan known never produces rows - ADDENDUM (Krisztian Kasa, reviewed by Stamatis Zampetakis) HIVE-26740: HS2 makes direct connections to HMS backend DB due to Compaction/StatsUpdater (apache#3765) (Adam Szita, reviewed by Zhihua Deng) HIVE-26631: Remove unused Thrift config parameters login.timeout and exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis) Closes apache#3672 HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) ADDENDUM HIVE-26745: HPL unable to handle Decimal or null values in hplsql mode (apache#3769) (Adam Szita, reviewed by Attila Magyar and Denys Kuzmenko) HIVE-26722: HiveFilterSetOpTransposeRule incorrectly prunes UNION ALL operands. (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa) HIVE-26746: Request tracking: change to X-Request-ID header (apache#3770) (Laszlo Bodor reviewed by Zhihua Deng) HIVE-26624: Set repl.background.enable on target after failover completion (Vinit Patni, reviewed by László Pintér, Teddy Choi) Co-authored-by: vpatni <vpatni@cloudera.com> HIVE-26712: HCatMapReduceTest writes test files in project base directory instead of build directory. (apache#3738) (Chris Nauroth reviewed by Ayush Saxena) HIVE-26726: Tinyint column with windowing fn crashes at runtime (Steve Carlin, reviewed by Aman Sinha, Krisztian Kasa) HIVE-26680: Make CMV use Direct Insert Semantics (Sourabh Badhya, reviewed by Denys Kuzmenko, Laszlo Vegh) Closes apache#3715 HIVE-26243: Add vectorized implementation of the 'ds_kll_sketch' UDAF (Alessandro Solimando, reviewed by Denys Kuzmenko, Zoltan Haindrich) Closes apache#3317 HIVE-26761: Add result sorting to complex_alias.q (apache#3783) (Balazs Cseh reviewed by Laszlo Bodor) HIVE-26759: Update SHOW COMPACTIONS query to support Postgres HMS (Akshat Mathur, reviewed by Denys Kuzmenko, Zsolt Miskolczi) Closes 3782 HIVE-26765: Hive Ranger URL policy for insert overwrite directory denies access when fully qualified paths are passed (apache#3790) (Simhadri Govindappa, reviewed by Adam Szita) Small refactors Fix bug Remove uneccessary constructor Upgrading mockito in hive-exec
InvisibleProgrammer
pushed a commit
to InvisibleProgrammer/hive
that referenced
this pull request
Sep 16, 2023
# This is the 1st commit message: Start to refactor Comment out classes to work on to be able to build the module Refator TestCopyUtils.java Before refactor: TestReplDumpTask Refactor TestReplDumpTask.java Before refactor: TestAtlasLoadTask Refactor TestAtlasLoadTask.java Refator TestRangerDumpTask.java Before refactor: TestCompactionHeartbeatService Refactor TestCompactionHeartbeatService.java Before refactor: TestRetryable Refactor TestRetryable.java Before refactor: TestRangerLoadTask Refactor: RangerLoadTask Before refactor: TestAtlasDumpTask Refactor: AtlasDumpTask Before refactor: TestPrimaryToReplicaResourceFunction Refactor TestPrimaryToReplicaResourceFunction Before refactor: TestExportService Refactor: TestExportService HIVE-26522: Added test for HIVE-22033 regarding delegation token renewal (apache#3585) HIVE-26676: Count distinct in subquery returning wrong results (Steve Carlin, reviewed by Alessandro Solimando, Aman Sinha, Krisztian Kasa) HIVE-26736: Authorization failure for nested Views having WITH clause. (apache#3760). (Ayush Saxena, reviewed by Denys Kuzmenko) HIVE-26628: Iceberg table is created when running explain ctas command (Krisztian Kasa, reviewed by Denys Kuzmenko) HIVE-26734: Iceberg: Add an option to allow positional delete files without actual row data. (apache#3758). (Ayush Saxena, reviewed by Adam Szita, Denys Kuzmenko) HIVE-26524: Use Calcite to remove sections of a query plan known never produces rows - ADDENDUM (Krisztian Kasa, reviewed by Stamatis Zampetakis) HIVE-26740: HS2 makes direct connections to HMS backend DB due to Compaction/StatsUpdater (apache#3765) (Adam Szita, reviewed by Zhihua Deng) HIVE-26631: Remove unused Thrift config parameters login.timeout and exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis) Closes apache#3672 HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) ADDENDUM HIVE-26745: HPL unable to handle Decimal or null values in hplsql mode (apache#3769) (Adam Szita, reviewed by Attila Magyar and Denys Kuzmenko) HIVE-26722: HiveFilterSetOpTransposeRule incorrectly prunes UNION ALL operands. (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa) HIVE-26746: Request tracking: change to X-Request-ID header (apache#3770) (Laszlo Bodor reviewed by Zhihua Deng) HIVE-26624: Set repl.background.enable on target after failover completion (Vinit Patni, reviewed by László Pintér, Teddy Choi) Co-authored-by: vpatni <vpatni@cloudera.com> HIVE-26712: HCatMapReduceTest writes test files in project base directory instead of build directory. (apache#3738) (Chris Nauroth reviewed by Ayush Saxena) HIVE-26726: Tinyint column with windowing fn crashes at runtime (Steve Carlin, reviewed by Aman Sinha, Krisztian Kasa) HIVE-26680: Make CMV use Direct Insert Semantics (Sourabh Badhya, reviewed by Denys Kuzmenko, Laszlo Vegh) Closes apache#3715 HIVE-26243: Add vectorized implementation of the 'ds_kll_sketch' UDAF (Alessandro Solimando, reviewed by Denys Kuzmenko, Zoltan Haindrich) Closes apache#3317 HIVE-26761: Add result sorting to complex_alias.q (apache#3783) (Balazs Cseh reviewed by Laszlo Bodor) HIVE-26759: Update SHOW COMPACTIONS query to support Postgres HMS (Akshat Mathur, reviewed by Denys Kuzmenko, Zsolt Miskolczi) Closes 3782 HIVE-26765: Hive Ranger URL policy for insert overwrite directory denies access when fully qualified paths are passed (apache#3790) (Simhadri Govindappa, reviewed by Adam Szita) Small refactors Fix bug # This is the commit message apache#2: Remove uneccessary constructor
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
…exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis) Closes apache#3672
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Remove unused variable and hiveConf for ThriftBinaryCLIService class
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests